* Force depot_tools to use python3 results (USE_PYTHON3=True).
* Fixes the dart format presubmit check.
* Remove broken DOM tools presubmit check.
TEST=Manually provoked errors and ran git cl presubmit -v -f.
Cq-Include-Trybots: luci.dart.try.shared:presubmit-try
Change-Id: I8ba46e2ae1640f1b2f82e18bc8024e0aa4838b2b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210123
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: William Hesse <whesse@google.com>
`dartfmt` is deprecated and will be removed in a future release.
Change-Id: I6572efd1ba2919f6891a90c890a9475933f94202
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206584
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
This reverts commit a2ceec3e25.
Reason for revert: presubmit hooks are run very early (before CL description is edited), which breaks common workflows.
Original change's description:
> Require that all changes to VM have TEST line
>
> All changes touching one of the following directories will after this
> change be required to contain TEST= line.
>
> runtime/vm
> runtime/bin
> runtime/lib
> runtime/include
> runtime/observatory
> runtime/observatory_2
> runtime/platform
> sdk/lib/_internal/vm
> pkg/vm
>
> This line is supposed to describe in free form how change was validated,
> for example by listing existing or newly added tests.
>
> The goal behind this requirement is to remind both reviewer and change
> author that changes to the code base are in general expected to be
> covered by tests, especially when CL is addressing a regression which
> slipped through existing testing.
>
> Having TEST line in the description would allow both author and
> reviewer to take additional time to consider if validation was
> sufficient or additional test coverage is needed.
>
> The inspiration for this line comes from Chromium[1].
>
> [1] https://chromium.googlesource.com/chromiumos/docs/+/master/contributing.md#describe-testing-performed
>
> TEST=changed file in runtime/vm and run git cl presubmit
>
> Change-Id: Ie16cf7c14af18e3a22a17084c0aebb4d1dfd6d23
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/169640
> Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>
> Reviewed-by: Siva Annamalai <asiva@google.com>
TBR=vegorov@google.com,kustermann@google.com,asiva@google.com
Change-Id: Ib2e198c322447e8d1166d5d05b2f3209d168f1e9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/169887
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
All changes touching one of the following directories will after this
change be required to contain TEST= line.
runtime/vm
runtime/bin
runtime/lib
runtime/include
runtime/observatory
runtime/observatory_2
runtime/platform
sdk/lib/_internal/vm
pkg/vm
This line is supposed to describe in free form how change was validated,
for example by listing existing or newly added tests.
The goal behind this requirement is to remind both reviewer and change
author that changes to the code base are in general expected to be
covered by tests, especially when CL is addressing a regression which
slipped through existing testing.
Having TEST line in the description would allow both author and
reviewer to take additional time to consider if validation was
sufficient or additional test coverage is needed.
The inspiration for this line comes from Chromium[1].
[1] https://chromium.googlesource.com/chromiumos/docs/+/master/contributing.md#describe-testing-performed
TEST=changed file in runtime/vm and run git cl presubmit
Change-Id: Ie16cf7c14af18e3a22a17084c0aebb4d1dfd6d23
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/169640
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Move the nnbd core libraries from sdk_nnbd to sdk, and updates
references in build files and elsewhere accordingly.
Change-Id: I09760fe1e006657aacdfe80f3b22fdf6f7e30a9f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151121
Commit-Queue: Leaf Petersen <leafp@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Status files have different names in different folders.
Change-Id: I291b38cc6dae96ff7101c204a93d247580c64313
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149841
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
This CL ensures that the presubmit check will complain if newly added
tests were only added to NNBD suite but not to non-NNBD (or vice versa).
Also add ffi test suites to the list of checked directories.
Change-Id: I090064b99e5ca30444ab53edf1f262572f60beb9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149426
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
This change adds a rule to the SDK PRESUBMIT.py to validate that the
test matrix used by the CI/CQ builders does not contain errors.
Change-Id: Ie967e71dda76677f4db84c1e9e613d702b57069f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147547
Commit-Queue: Karl Klose <karlklose@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
I recently added this presubmit to verify changes get replicated
between versions of the SDK and the paths of the current SDK
didn't get created correctly causing it to warn even when you
correctly replicated the changes.
Change-Id: If69e0375dfe097e0210c4249d77b49f0c3537a2c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143640
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
The logic in one subdirectory of the SDK is being unforked so
we need to ensure changes are mirrored in both directions.
Change-Id: I6485bcafe4ebaf135c5683660e8cac3bd9945033
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143003
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
This only validates that if a test and its fork exist that the CL
touches both. There are lots of other cases we could imagine checking
like if you *add* a new test on one side, you should one on the other.
But those are likely to have a lot of false positives now while the
migration is happening and new NNBD tests are being written.
So for now, this just tries to check that tests that have been forked
at least don't diverge. It's a start.
Change-Id: Id6a9c39699a510da1a4a4702879210f94cd69c26
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131945
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
- Removes the load port functionality from the service isolate, this was
used to load sources in Dart 1 and is pretty much dead code in Dart 2
- Moves resolution of URIs and Package URI (based on package map) to the
individual isolates instead of sending a request to the service isolate
- Setups the package map lazily as it is needed only if resolveURI is
called in Dart code, it is not needed for loading/compiling sources
(this is now done in the front end).
- Removed Dart_ServiceWaitForLoadPort() methods from the Dart C API as
it is not used anywhere.
Change-Id: I6c3704bc431bdcd49bf074eb58bee1ed492ccccb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129742
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
This will include checks for python file formatting thanks to the
presence of the `.style.yapf` file at the root of the repo.
- Refactor to a `_CommonChecks` to reduce duplication and use
`results.extend` so that each check is defined on its own line.
- Add the `canned_checks.CheckPatchFormatted` check.
See discussion at https://dart-review.googlesource.com/c/sdk/+/111600
Change-Id: I089112c309bf6b9a518c85fa6b66200b75519e33
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116364
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Fixes also some implicit to bool conversions in native_api_impl.cc
Change-Id: I31aecaa1e442f7f934de46ee019765f9f0746658
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115248
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
- Add `.style.yapf` with configuration to use Google style.
- Run `yapf` on all `.py` files in this repo.
- Manually fix one trailing space in a doc string.
- Run `git cl format runtime` to satisfy presubmit.
Change-Id: I7e6bd11e91f07926b9188362599af398551eed79
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111600
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
See comments on https://dart-review.googlesource.com/c/sdk/+/106726
- Add a `should_skip` argument to `_CheckFormat` to suppress warnings in
files that are opted out of format checking.
- Skip status file lint checks for files under
"pkg/status_file/test/data" and "pkg/front_end".
Change-Id: I485cf32c5193bbbc7ef2b92bfc401399acda85c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106925
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Change-Id: Icb6f5f2b170dc3413d7d8de5dbd3001f3b8a053c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106728
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Jacob Richman <jacobr@google.com>
Commit-Queue: Jacob Richman <jacobr@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Change-Id: Ie3e55422dc891f3ba37df887f5c96751669dd4cc
Reviewed-on: https://dart-review.googlesource.com/c/90224
Commit-Queue: Peter von der Ahé <ahe@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
- Introduce a slimmed down version of thread.h, which just depends on the
Zone and StackResource.
- Introduce a layering check that would prevent the coupling in the future.
This is the first step towards decoupling compiler from runtime.
There are multiple reasons to introduce the decoupling but the main
reason currently is to introduce a controlled surface through which
compiler reaches into runtime to catch any places where runtime word size
might influence the compiler and then enable building compiler that
targets 32-bit runtime but is embedded into a 64-bit runtime.
Issue https://github.com/dart-lang/sdk/issues/31709
Change-Id: Id63ebbaddca55dd097298e51c90d957a73fa476e
Reviewed-on: https://dart-review.googlesource.com/c/87182
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
This deletes:
tests/co19
tests/corelib
tests/html
tests/isolate
tests/language
tests/lib
It does not delete tests/standalone because apparently there are tests
in there that are not in standalone_2. (I assume they were added after
the test migration. I don't know why they were added there.)
I have tried to remove references to the old tests from various scripts
and tools but may have missed some. (As you can imagine, grepping for
"lib" does not have the best signal-to-noise ratio.)
"It was a pleasure to burn. It was a special pleasure to see things
eaten, to see things blackened and changed. With the brass nozzle in his
fists, with this great python spitting its venomous kerosene upon the
world, the blood pounded in his head, and his hands were the hands of
some amazing conductor playing all the symphonies of blazing and burning
to bring down the tatters and charcoal ruins of history."
- Ray Bradbury, Fahrenheit 451
Change-Id: If3db4a50e7a5ee25aff8058b1483e2ce8e68424e
Reviewed-on: https://dart-review.googlesource.com/c/75420
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Fix test expectations.
Improve test (overly complex).
Mark tests/isolate as immutable to the presubmit script (like other migrated Dart 1 test directories).
(Gardening)
Change-Id: Iec59c59ca992b3dacafbf82176e4e8bd8c5bd3c5
Reviewed-on: https://dart-review.googlesource.com/42945
Reviewed-by: William Hesse <whesse@google.com>
This CL normalizes all status files by the status file normalizer found at
pkg/status_file/bin/normalize.dart.
To make sure all status files are kept in pristine condition, a linter is placed
on the presubmit hook. The linter can be found at pkg/status_file/bin/lint.dart.
Bug:
Change-Id: I20bdb74824be65f079b8c9ab08b7ae38394d637f
Reviewed-on: https://dart-review.googlesource.com/24112
Commit-Queue: Morten Krogh-jespersen <mkroghj@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Only allow .status files in Dart 1.0 test directories to be changed.
R=rnystrom@google.com
Change-Id: Ic95b76eb53e7d5ab6b795425a7a97f0fded01a5b
Reviewed-on: https://dart-review.googlesource.com/14120
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
What is dead may never die.
Change-Id: I80ef766b8ce2b6e1416df8e1f9b91fb74169dc79
Reviewed-on: https://dart-review.googlesource.com/7483
Reviewed-by: William Hesse <whesse@google.com>
If the file has a syntax error, it can't be formatted. We don't want to
block submission on that since we do have lots of files in the repo
that deliberately contain syntax errors.
R=jacobr@google.com
Review-Url: https://codereview.chromium.org/2987883002 .
PRESUBMIT will check:
1. a new test can NOT be added to Dart 1.0 the new test can only be added to DDC.
2. a existing Dart 1.0 test changed must have its corresponding DDC test updated too (if it exists).
Presubmit errors may appear as:
** Presubmit ERRORS **
Error: If you change a Dart 1.0 test, you must also update the DDC test:
1. Dart 1.0 test changed: tests/corelib/symbol_map_helper.dart
1. DDC test must change: tests/corelib_2/symbol_map_helper.dart
2. Dart 1.0 test changed: tests/language/compiler_annotations.dart
2. DDC test must change: tests/language_2/compiler_annotations.dart
R=jacobr@google.com, rnystrom@google.com
Error: New Dart 1.0 test can not be added the test must be added as a DDC test:
Fix tests:
1. New Dart 1.0 test: tests/corelib/new_test.dart
1. Should be DDC test: tests/corelib_2/new_test.dart
2. New Dart 1.0 test: tests/language/new_test.dart
2. Should be DDC test: tests/language_2/new_test.dart
Review-Url: https://codereview.chromium.org/2982043002 .
