languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-07-20 09:54:38 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Add canned_checks.CheckPatchFormatted to presubmit

Browse source 
This will include checks for python file formatting thanks to the
presence of the `.style.yapf` file at the root of the repo.

- Refactor to a `_CommonChecks` to reduce duplication and use
  `results.extend` so that each check is defined on its own line.
- Add the `canned_checks.CheckPatchFormatted` check.

See discussion at https://dart-review.googlesource.com/c/sdk/+/111600

Change-Id: I089112c309bf6b9a518c85fa6b66200b75519e33
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116364
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
This commit is contained in:
Nate Bosch 2019-09-10 19:22:52 +00:00 committed by commit-bot@chromium.org
parent 004d49bd6b
commit 557f9121a5
1 changed files with 17 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
PRESUBMIT.py
View file

@ -250,16 +250,24 @@ def _CheckClangTidy(input_api, output_api):
long_text=stdout)
]
def _CommonChecks(input_api, output_api):
results = []
results.extend(_CheckValidHostsInDEPS(input_api, output_api))
results.extend(_CheckDartFormat(input_api, output_api))
results.extend(_CheckStatusFiles(input_api, output_api))
results.extend(_CheckLayering(input_api, output_api))
results.extend(_CheckClangTidy(input_api, output_api))
results.extend(
input_api.canned_checks.CheckPatchFormatted(input_api, output_api))
return results
def CheckChangeOnCommit(input_api, output_api):
return (_CheckValidHostsInDEPS(input_api, output_api) + _CheckBuildStatus(
input_api, output_api) + _CheckDartFormat(input_api, output_api) +
_CheckStatusFiles(input_api, output_api) + _CheckLayering(
input_api, output_api) + _CheckClangTidy(
input_api, output_api))
results = _CommonChecks(input_api, output_api)
results.extend(_CheckBuildStatus(input_api, output_api))
return results
def CheckChangeOnUpload(input_api, output_api):
return (_CheckValidHostsInDEPS(input_api, output_api) + _CheckDartFormat(
input_api, output_api) + _CheckStatusFiles(input_api, output_api) +
_CheckLayering(input_api, output_api) + _CheckClangTidy(
input_api, output_api))
return _CommonChecks(input_api, output_api)