languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-04 16:44:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

[infra] Check whether sdk and sdk_nnbd are in sync on presubmit.

Browse source 
Change-Id: I3da7f3f59f941fdb25b1fde941ec0a91c710cb4e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116761
Reviewed-by: William Hesse <whesse@google.com>
This commit is contained in:
Jonas Termansen 2019-09-11 10:42:35 +00:00
parent 4d5e15abde
commit 11c5c34d95
1 changed files with 21 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
PRESUBMIT.py
View file

@ -18,6 +18,26 @@ import platform
def is_cpp_file(path):
return path.endswith('.cc') or path.endswith('.h')
def _CheckNnbdSdkSync(input_api, output_api):
files = [git_file.LocalPath() for git_file in input_api.AffectedTextFiles()]
unsynchronized_files = []
for file in files:
if file.startswith('sdk/'):
nnbd_file = 'sdk_nnbd/' + file[4:]
if not nnbd_file in files:
unsynchronized_files.append(nnbd_file)
if unsynchronized_files:
return [
output_api.PresubmitPromptWarning(
'Changes were made to sdk/ that were not made to sdk_nnbd/\n'
'Please update these files as well:\n'
'\n'
'%s' % ('\n'.join(unsynchronized_files)))
]
return []
def _CheckFormat(input_api,
identification,
extension,
@ -243,6 +263,7 @@ def _CheckClangTidy(input_api, output_api):
def _CommonChecks(input_api, output_api):
results = []
results.extend(_CheckNnbdSdkSync(input_api, output_api))
results.extend(_CheckValidHostsInDEPS(input_api, output_api))
results.extend(_CheckDartFormat(input_api, output_api))
results.extend(_CheckStatusFiles(input_api, output_api))