languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-04 18:36:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Move new tests from tests/isolate to tests/lib_2/isolate.

Browse source 
Fix test expectations.
Improve test (overly complex).
Mark tests/isolate as immutable to the presubmit script (like other migrated Dart 1 test directories).

(Gardening)

Change-Id: Iec59c59ca992b3dacafbf82176e4e8bd8c5bd3c5
Reviewed-on: https://dart-review.googlesource.com/42945
Reviewed-by: William Hesse <whesse@google.com>
This commit is contained in:
Lasse R.H. Nielsen 2018-02-22 10:03:23 +00:00 committed by William Hesse
parent 52d1b4e96d
commit 9ec9a4c8da
5 changed files with 6 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
PRESUBMIT.py
View file

@ -115,6 +115,7 @@ def _CheckNewTests(input_api, output_api):
("tests/corelib/", "tests/corelib_2/"),
("tests/lib/", "tests/lib_2/"),
("tests/html/", "tests/lib_2/html/"),
("tests/isolate/", "tests/lib_2/isolate/")
]
result = []

1
tests/isolate/isolate.status
View file

@ -17,7 +17,6 @@ issue_21398_parent_isolate2_test: SkipByDesign # Test uses a ".dart" URI.
issue_21398_parent_isolate_test: SkipByDesign # Test uses a ".dart" URI.
issue_24243_parent_isolate_test: SkipByDesign # Test uses a ".dart" URI.
kill_self_synchronously_test: SkipByDesign # Unsupported operation: Platform._resolvedExecutable
large_byte_data_leak_test: RuntimeError
message3_test/constInstance: RuntimeError # Issue 21817
message3_test/constList: RuntimeError # Issue 21817
message3_test/constList_identical: RuntimeError # Issue 21817

13
tests/isolate/large_byte_data_leak_test.dart → tests/lib_2/isolate/large_byte_data_leak_test.dart
View file

@ -3,10 +3,9 @@
// BSD-style license that can be found in the LICENSE file.
import "dart:async";
import "dart:developer";
import "dart:isolate";
import "dart:typed_data";
import "dart:developer";
import "dart:developer" show UserTag;
import "dart:isolate" show Isolate, ReceivePort;
import "dart:typed_data" show ByteData;
import "package:expect/expect.dart";
const large = 2 * 1024 * 1024;
@ -35,12 +34,8 @@ Future<void> main(List<String> args) async {
ReceivePort port = new ReceivePort();
Isolate.spawn(child, port.sendPort);
StreamIterator<dynamic> incoming = new StreamIterator<dynamic>(port);
Expect.isTrue(await incoming.moveNext());
dynamic x = incoming.current;
Expect.equals("Done", x);
Expect.equals("Done", await port.first);
port.close();
print("Parent done");
}

0
tests/isolate/large_byte_data_test.dart → tests/lib_2/isolate/large_byte_data_test.dart
View file

1
tests/lib_2/lib_2_dart2js.status
View file

@ -763,6 +763,7 @@ isolate/kill_self_synchronously_test: RuntimeError
[ $compiler == dart2js && ($runtime == d8 || $runtime == jsshell) ]
isolate/browser/issue_12474_test: RuntimeError # packageRoot not implemented.
isolate/large_byte_data_leak_test: RuntimeError
[ $compiler == dart2js && ($runtime == ff || $runtime == safari || $ie) ]
html/custom/attribute_changed_callback_test/unsupported_on_polyfill: Fail # Polyfill does not support