languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-07-20 18:05:01 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

[vm] Update PRESUBMIT.py to also check for synchronized changes between runtime/tests/vm/{dart,dart_2}

Browse source 
Change-Id: Iaa026a312933e14fd3d56acb4d89257efd40b6b1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150221
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
This commit is contained in:
Martin Kustermann 2020-06-06 00:50:10 +00:00 committed by commit-bot@chromium.org
parent f1a4cc8778
commit 2c69fb1d53
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
PRESUBMIT.py
View file

@ -67,7 +67,10 @@ def _CheckNnbdTestSync(input_api, output_api):
a test, the test's counterpart (if it exists at all) should be in the CL
too.
"""
DIRS = ["co19", "corelib", "ffi", "language", "lib", "standalone"]
DIRS = [
"tests/co19", "tests/corelib", "tests/ffi", "tests/language",
"tests/lib", "tests/standalone", "runtime/tests/vm/dart"
]
files = [git_file.LocalPath() for git_file in input_api.AffectedTextFiles()]
unsynchronized = []
@ -75,8 +78,8 @@ def _CheckNnbdTestSync(input_api, output_api):
if file.endswith('.status'): continue
for dir in DIRS:
legacy_dir = "tests/{}_2/".format(dir)
nnbd_dir = "tests/{}/".format(dir)
legacy_dir = "{}_2/".format(dir)
nnbd_dir = "{}/".format(dir)
counterpart = None
if file.startswith(legacy_dir):