languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-04 16:44:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add some minimal presubmit checks to keep forked SDK tests in sync.

Browse source 
This only validates that if a test and its fork exist that the CL
touches both. There are lots of other cases we could imagine checking
like if you *add* a new test on one side, you should one on the other.
But those are likely to have a lot of false positives now while the
migration is happening and new NNBD tests are being written.

So for now, this just tries to check that tests that have been forked
at least don't diverge. It's a start.

Change-Id: Id6a9c39699a510da1a4a4702879210f94cd69c26
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131945
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
This commit is contained in:
Robert Nystrom 2020-01-16 18:50:27 +00:00 committed by commit-bot@chromium.org
parent b94a12b60b
commit 730a46093b
1 changed files with 46 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

46
PRESUBMIT.py
View file

@ -38,6 +38,51 @@ def _CheckNnbdSdkSync(input_api, output_api):
return []
def _CheckNnbdTestSync(input_api, output_api):
"""Make sure that any forked SDK tests are kept in sync. If a CL touches
a test, the test's counterpart (if it exists at all) should be in the CL
too.
"""
DIRS = ["co19", "corelib", "language", "lib", "standalone"]
files = [git_file.LocalPath() for git_file in input_api.AffectedTextFiles()]
unsynchronized = []
for file in files:
for dir in DIRS:
legacy_dir = "tests/{}_2/".format(dir)
nnbd_dir = "tests/{}/".format(dir)
counterpart = None
if file.startswith(legacy_dir):
counterpart = file.replace(legacy_dir, nnbd_dir)
elif file.startswith(nnbd_dir):
counterpart = file.replace(nnbd_dir, legacy_dir)
if counterpart:
# Changed one file with a potential counterpart. If it exists
# on disc, make sure it is also in the CL.
if counterpart not in files and os.path.exists(counterpart):
unsynchronized.append("- {} -> {}".format(
file, counterpart))
break
# TODO(rnystrom): Currently, we only warn if a test does exist in both
# places on disc but only one is touched by a CL. We don't warn for files
# that only exist on one side because the migration isn't complete and the
# CL may be migrating. Once the migration is complete, consider making
# these checks more rigorous.
if unsynchronized:
return [
output_api.PresubmitPromptWarning(
'Make sure to keep the forked legacy and NNBD tests in sync.\n'
'You may need to synchronize these files:\n' +
'\n'.join(unsynchronized))
]
return []
def _CheckFormat(input_api,
identification,
extension,
@ -271,6 +316,7 @@ def _CheckClangTidy(input_api, output_api):
def _CommonChecks(input_api, output_api):
results = []
results.extend(_CheckNnbdSdkSync(input_api, output_api))
results.extend(_CheckNnbdTestSync(input_api, output_api))
results.extend(_CheckValidHostsInDEPS(input_api, output_api))
results.extend(_CheckDartFormat(input_api, output_api))
results.extend(_CheckStatusFiles(input_api, output_api))