languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-07-20 18:05:01 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

[vm] Add runtime/.clang-tidy and run clang-tidy in parallel (via dart script)

Browse source 
Change-Id: I1ef69f0be521db2466d1e60663c75c177bc4b778
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115402
Reviewed-by: Samir Jindel <sjindel@google.com>
This commit is contained in:
Martin Kustermann 2019-09-04 20:33:50 +00:00
parent a931a457f0
commit c0e327ea85
2 changed files with 79 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
PRESUBMIT.py
View file

@ -236,20 +236,10 @@ def _CheckClangTidy(input_api, output_api):
return []
args = [
'./buildtools/linux-x64/clang/bin/clang-tidy',
'-checks=readability-implicit-bool-conversion',
'tools/sdks/dart-sdk/bin/dart',
'runtime/tools/run_clang_tidy.dart',
]
args.extend(files)
args.append('--')
args.extend([
'-I.',
'-Iruntime',
'-Iruntime/include',
'-Ithird_party/tcmalloc/gperftools/src ',
'-DTARGET_ARCH_X64',
'-DDEBUG',
'-DTARGET_OS_LINUX',
])
stdout = input_api.subprocess.check_output(args).strip()
if not stdout:
return []

77
runtime/tools/run_clang_tidy.dart Normal file
View file

@ -0,0 +1,77 @@
// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
import 'dart:async';
import 'dart:io';
import 'dart:math';
import 'package:pool/pool.dart';
const String clangTidy = './buildtools/linux-x64/clang/bin/clang-tidy';
List<String> compilerFlagsForFile(String filepath) {
final flags = <String>[
'-I.',
'-Iruntime',
'-Iruntime/include',
'-Ithird_party/tcmalloc/gperftools/src ',
'-DTARGET_ARCH_X64',
'-DDEBUG',
'-DTARGET_OS_LINUX',
];
if (filepath.endsWith("_test.cc")) {
flags.add('-DTESTING');
}
return flags;
}
Future<ProcessResult> runClangTidyOn(String filepath) async {
// The `runtime/.clang-tidy` file has the enabled checks in it.
final args = <String>['-quiet', filepath, '--']
..addAll(compilerFlagsForFile(filepath));
return await Process.run(clangTidy, args);
}
final pool = new Pool(max(1, Platform.numberOfProcessors ~/ 2));
// TODO(dartbug.com/38196): Ensure all VM sources are clang-tidy clean.
final Set<String> migratedFiles = Set<String>.from([
'runtime/vm/native_api_impl.cc',
]);
main(List<String> files) async {
bool isFirstFailure = true;
files = files.where((filepath) => migratedFiles.contains(filepath)).toList();
// Analyze the [files] in parallel.
await Future.wait(files.map((String filepath) async {
final processResult =
await pool.withResource(() => runClangTidyOn(filepath));
final int exitCode = processResult.exitCode;
final String stdout = processResult.stdout.trim();
final String stderr = processResult.stderr.trim();
if (exitCode != 0 || stdout.isNotEmpty) {
if (!isFirstFailure) {
print('');
print('--------------------------------------------------------------');
print('');
}
isFirstFailure = false;
}
if (exitCode != 0) {
print('exit-code: $exitCode');
print('stdout:');
print('${stdout}');
print('stderr:');
print('${stderr}');
} else if (stdout.isNotEmpty) {
// The actual lints go to stdout.
print(stdout);
}
}));
}