We don't rerun gclient sync after applying patches so changes to Dart
dependencies were not picked up.
Change-Id: I4360ddf7f906ab0552bd3ae8abbe9210a785845a
Reviewed-on: https://dart-review.googlesource.com/c/85282
Auto-Submit: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
This particular device sometimes fails with errors such as:
* "protocol error"
* "protocol error (no status)"
* "device not found"
Change-Id: Iced97ae8f5e891c43436a3d745004517dc59b42c
Reviewed-on: https://dart-review.googlesource.com/c/84905
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Change-Id: Id4031192d220ab82429cab895cf4121913231a54
Reviewed-on: https://dart-review.googlesource.com/c/84534
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
This includes both interpreted and compiled bytecode.
Change-Id: I6309ec4f0687f68caf6260cc57dacf94f027177d
Reviewed-on: https://dart-review.googlesource.com/c/84481
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Triggering on arm64 fails because some kitchen CIPD packages
are unavailable on arm64.
TBR=whesse@google.com
Change-Id: I26b05d000dde712ab1b1d55a33be1e4a02f22247
Reviewed-on: https://dart-review.googlesource.com/c/84424
Reviewed-by: Alexander Thomas <athom@google.com>
test.dart locates where the current branch branched off master and compares
the local testing results with the appropriate mainline builder results,
letting you know how the current change compares without the need for status
files.
Bug: https://github.com/dart-lang/sdk/issues/35086
Change-Id: Ib79479b867c5ac131302fea1bdf7effd0422a83a
Reviewed-on: https://dart-review.googlesource.com/c/83281
Reviewed-by: Alexander Thomas <athom@google.com>
Rationale:
To maximize CPU utilitization during fuzzing runs,
we now use a time-out on all the individual fuzz
testing runs (rather than repeat based). This way,
the "faster" tests will cover more ground, while
the "slower" straggler tests will not break the test
with unnecessary time-outs at cluster level.
Change-Id: I5f0f9646da3fbd8b361a7ea43444b1896a45b57f
Reviewed-on: https://dart-review.googlesource.com/c/84047
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Rationale:
Now that we are running on multiple shards, worker
timeouts are becoming a bit more frequent due to
(1) file copying overhead
(2) more stragglers due to law of larger numbers.
Change-Id: I36169c0b2033390b1c577f1dbafb1b34c3dd382d
Reviewed-on: https://dart-review.googlesource.com/c/84040
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
Change-Id: Ia20e682c542edba8b606276124e9f8fd78785680
Reviewed-on: https://dart-review.googlesource.com/c/83620
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Recipes pass output_dir to local shards as well but it points to a temp
directory that isn't accessible to users.
Change-Id: I0618abf78cf03957dd5cb8c9a10150bc4964684e
Reviewed-on: https://dart-review.googlesource.com/c/82985
Commit-Queue: Alexander Thomas <athom@google.com>
Auto-Submit: Alexander Thomas <athom@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
The approve_results program downloads the current results, the approved
results, and flakiness information for the specified bots. It presents
tables of the tests that have been fixed and the ones that have broken since
the last approval. Finally, it provides the option to approve the new
changes.
The approve_results program is part of the new workflow and only affects the
greenness of bots enrolled in it.
You can list the available bots by running:
dart tools/approve_results.dart -l
You can approve the results on a bot by running:
dart tools/approve_results.dart -b vm-kernel-linux-release-x64
Globs are supported, e.g. to approve all vm linux bots on ia32 and x64:
dart tools/approve_results.dart -b 'vm-*linux*{ia32,x64}*'
By default the tool is interactive and asks whether the changes should be
approved. Approving the results turns the bots green on the next commit.
It's assumed that bugs have been filed prior to approving the test changes.
The -y option approves the changes non-interactively while the -n option
does a try run and shows what needs to be approved.
This tool is meant to be used early and often to turn the bot green. Emails
are not set about additional failures until the regressions has been
approved.
Bug: https://github.com/dart-lang/sdk/issues/35000
Change-Id: I6479edaa76556aa5ef499509c04b92ae770d1727
Reviewed-on: https://dart-review.googlesource.com/c/82222
Reviewed-by: William Hesse <whesse@google.com>
Changed "compile-time warning" to "static warning"; eliminated spurious
space at the beginning of each normative paragraph; added index and
changed all `{\em ..}` containing defining occurrences of words and
phrases such that they are added to the index and marked with a
diamond in the margin (to make it easy to spot definitions).
Change-Id: I688561a24d2b9955f383d6c8db2c913353d41b4b
Reviewed-on: https://dart-review.googlesource.com/c/82501
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
* On Windows dump stacks from all collected dumps into the output so
that one would not need to download the dump to analyse it.
* Document crash dump archiving so that engineers know where to look
for dumps and how look at them.
Change-Id: Ibf53bb597c07702b3e051cf24bea8f6bfb1d5e8f
Reviewed-on: https://dart-review.googlesource.com/c/82066
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Auto-Submit: Vyacheslav Egorov <vegorov@google.com>
Change-Id: Ie7ff93cb552a0b2ae8e11078dd19358d199889d1
Reviewed-on: https://dart-review.googlesource.com/c/82040
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
These fields complicate how test.py is called and could just have well have
been put in the arguments list for simplicity. They were already used
inconsistently. The support can be removed from the recipe in a follow up
changelist in the infra repository.
Change-Id: Ib5c39d61d730bfcb719c1884d910bbd2f73b4fce
Reviewed-on: https://dart-review.googlesource.com/c/81403
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
In Dart we do `x.containsKey(k)` in Python we do `k in x`.
Change-Id: I60d0e95d0c4402c42a914270dbb1828f714f9d08
Reviewed-on: https://dart-review.googlesource.com/c/81760
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
* Catch and suppress errors so that core dump archiving can succeed even
if it can't delete some files.
* On Windows also archive PDB files that contains debugging information.
Change-Id: If1d7caa7c793a71bf8c0852c38098933e88fadba
Reviewed-on: https://dart-review.googlesource.com/c/81680
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
Auto-Submit: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
This fixes remaining tests that started failing after Crashpad integration
because they spawn Dart processes in different working directories and
those processes can't find Crashpad hanlder unless we use absolute path.
Revert "[gardening] Temporary mark two standalone_2 io tests as failing"
Change-Id: I2951396a02bbec56c30e7a40b0ba34722928f9a1
Reviewed-on: https://dart-review.googlesource.com/c/81600
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
Auto-Submit: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Our display test names (and filters) are given using forward slashes
while filenames on Windows use backwards slashes.
This meant that reproduction commands like
python tools/test.py -m release -n dartk-win-release-x64 standalone_2/io/regress_7679_test
did not work on Windows.
Change-Id: I707966b871d575ffc19911a27b0a7fc0eead2060
Reviewed-on: https://dart-review.googlesource.com/c/81415
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Auto-Submit: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Wheezy is not supported anymore (EOL May 2018) and these sysroots are
really outdated, which introduces build problems whenever we try to
use recent enough features and header files.
We are already using Jessie to build Dart SDK distributions and in some cases we use
Jessie to build binaries for testing (e.g. when building on ARM64).
This CL makes it uniform.
Change-Id: Id4d165a41aa37118f5e49edb2122d905219cd377
Reviewed-on: https://dart-review.googlesource.com/c/81409
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Exiting VM with abort() returns this exit code when building with Crashpad
integration.
Change-Id: I400e4436c358827f3bdb06cc78c489cc82e99b51
Reviewed-on: https://dart-review.googlesource.com/c/81410
Auto-Submit: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
https://crrev.com/c/1296514 will add --output_directory to non-shards as
well. BUILDBOT_BUILDERNAME is not set on shards and a more reliable
indication that this is a main bot that should gsutil upload core dumps.
Change-Id: Ic6cddc4937b8e83d2e15da4acd90c193e412773b
Reviewed-on: https://dart-review.googlesource.com/c/81362
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
dart binary would instantiate CrashpadClient if DART_CRASHPAD_HANDLER
and DART_CRASHPAD_CRASHES_DIR environment variables are set.
- DART_CRASHPAD_HANDLER should contain the path to the crashpad_handler
binary that would handle the crash and write minidump;
- DART_CRASHPAD_CRASHES_DIR should contain the path to the crashpad database
which would be used to store minidumps.
Rewrite --copy-crash-dumps support on windows to use Crashpad integration
instead of editing Windows registry.
Embedding crashpad required to roll a new zlib version because Crashpad
depends on the zlib. This version of zlib is buildable with its own
BUILD.gn so our custom BUILD.gn is removed.
Change-Id: I048aad16b234e1d750f0a24782b04e3b6e19703d
Reviewed-on: https://dart-review.googlesource.com/c/81007
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
The find_base_commit program locates the newest commit with a full set of
test results. This is a good base for local testing when comparing with the
results from the official bots, as all the needed results are there.
Change-Id: Ie06020ca98317b82f46589ad6dede37361acf744
Reviewed-on: https://dart-review.googlesource.com/c/81040
Reviewed-by: Alexander Thomas <athom@google.com>
* Channel detection only works for -dev, -stable and -try.
* This will allow adding flutter-analyze to the analyzer branch console.
TBR=whesse@google.com
Change-Id: I0a4036d290acdfba78ba138a0e87448f6da1e878
Reviewed-on: https://dart-review.googlesource.com/c/81101
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Change-Id: I04d741753c89191ccb8706d02330c8404efc1eb8
Reviewed-on: https://dart-review.googlesource.com/c/80581
Commit-Queue: Alexander Thomas <athom@google.com>
Auto-Submit: Alexander Thomas <athom@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
The step names of test.py invocations are currently used as directory names
in cloud storage. This unintentionally creates an unexpected subdirectory
where the top third_party/ directory is malformed because it doesn't have
the right contents.
Change-Id: I57e32ed917ba863e9bccf611f496e520b9a97310
Reviewed-on: https://dart-review.googlesource.com/c/80620
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
Change-Id: If0747db4bd02d31814b407970b11d16519329625
Reviewed-on: https://dart-review.googlesource.com/c/79661
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Change-Id: I8884227bde16c7d370135ba44336136834ef0bb0
Reviewed-on: https://dart-review.googlesource.com/c/80446
Auto-Submit: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
This is an attempt to solve io test flakiness on MacOS. The symptoms
include "connection refused", "broken pipe" error messages.
Change-Id: If6759f4ef9cd2c1b9bd083db9a469db43f12c4e0
Reviewed-on: https://dart-review.googlesource.com/c/80120
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
* Upload to Cloud Storage requires credentials not available to shards.
* Remove "SiteConfigBotoFile" buildbot hack.
* Remove obsolete Java utility method.
Change-Id: If03412a09644845d0f9467fa5fffc1cbec1cc216
Reviewed-on: https://dart-review.googlesource.com/c/79900
Auto-Submit: Alexander Thomas <athom@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Change-Id: I19229506a1f8eb3c13dff84794b9bba53cc5841e
Reviewed-on: https://dart-review.googlesource.com/c/79562
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
This deletes:
tests/co19
tests/corelib
tests/html
tests/isolate
tests/language
tests/lib
It does not delete tests/standalone because apparently there are tests
in there that are not in standalone_2. (I assume they were added after
the test migration. I don't know why they were added there.)
I have tried to remove references to the old tests from various scripts
and tools but may have missed some. (As you can imagine, grepping for
"lib" does not have the best signal-to-noise ratio.)
"It was a pleasure to burn. It was a special pleasure to see things
eaten, to see things blackened and changed. With the brass nozzle in his
fists, with this great python spitting its venomous kerosene upon the
world, the blood pounded in his head, and his hands were the hands of
some amazing conductor playing all the symphonies of blazing and burning
to bring down the tatters and charcoal ruins of history."
- Ray Bradbury, Fahrenheit 451
Change-Id: If3db4a50e7a5ee25aff8058b1483e2ce8e68424e
Reviewed-on: https://dart-review.googlesource.com/c/75420
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Change-Id: I931695878cdcd9f014b1b751bbe52cfc2d524bb8
Reviewed-on: https://dart-review.googlesource.com/c/79262
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Also, enable dropping ASTs from kernel files when testing in dartkb mode.
Change-Id: Iec82f1b76e3b8a9eb692de325d7645d8f271e03e
Reviewed-on: https://dart-review.googlesource.com/c/79087
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
This reverts commit 0aa99cca99.
Also fixes issue writing newline-terminated json records to file.
Change-Id: I568442149f532c4164610b6694fa95bc4f6e97e4
Reviewed-on: https://dart-review.googlesource.com/c/79205
Reviewed-by: Jonas Termansen <sortie@google.com>
Change-Id: Ic583bae50c78b5b1cd6e3a0a9ec144178dc4be6b
Reviewed-on: https://dart-review.googlesource.com/c/79001
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Make core_pattern checks non-fatal for now because underlying issues with
bots are not yet fixed.
We need core-dumps from debug kernel bots to look into some pthread flakes.
Bug: https://github.com/dart-lang/sdk/issues/31979
Change-Id: I38c79013cb2ed5a82ce10c909ff729f73cc34536
Reviewed-on: https://dart-review.googlesource.com/c/37320
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Change-Id: Idf85bf49e0ddd47640719eb65044f0b6527f9d9c
Reviewed-on: https://dart-review.googlesource.com/c/78525
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Rationale:
More coverage is better!
Change-Id: Ic04f4caf7d02e1db9398f3d51ae44f6b51d6542d
Reviewed-on: https://dart-review.googlesource.com/c/78862
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
Change-Id: Ibb492283c2b53762cb4f74da52c3f005cc282d85
Reviewed-on: https://dart-review.googlesource.com/c/78745
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Change-Id: I48817c4e6de58b418bd47188e878fd7f468ade61
Reviewed-on: https://dart-review.googlesource.com/c/78480
Commit-Queue: Peter von der Ahé <ahe@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Rationale:
With 8 isolates per machine, this gives an even
8 x 125 = 1000 tests per machine on the cluster
Change-Id: I06e21f271ec5452c1d5559666b3f0f1eaea439dd
Reviewed-on: https://dart-review.googlesource.com/c/78620
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
* co19_2 tests enabled for vm-kernel CQ builders.
Change-Id: I5ccc27d1110c22960e550b060a7e140bc1ac68b1
Reviewed-on: https://dart-review.googlesource.com/c/76820
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
* Remove all obsolete builders (only the try jobs used the test matrix).
* Add all missing Dart 2 builders.
Change-Id: I5c97e34928beb9023d87aaa638f759af16a7ccc4
Reviewed-on: https://dart-review.googlesource.com/c/77881
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
runtime_kernel is now the same as just runtime.
Confirm the gen_snapshot build target continues to work.
Change-Id: Ia282d7ba63c53ae8b35dad947d3dbbb671309e26
Reviewed-on: https://dart-review.googlesource.com/c/77801
Reviewed-by: Siva Annamalai <asiva@google.com>
- Remove all code that generates the corelib and dart:io library sources into C++ arrays and link them into dart_bootstrap
- Remove the executable dart_bootstrap and all uses of it
- Remove bootstrap_nolib.cc and builtin_nocore.cc
- Remove the Dart 1 code in core lib bootstrap path
Change-Id: Ifd33496204285a08b42fe09e39428e7a92b416b6
Reviewed-on: https://dart-review.googlesource.com/c/77241
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Change-Id: I3a97e340e83ddf1df4438262f176392540ecbbc2
Reviewed-on: https://dart-review.googlesource.com/76745
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
There is a race with downloading the prebuilt Dart SDK from CIPD
introduced by:
647e1e79eb
If the prebuilt Dart SDK isn't there, then generate_buildfiles.py will
fail. Instead check whether generate_buildfiles.py should be run
right before we try to build.
Change-Id: I1e25e5280075f9d1c7d96877602617ddfb40291e
Reviewed-on: https://dart-review.googlesource.com/77160
Reviewed-by: Jonas Termansen <sortie@google.com>
`dartdevc --kernel` is now equivalent to the old `dartdevk` command.
This will make migration easier, as it's now just a flag to enable
CFE/Kernel. `dartdevk` is now deprecated, but it can be supported for
a while as it just calls `dartdevc --kernel`.
Change-Id: Ib8d09f74556740a3af11c753f80cd87bd4a09044
Reviewed-on: https://dart-review.googlesource.com/76566
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Jenny Messerly <jmesserly@google.com>
* Remove obsolete vm-kernel-legacy and analyzer-cfe builders.
Change-Id: I6b316359b1a2c5ce2adcf276578a9b9be5db5c15
Reviewed-on: https://dart-review.googlesource.com/76480
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
- option --no-preview-dart-2 will now result in an error
- change aot-assembly build rule to generate AOT snapshot using Dart 2
- generate coresnapshot using Dart 2 (this snapshot is not used yet, next CL which switch the isolate create code to use this snapshot)
- by pass all Dart1 test runs in the status file
- change the default compiler setting in test.py to use dartk
- have test.py not pick up any configuration for --no-preview-dart-2
Change-Id: Ia136943ebfd0fed0c52683b330745b3e2c7a7ce6
Reviewed-on: https://dart-review.googlesource.com/75820
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
tools/bots/compare_results.dart compares the previous and current test
results in the results.json format and lists the differences, taking the
flakiness data into account.
tools/bots/update_flakiness.dart reads new result.json files and updates the
flakiness data in the flaky.json format file. The updated flakiness data
contains the list of tests that were already known to be flaky, plus any
new tests with multiple different outcomes in the provided results.json
files.
For instance, after running the tests, to find the list of tests that
changed result and needs to be deflaked, excluding tests that are already
known to be flaky:
compare_results.dart \
--flakiness-data flaky.json
--changed \
--passing \
--failing \
previous.json results.json
After the tests needing deflakinghas been run again, the flakiness data can
be updated:
update_flakiness.dart -i flaky.json -o flaky.json results.json more.json
Finally a human readable report can explain what happened, exiting 1 if any
tests started failing in a non-flaky manner:
compare_results.dart \
--flakiness-data flaky.json \
--judgement \
--human \
--verbose \
--changed \
--failing \
--flaky \
previous.json results.json
Bug: https://github.com/dart-lang/sdk/issues/34517
Bug: https://github.com/dart-lang/sdk/issues/34518
Change-Id: I156a8a49b8df09c0aebcb77376b69d365d0aa2ac
Reviewed-on: https://dart-review.googlesource.com/75540
Reviewed-by: William Hesse <whesse@google.com>
This change modifies the test matrix to run with --compiler=dartkb with
--enable_interpreter and --use_bytecode_compiler in sequence.
Change-Id: Ie1be3ffdd97e65ceafb8838fd1b159746ba4c2cb
Reviewed-on: https://dart-review.googlesource.com/75206
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Every 5 minutes, test.py prints a status update.
Change-Id: Id11d9e4a01a94dc8515a7e2d1df4f3d417998cc1
Reviewed-on: https://dart-review.googlesource.com/75262
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
The placeholder executable is replaced by a shell script that invokes
pkg/analyzer_fe_comparison (in a similar way to how
sdk/bin/dartanalyzer invokes pkg/analyzer_cli). This required some
rewriting of pkg/analyzer_fe_comparison to support analysis of a
single test case (as opposed to analysis of a package, which is what
it did before).
It's now possible to run the comparison tool over the test suite in
language_2. There are many failures, which I'll begin addressing in
follow-up CLs.
Change-Id: I52d8f3b53064e8e29028571d416f2573c6cba35d
Reviewed-on: https://dart-review.googlesource.com/74820
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
The "vm" test suite is cauing the kernel bytecode compiler to
OOM on the bot, so this CL removes it from the test matrix for
dartkb. This CL also protects against non-utf8 data coming in
on the error message pipe during process spawning.
Change-Id: Iab110a49a49ea12d21037719716a228776343602
Reviewed-on: https://dart-review.googlesource.com/74490
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
This allows dartdevk to be used in the context of an existing build
system based on Analyzer summary files. This will ease migration of
existing dartdevc users over to dartdevk.
Change-Id: I8413f906e384f3f33c98e450adc0860f6fa7bc53
Reviewed-on: https://dart-review.googlesource.com/65641
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Jenny Messerly <jmesserly@google.com>