languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-07-20 18:05:01 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

[infra] Upload core dumps if BUILDBOT_BUILDERNAME is set

Browse source 
Recipes pass output_dir to local shards as well but it points to a temp
directory that isn't accessible to users.

Change-Id: I0618abf78cf03957dd5cb8c9a10150bc4964684e
Reviewed-on: https://dart-review.googlesource.com/c/82985
Commit-Queue: Alexander Thomas <athom@google.com>
Auto-Submit: Alexander Thomas <athom@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
This commit is contained in:
Alexander Thomas 2018-11-06 11:56:11 +00:00 committed by commit-bot@chromium.org
parent 0fd4a51e2c
commit 54a3e11d5b
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
tools/utils.py
View file

@ -860,7 +860,7 @@ class BaseCoreDumpArchiver(object):
files.add(core)
else:
missing.append(crash)
if self._output_directory is not None:
if self._output_directory is not None and self._is_shard():
print (
"INFO: Copying collected dumps and binaries into output directory\n"
"INFO: They will be uploaded to isolate server. Look for \"isolated"
@ -877,6 +877,10 @@ class BaseCoreDumpArchiver(object):
if missing:
self._report_missing_crashes(missing, throw=True)
# todo(athom): move the logic to decide where to copy core dumps into the recipes.
def _is_shard(self):
return 'BUILDBOT_BUILDERNAME' not in os.environ
def _report_missing_crashes(self, missing, throw=True):
missing_as_string = ', '.join([str(c) for c in missing])
other_files = list(glob.glob(os.path.join(self._search_dir, '*')))