languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-06 16:00:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

[infra] Fix third_party/pkg_tested step having slash in name.

Browse source 
The step names of test.py invocations are currently used as directory names
in cloud storage. This unintentionally creates an unexpected subdirectory
where the top third_party/ directory is malformed because it doesn't have
the right contents.

Change-Id: I57e32ed917ba863e9bccf611f496e520b9a97310
Reviewed-on: https://dart-review.googlesource.com/c/80620
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
This commit is contained in:
Jonas Termansen 2018-10-18 12:38:39 +00:00 committed by commit-bot@chromium.org
parent 1061c83779
commit d04a36b4ab
3 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tools/bots/test_matrix.json
View file

@ -1619,7 +1619,7 @@
"tests": ["pkg"]
},
{
"name": "third_party/pkg_tested unit tests",
"name": "third_party pkg_tested unit tests",
"arguments": [
"-nunittest-asserts-${system}"],
"tests": ["pkg_tested"]

6
tools/gardening/lib/src/buildbot_data.dart
View file

@ -746,19 +746,19 @@ const List<BuildGroup> buildGroups = const <BuildGroup>[
'pkg-mac10.11-release-be',
], testSteps: const <String>[
'package unit tests',
'third_party/pkg_tested unit tests',
'third_party pkg_tested unit tests',
]),
const BuildSubgroup(shardNames: const <String>[
'pkg-linux-release-be',
], testSteps: const <String>[
'package unit tests',
'third_party/pkg_tested unit tests',
'third_party pkg_tested unit tests',
]),
const BuildSubgroup(shardNames: const <String>[
'pkg-win7-release-be',
], testSteps: const <String>[
'package unit tests',
'third_party/pkg_tested unit tests',
'third_party pkg_tested unit tests',
]),
],
),

6
tools/gardening/test/buildbot_data_test.dart
View file

@ -44,11 +44,11 @@ main(List<String> args) async {
// TODO(johnniwinther): Find out why these steps cannot be read.
Expect.setEquals([
'/builders/pkg-mac10.11-release-be/builds/-1/'
'steps/third_party/pkg_tested unit tests',
'steps/third_party pkg_tested unit tests',
'/builders/pkg-linux-release-be/builds/-1/steps/'
'third_party/pkg_tested unit tests',
'third_party pkg_tested unit tests',
'/builders/pkg-win7-release-be/builds/-1/steps/'
'third_party/pkg_tested unit tests',
'third_party pkg_tested unit tests',
], failingUris,
"Unexpected failing buildbot uris:\n ${failingUris.join('\n ')}");