languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-15 21:50:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

[testing] Fix code in utils.py to use Python not Dart

Browse source 
In Dart we do `x.containsKey(k)` in Python we do `k in x`.

Change-Id: I60d0e95d0c4402c42a914270dbb1828f714f9d08
Reviewed-on: https://dart-review.googlesource.com/c/81760
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
This commit is contained in:
Vyacheslav Egorov 2018-10-29 10:34:24 +00:00 committed by commit-bot@chromium.org
parent db4271378f
commit 64635263ff
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
tools/utils.py
View file

@ -860,12 +860,10 @@ class BaseCoreDumpArchiver(object):
files.add(core)
else:
missing.append(crash)
if (self._output_directory is None
or os.environ.containsKey('BUILDBOT_BUILDERNAME')):
self._upload(files)
else:
# This is a sharded test run: copy the dump to the output_directory
if self._output_directory is not None:
self._copy(files)
else:
self._upload(files)
if missing:
self._report_missing_crashes(missing, throw=True)