languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 09:01:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix doc comment in HttpRequest.getString and other tweaks

Browse source 
Bug: https://github.com/dart-lang/sdk/issues/21578
Change-Id: I9ec333319922f27a216c1804d889198baf7e579b
Reviewed-on: https://dart-review.googlesource.com/c/82789
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
This commit is contained in:
Sam Rawlins 2018-11-07 23:31:14 +00:00 committed by commit-bot@chromium.org
parent 48c7af8f8b
commit 1a5f5e4caf
3 changed files with 12 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
sdk/lib/html/dart2js/html_dart2js.dart
View file

@ -17096,9 +17096,6 @@ class HttpRequest extends HttpRequestEventTarget {
/**
* Creates a GET request for the specified [url].
*
* The server response must be a `text/` mime type for this request to
* succeed.
*
* This is similar to [request] but specialized for HTTP GET requests which
* return text content.
*
@ -17109,7 +17106,7 @@ class HttpRequest extends HttpRequestEventTarget {
* var name = Uri.encodeQueryComponent('John');
* var id = Uri.encodeQueryComponent('42');
* HttpRequest.getString('users.json?name=$name&id=$id')
* .then((HttpRequest resp) {
* .then((String resp) {
* // Do something with the response.
* });
*
@ -17127,8 +17124,8 @@ class HttpRequest extends HttpRequestEventTarget {
/**
* Makes a server POST request with the specified data encoded as form data.
*
* This is roughly the POST equivalent of getString. This method is similar
* to sending a FormData object with broader browser support but limited to
* This is roughly the POST equivalent of [getString]. This method is similar
* to sending a [FormData] object with broader browser support but limited to
* String values.
*
* If [data] is supplied, the key/value pairs are URI encoded with
@ -17425,11 +17422,11 @@ class HttpRequest extends HttpRequestEventTarget {
* Specify the desired `url`, and `method` to use in making the request.
*
* By default the request is done asyncronously, with no user or password
* authentication information. If `async` is false, the request will be send
* authentication information. If `async` is false, the request will be sent
* synchronously.
*
* Calling `open` again on a currently active request is equivalent to
* calling `abort`.
* calling [abort].
*
* Note: Most simple HTTP requests can be accomplished using the [getString],
* [request], [requestCrossOrigin], or [postFormData] methods. Use of this
@ -17659,7 +17656,7 @@ class HttpRequest extends HttpRequestEventTarget {
* response.
*
* This value must be set before the request has been sent. See also the list
* of [IANA Official MIME types](https://www.iana.org/assignments/media-types/media-types.xhtml)
* of [IANA Official MIME types](https://www.iana.org/assignments/media-types/media-types.xhtml).
*/
@SupportedBrowser(SupportedBrowser.CHROME)
@SupportedBrowser(SupportedBrowser.FIREFOX)

2
tools/dom/docs/docs.json
View file

@ -4212,7 +4212,7 @@
" * response.",
" *",
" * This value must be set before the request has been sent. See also the list",
" * of [IANA Official MIME types](https://www.iana.org/assignments/media-types/media-types.xhtml)",
" * of [IANA Official MIME types](https://www.iana.org/assignments/media-types/media-types.xhtml).",
" */"
],
"readyState": [

13
tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate
View file

@ -56,9 +56,6 @@ $(ANNOTATIONS)$(NATIVESPEC)$(CLASS_MODIFIERS)class $CLASSNAME$EXTENDS$IMPLEMENTS
/**
* Creates a GET request for the specified [url].
*
* The server response must be a `text/` mime type for this request to
* succeed.
*
* This is similar to [request] but specialized for HTTP GET requests which
* return text content.
*
@ -69,7 +66,7 @@ $(ANNOTATIONS)$(NATIVESPEC)$(CLASS_MODIFIERS)class $CLASSNAME$EXTENDS$IMPLEMENTS
* var name = Uri.encodeQueryComponent('John');
* var id = Uri.encodeQueryComponent('42');
* HttpRequest.getString('users.json?name=$name&id=$id')
* .then((HttpRequest resp) {
* .then((String resp) {
* // Do something with the response.
* });
*
@ -86,8 +83,8 @@ $(ANNOTATIONS)$(NATIVESPEC)$(CLASS_MODIFIERS)class $CLASSNAME$EXTENDS$IMPLEMENTS
/**
* Makes a server POST request with the specified data encoded as form data.
*
* This is roughly the POST equivalent of getString. This method is similar
* to sending a FormData object with broader browser support but limited to
* This is roughly the POST equivalent of [getString]. This method is similar
* to sending a [FormData] object with broader browser support but limited to
* String values.
*
* If [data] is supplied, the key/value pairs are URI encoded with
@ -369,11 +366,11 @@ $(ANNOTATIONS)$(NATIVESPEC)$(CLASS_MODIFIERS)class $CLASSNAME$EXTENDS$IMPLEMENTS
* Specify the desired `url`, and `method` to use in making the request.
*
* By default the request is done asyncronously, with no user or password
* authentication information. If `async` is false, the request will be send
* authentication information. If `async` is false, the request will be sent
* synchronously.
*
* Calling `open` again on a currently active request is equivalent to
* calling `abort`.
* calling [abort].
*
* Note: Most simple HTTP requests can be accomplished using the [getString],
* [request], [requestCrossOrigin], or [postFormData] methods. Use of this