Brian Wilkerson
724ac40b8d
Improve error messages and add many corrections
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2426583003 .
2016-10-17 10:40:43 -07:00
Zachary Anderson
c8970d0524
DBC: Fix CheckClass bug. Add some intrinsics
...
Flutter layout benchmark 8.5k us -> 6k us.
R=fschneider@google.com
Review URL: https://codereview.chromium.org/2418073002 .
2016-10-17 10:20:56 -07:00
Brian Wilkerson
cbd7a2908e
Fixes for tests on windows
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2420413004 .
2016-10-17 09:39:25 -07:00
Florian Loitsch
8fbd651c49
Emphasize that durations are context independent.
...
Fixes #27597
BUG= http://dartbug.com/27597
R=lrn@google.com
Review URL: https://codereview.chromium.org/2423993002 .
2016-10-17 14:51:00 +02:00
William Hesse
bb91445e7e
Update CHANGELOG.md with release dates and patch releases.
...
BUG=
R=lrn@google.com
Review URL: https://codereview.chromium.org/2423973002 .
2016-10-17 14:04:33 +02:00
Johnni Winther
74b74a13f7
Decouple TypeMask from ClassElement
...
- by typing FlatTypeMask.base with Entity
- moving needsNoSuchMethodHandling to ClosedWorld
- and testing needsNoSuchMethodHandling
R=sigmund@google.com
Review URL: https://codereview.chromium.org/2420073002 .
2016-10-17 09:47:20 +02:00
Zachary Anderson
c1b1151f54
GN: Fix builder test script
...
Review URL: https://codereview.chromium.org/2423783002 .
2016-10-16 15:18:54 -07:00
Vyacheslav Egorov
caa0167457
Don't use in-class initialization of non-static data members. It's a C++11 extension.
...
TBR=asiva@google.com
Review URL: https://codereview.chromium.org/2420323002 .
2016-10-15 23:02:49 +02:00
Vyacheslav Egorov
f67ce21068
VM support for running Kernel binaries.
...
BUG=
R=asiva@google.com , fschneider@google.com
Review URL: https://codereview.chromium.org/2411823003 .
2016-10-15 22:48:46 +02:00
Brian Wilkerson
4f6f05273e
Add more summary support to ContextBuilder
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2416243003 .
2016-10-15 08:40:04 -07:00
Stephen Adams
790b9d9cb1
Enable GVN on HForeignNew
...
R=sigmund@google.com
Review URL: https://codereview.chromium.org/2422003002 .
2016-10-14 17:34:07 -07:00
Sigmund Cherem
997581ccec
Fix custom elements in startup emitter
...
R=sra@google.com
Review URL: https://codereview.chromium.org/2424553002 .
2016-10-14 16:58:47 -07:00
Ryan Macnak
572eb0ce7a
Apparently co19 tests have their own separate annotation parsing.
...
Review URL: https://codereview.chromium.org/2419613007 .
2016-10-14 16:43:20 -07:00
Ryan Macnak
656964107b
Update AOT Android harness for single-file app snapshots.
...
R=fschneider@google.com
Review URL: https://codereview.chromium.org/2419183002 .
2016-10-14 16:23:19 -07:00
Ryan Macnak
fe04737a77
Add test directive to include other files used by a test in its compiled output directory.
...
Fixes #27591
R=fschneider@google.com
Review URL: https://codereview.chromium.org/2423593002 .
2016-10-14 16:11:25 -07:00
Regis Crelier
0ac91fab5c
Minor cleanup: use handle when setting instructions in code object.
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2416963009 .
2016-10-14 16:06:59 -07:00
John McCutchan
a43d37be81
Fix reload_sources_test flake
...
BUG=
Review URL: https://codereview.chromium.org/2415183005 .
2016-10-14 15:33:55 -07:00
Sigmund Cherem
ee42a0a0aa
Add js-interop support to the fast-startup emitter
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org/2420173002 .
2016-10-14 14:22:11 -07:00
Bob Nystrom
60a966605d
Remove uses of unittest in the HTML tests where possible.
...
This finishes going through the dev_compiler HTML tests and switches
out unittest for minitest wherever possible.
In the process, it gets another 10 tests strong mode clean, and gets
several more passing, and more not skipped. With this CL, we're running
another 50 more HTML tests (though some are expected to fail, mostly
because of #27578 ).
R=jacobr@google.com , vsm@google.com
Review URL: https://codereview.chromium.org/2419863002 .
2016-10-14 13:44:19 -07:00
Vijay Menon
72e3d13db2
Add ddc resources to the sdk build
...
This installs DDC's dart_sdk.js, etc., under:
dart-sdk/lib/_internal/dev_compiler/
Fixes #27001
R=jakemac@google.com
Review URL: https://codereview.chromium.org/2416783005 .
2016-10-14 12:34:03 -07:00
Brian Wilkerson
4942f5304a
Guard against a hypothetical null pointer dereference
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2421473007 .
2016-10-14 12:31:11 -07:00
Vijay Menon
852ef37f71
Some mirrors fixes
...
R=leafp@google.com
Review URL: https://codereview.chromium.org/2415053004 .
2016-10-14 12:19:24 -07:00
Ryan Macnak
0d99435f0c
Mark tests failing with app snapshots that expect a resource relative to script.
...
Issue #27591
R=fschneider@google.com
Review URL: https://codereview.chromium.org/2418193002 .
2016-10-14 11:10:19 -07:00
Florian Schneider
a0380ffaf6
Fix assertion failure with deferred prefixes.
...
When running with --load-deferred-eagerly, we don't need to collect
functions for invalidation, but instead insert runtime checks if
the prefix if loadLibrary was called loaded or not.
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2415743004 .
2016-10-14 10:20:46 -07:00
Ryan Macnak
74e6376b5c
Fix unoptimized code calling a disabled code when --verify-on-transition is enabled.
...
Unoptimized code has a static call to optimized code.
Optimized code prologue goes to the OptimizeInvokedFunction runtime.
Callee schedule for background compilation and current code set the return entries return value.
Verify-on-transition triggers a safepoint, wherein the background compiler disables the old optimized code.
The OptimizedInvokedFunction stub calls through the disabled code.
FixCallersTarget see an unoptimized caller. BOOM
Similar problem without --verify-on-transition, except the safepoint comes from BackgroundCompiler::CompileOptimized.
Fixes #26927 .
R=fschneider@google.com
Review URL: https://codereview.chromium.org/2418673002 .
2016-10-14 10:01:42 -07:00
Ryan Macnak
3d00ecdc8f
Reapply "Use a single file for app snapshots."
...
- Don't read script to check for an app snapshot if it is a pipe. Fixes loading source from a pipe.
- Fix windows and fushsia builds.
R=asiva@google.com
Review URL: https://codereview.chromium.org/2416973003 .
2016-10-14 09:57:54 -07:00
Brian Wilkerson
3155b1e08c
Remove unused method and field from DartSdkManager
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2415413003 .
2016-10-14 09:53:44 -07:00
Florian Loitsch
136e476c87
Check for the type of the the spawned function.
...
In general we avoid explicit type-checks, but in this case the error would be only detected in the new isolate making error handling much harder.
Fixes #27185
BUG= http://dartbug.com/27185 .
R=lrn@google.com
Review URL: https://codereview.chromium.org/2414173003 .
2016-10-14 13:27:11 +02:00
Lasse R.H. Nielsen
523da59d56
Add reference to invalid typedef so dart2js will detect it.
...
R=floitsch@google.com
Review URL: https://codereview.chromium.org/2417223002 .
2016-10-14 12:56:40 +02:00
Lasse R.H. Nielsen
ac76d3eb9f
Update CHANGELOG.md for commit efb9a12811
(allow =
for named parameters)
...
(See efb9a12811
)
R=floitsch@google.com
Review URL: https://codereview.chromium.org/2419893004 .
2016-10-14 11:34:53 +02:00
Lasse R.H. Nielsen
efb9a12811
Add =
as default-value separator for named parameters.
...
Fixes issue #27559 .
BUG= http://dartbug.com/27559
R=asiva@google.com , eernst@google.com , floitsch@google.com , sigmund@google.com
Review URL: https://codereview.chromium.org/2411633002 .
2016-10-14 11:25:25 +02:00
Zachary Anderson
4118680345
[windows] Revert virtual memory changes
...
Revert changes to virtual_memory_win.cc in case they are the cause of
the OOM failures on the debug windows x64 bot.
Review URL: https://codereview.chromium.org/2420853002 .
2016-10-13 22:02:12 -07:00
Stephen Adams
476ffbda5e
Revert "Build CFG for various JS() foreign methods"
...
TBR=het@google.com
BUG=
Review URL: https://codereview.chromium.org/2411793007 .
2016-10-13 19:02:41 -07:00
Stephen Adams
a897bc3832
Build CFG for various JS() foreign methods
...
BUG=
R=het@google.com
Review URL: https://codereview.chromium.org/2404123002 .
2016-10-13 17:11:35 -07:00
Ryan Macnak
6839a23240
Revert "Use a single file for app snapshots."
...
This reverts commit 4f8b16df3b
.
Review URL: https://codereview.chromium.org/2410303008 .
2016-10-13 15:29:23 -07:00
Konstantin Shcheglov
4c065c8443
Allow new public names in patches for the dart:_internal library.
...
R=paulberry@google.com , brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/2413403002 .
2016-10-13 14:52:22 -07:00
Florian Schneider
1ebde18da6
Fix and dedup entries in language.status.
...
Correct mistakes from my previous CL and simplifications.
TBR=rmacnak@google.com ,
BUG=
Review URL: https://codereview.chromium.org/2412323004 .
2016-10-13 14:49:27 -07:00
Ryan Macnak
4f8b16df3b
Use a single file for app snapshots.
...
For blobs, put all four pieces into a single file with a header describing their offsets.
For dynamic libraries, move the vm isolate and isolate pieces into the dynamic library as additional read-only sections.
Automatically detect if the script argument is an app snapshot and initialize the VM appropriately, similar to automatic detection of script snapshots.
R=asiva@google.com
Review URL: https://codereview.chromium.org/2405393002 .
2016-10-13 14:33:56 -07:00
Konstantin Shcheglov
f63a9d1219
Add support for patching parts.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org/2414123003 .
2016-10-13 14:27:22 -07:00
Bob Nystrom
ae5a566f98
Move minitest.dart into the expect package.
...
R=vsm@google.com
Review URL: https://codereview.chromium.org/2416853003 .
2016-10-13 14:15:21 -07:00
Konstantin Shcheglov
2b40c57781
Add support for patching fields.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org/2416073002 .
2016-10-13 14:04:58 -07:00
Florian Schneider
2022348b11
Fix wrong initialization of is_loaded in LibraryPrefix.
...
My previous CL did not check if the prefix is deferred or not
when deserializing it from the snapshot.
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2413113004 .
2016-10-13 13:51:02 -07:00
Florian Schneider
701b91eb31
VM: Save one bool when serializing library prefixes.
...
When loading a snapshot all library prefixes should be considered not
loaded. This makes code running from a JIT snapshot throw the correct
error when using a deferred prefix before it is loaded.
Also, update test status and avoid skipping tests.
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2416963003 .
2016-10-13 13:36:19 -07:00
Konstantin Shcheglov
318e842389
Extract appending nodes to the list into a helper method.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org/2417053002 .
2016-10-13 13:29:36 -07:00
Paul Berry
809c80fa49
Fix summarization of closures in toplevel variable declarations in part files.
...
We were forgetting to include the unitNum, so it was defaulting to zero,
which worked for non-part files but not for part files.
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2416863003 .
2016-10-13 13:29:06 -07:00
Ryan Macnak
1ee954029d
Attempt to fix InitialRSS for Golem.
...
R=zra@google.com
Review URL: https://codereview.chromium.org/2421623002 .
2016-10-13 13:11:41 -07:00
Konstantin Shcheglov
452e180dbc
Add support for patching constructors.
...
R=paulberry@google.com , brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/2417933002 .
2016-10-13 13:03:26 -07:00
Ryan Macnak
d8cc8644b1
Switchable call scheduling.
...
R=fschneider@google.com
Review URL: https://codereview.chromium.org/2404973002 .
2016-10-13 12:44:25 -07:00
Zach Anderson
6f7696dfc9
[windows] fix ~VirtualMemory()
...
R=asiva@google.com
Review URL: https://codereview.chromium.org/2414133002 .
2016-10-13 12:41:26 -07:00
Siva Annamalai
d8276c4ef9
Skip env_test for dartium as it uses command line options which are not supported for dartium.
...
R=terry@google.com
Review URL: https://codereview.chromium.org/2413093003 .
2016-10-13 12:40:40 -07:00