languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 08:24:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix wrong initialization of is_loaded in LibraryPrefix.

Browse source 
My previous CL did not check if the prefix is deferred or not
when deserializing it from the snapshot.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2413113004 .
This commit is contained in:
Florian Schneider 2016-10-13 13:51:02 -07:00
parent 701b91eb31
commit 2022348b11
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
runtime/vm/clustered_snapshot.cc
View file

@ -2824,7 +2824,7 @@ class LibraryPrefixDeserializationCluster : public DeserializationCluster {
}
prefix->ptr()->num_imports_ = d->Read<uint16_t>();
prefix->ptr()->is_deferred_load_ = d->Read<bool>();
prefix->ptr()->is_loaded_ = false;
prefix->ptr()->is_loaded_ = !prefix->ptr()->is_deferred_load_;
}
}
};

3
runtime/vm/raw_object_snapshot.cc
View file

@ -1189,7 +1189,8 @@ RawLibraryPrefix* LibraryPrefix::ReadFrom(SnapshotReader* reader,
reader->Read<int16_t>());
prefix.StoreNonPointer(&prefix.raw_ptr()->is_deferred_load_,
reader->Read<bool>());
prefix.StoreNonPointer(&prefix.raw_ptr()->is_loaded_, false);
prefix.StoreNonPointer(&prefix.raw_ptr()->is_loaded_,
!prefix.raw_ptr()->is_deferred_load_);
// Set all the object fields.
READ_OBJECT_FIELDS(prefix,