languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 08:24:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix custom elements in startup emitter

Browse source 
R=sra@google.com

Review URL: https://codereview.chromium.org/2424553002 .
This commit is contained in:
Sigmund Cherem 2016-10-14 16:58:47 -07:00
parent 572eb0ce7a
commit 997581ccec
3 changed files with 18 additions and 64 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart
View file

@ -1333,7 +1333,7 @@ class FragmentEmitter {
Map<String, js.Expression> interceptorsByTag = <String, js.Expression>{};
Map<String, js.Expression> leafTags = <String, js.Expression>{};
js.Statement subclassAssignment = new js.EmptyStatement();
List<js.Statement> subclassAssignments = <js.Statement>[];
for (Library library in fragment.libraries) {
for (Class cls in library.classes) {
@ -1350,15 +1350,15 @@ class FragmentEmitter {
}
if (cls.nativeExtensions != null) {
List<Class> subclasses = cls.nativeExtensions;
js.Expression value = js.string(cls.nativeNonLeafTags[0]);
js.Expression base = js.string(cls.nativeNonLeafTags[0]);
for (Class subclass in subclasses) {
value = js.js('#.# = #', [
subclassAssignments.add(js.js.statement('#.# = #;', [
classReference(subclass),
NATIVE_SUPERCLASS_TAG_NAME,
js.string(cls.nativeNonLeafTags[0])
]);
base
]));
}
subclassAssignment = new js.ExpressionStatement(value);
}
}
}
@ -1367,7 +1367,7 @@ class FragmentEmitter {
js.objectLiteral(interceptorsByTag)));
statements.add(
js.js.statement("setOrUpdateLeafTags(#);", js.objectLiteral(leafTags)));
statements.add(subclassAssignment);
statements.addAll(subclassAssignments);
return new js.Block(statements);
}

52
tests/co19/co19-dart2js.status
View file

@ -548,16 +548,6 @@ LibTest/isolate/Isolate/spawn_A04_t04: Fail # Issue 27558
LibTest/isolate/ReceivePort/asBroadcastStream_A03_t01: Fail # please triage
[ $compiler == dart2js && $fast_startup && $browser ]
LayoutTests/fast/dom/custom/document-register-on-create-callback_t01: Fail # please triage
LayoutTests/fast/dom/custom/unresolved-pseudoclass_t01: Fail # please triage
WebPlatformTest/custom-elements/concepts/type_A01_t01: Fail # custom elements not supported
LayoutTests/fast/dom/custom/attribute-changed-callback_t01: Fail # custom elements not supported
LayoutTests/fast/dom/custom/created-callback_t01: Fail # please triage
LayoutTests/fast/dom/custom/document-register-namespace_t01: Fail # please triage
LayoutTests/fast/dom/custom/document-register-type-extensions_t01: Fail # please triage
LayoutTests/fast/dom/custom/element-type_t01: Fail # custom elements not supported
LayoutTests/fast/dom/custom/element-upgrade_t01: Fail # please triage
LayoutTests/fast/dom/custom/type-extensions_t01: Fail # custom elements not supported
WebPlatformTest/shadow-dom/elements-and-dom-objects/extensions-to-element-interface/attributes/test-001_t01: Fail # custom elements not supported
WebPlatformTest/shadow-dom/elements-and-dom-objects/extensions-to-element-interface/attributes/test-004_t01: Fail # please triage
WebPlatformTest/shadow-dom/elements-and-dom-objects/extensions-to-element-interface/attributes/test-004_t02: Fail # please triage
@ -580,7 +570,6 @@ WebPlatformTest/shadow-dom/events/retargeting-focus-events/test-003_t01: Fail #
WebPlatformTest/shadow-dom/html-elements-and-their-shadow-trees/test-001_t01: Fail # please triage
WebPlatformTest/shadow-dom/html-elements-and-their-shadow-trees/test-002_t01: Fail # please triage
WebPlatformTest/shadow-dom/html-elements-and-their-shadow-trees/test-003_t01: Fail # please triage
WebPlatformTest/shadow-dom/shadow-trees/custom-pseudo-elements/test-001_t01: Fail # please triage
WebPlatformTest/shadow-dom/shadow-trees/distributed-pseudo-element/test-001_t01: Fail # please triage
WebPlatformTest/shadow-dom/shadow-trees/distributed-pseudo-element/test-002_t01: Fail # please triage
@ -589,15 +578,15 @@ WebPlatformTest/shadow-dom/shadow-trees/upper-boundary-encapsulation/ownerdocume
WebPlatformTest/shadow-dom/shadow-trees/upper-boundary-encapsulation/selectors-api-001_t01: Fail # please triage
WebPlatformTest/shadow-dom/shadow-trees/upper-boundary-encapsulation/selectors-api-002_t01: Fail # please triage
WebPlatformTest/shadow-dom/shadow-trees/upper-boundary-encapsulation/test-009_t01: Fail # please triage
WebPlatformTest/custom-elements/concepts/type_A07_t01: Fail # custom elements not supported
WebPlatformTest/custom-elements/concepts/type_A08_t01: Fail # please triage
WebPlatformTest/custom-elements/instantiating/createElementNS_A01_t01: Fail # please triage
WebPlatformTest/custom-elements/instantiating/createElementNS_A04_t01: Fail # custom elements not supported
WebPlatformTest/custom-elements/instantiating/createElementNS_A05_t01: Fail # custom elements not supported
WebPlatformTest/custom-elements/instantiating/createElement_A01_t01: Fail # please triage
WebPlatformTest/custom-elements/instantiating/createElement_A05_t01: Fail # please triage
WebPlatformTest/custom-elements/instantiating/isAttribute_A03_t01: Fail # please triage
WebPlatformTest/custom-elements/instantiating/localName_A01_t01: Fail # please triage
[ $compiler == dart2js && $runtime == chrome && $fast_startup && $checked ]
WebPlatformTest/custom-elements/instantiating/createElementNS_A04_t01: RuntimeError # Please triage this failure
WebPlatformTest/custom-elements/instantiating/createElement_A04_t01: RuntimeError # Please triage this failure
WebPlatformTest/custom-elements/instantiating/isAttribute_A02_t01: RuntimeError # Please triage this failure
[ $compiler == dart2js && $runtime == drt && $fast_startup && $checked ]
WebPlatformTest/custom-elements/instantiating/createElementNS_A05_t01: RuntimeError # Please triage this failure
WebPlatformTest/custom-elements/instantiating/createElement_A05_t01: RuntimeError # Please triage this failure
[ $compiler == dart2js && $fast_startup && $browser && $runtime != chrome && $runtime != drt]
WebPlatformTest/shadow-dom/elements-and-dom-objects/extensions-to-element-interface/attributes/test-005_t01: Fail # please triage
@ -626,7 +615,6 @@ WebPlatformTest/shadow-dom/events/retargeting-focus-events/test-001_t03: Fail #
WebPlatformTest/shadow-dom/events/retargeting-focus-events/test-001_t04: Fail # please triage
WebPlatformTest/shadow-dom/events/retargeting-relatedtarget/test-001_t01: Fail # please triage
WebPlatformTest/shadow-dom/events/retargeting-relatedtarget/test-002_t01: Fail # please triage
WebPlatformTest/shadow-dom/html-elements-in-shadow-trees/html-forms/test-001_t01: Fail # custom elements not supported
WebPlatformTest/shadow-dom/html-elements-in-shadow-trees/html-forms/test-002_t01: Fail # please triage
WebPlatformTest/shadow-dom/html-elements-in-shadow-trees/inert-html-elements/test-002_t01: Fail # please triage
@ -1795,13 +1783,7 @@ WebPlatformTest/shadow-dom/shadow-trees/upper-boundary-encapsulation/test-009_t0
WebPlatformTest/webstorage/event_constructor_t01: RuntimeError # Please triage this failure
WebPlatformTest/webstorage/event_constructor_t02: RuntimeError # Please triage this failure
[ $compiler == dart2js && $runtime == chrome && $fast_startup ]
WebPlatformTest/custom-elements/concepts/type_A04_t01: RuntimeError # Please triage this failure
WebPlatformTest/custom-elements/instantiating/createElement_A04_t01: RuntimeError # Please triage this failure
WebPlatformTest/custom-elements/instantiating/isAttribute_A02_t01: RuntimeError # Please triage this failure
WebPlatformTest/custom-elements/instantiating/namespace_A01_t01: RuntimeError # Please triage this failure
[ $compiler == dart2js && $runtime == chrome && $fast_startup == false ]
[ $compiler == dart2js && $runtime == chrome ]
WebPlatformTest/custom-elements/concepts/type_A03_t01: RuntimeError # Please triage this failure
[ $compiler == dart2js && $runtime == chrome && $checked ]
@ -2679,19 +2661,7 @@ WebPlatformTest/shadow-dom/shadow-trees/upper-boundary-encapsulation/test-009_t0
WebPlatformTest/webstorage/event_constructor_t01: RuntimeError # Please triage this failure
WebPlatformTest/webstorage/event_constructor_t02: RuntimeError # Please triage this failure
[ $compiler == dart2js && $runtime == drt && $fast_startup ]
WebPlatformTest/custom-elements/concepts/type_A04_t01: RuntimeError # Please triage this failure
WebPlatformTest/custom-elements/instantiating/createElementNS_A02_t01: RuntimeError # Please triage this failure
WebPlatformTest/custom-elements/instantiating/createElementNS_A03_t01: RuntimeError # Please triage this failure
WebPlatformTest/custom-elements/instantiating/createElement_A02_t01: RuntimeError # Please triage this failure
WebPlatformTest/custom-elements/instantiating/createElement_A03_t01: RuntimeError # Please triage this failure
WebPlatformTest/custom-elements/instantiating/createElement_A04_t01: RuntimeError # Please triage this failure
WebPlatformTest/custom-elements/instantiating/isAttribute_A01_t01: RuntimeError # Please triage this failure
WebPlatformTest/custom-elements/instantiating/isAttribute_A01_t02: RuntimeError # Please triage this failure
WebPlatformTest/custom-elements/instantiating/isAttribute_A02_t01: RuntimeError # Please triage this failure
WebPlatformTest/custom-elements/instantiating/namespace_A01_t01: RuntimeError # Please triage this failure
[ $compiler == dart2js && $runtime == drt && $fast_startup == false ]
[ $compiler == dart2js && $runtime == drt ]
WebPlatformTest/custom-elements/concepts/type_A03_t01: RuntimeError # Please triage this failure
[ $compiler == dart2js && $runtime == drt && $fast_startup && $checked ]

16
tests/html/html.status
View file

@ -419,22 +419,6 @@ custom/js_custom_test: Fail # mirrors not supported
custom/mirrors_test: Fail # mirrors not supported
mirrors_js_typed_interop_test: Fail # mirrors not supported
[ $compiler == dart2js && $fast_startup && $browser ]
custom/attribute_changed_callback_test/fully_supported: Fail # custom elements not supported
custom/attribute_changed_callback_test/unsupported_on_polyfill: Fail # custom elements not supported
custom/document_register_type_extensions_test/construction: Fail # custom elements not supported
custom/document_register_type_extensions_test/functional: Fail # custom elements not supported
custom/document_register_type_extensions_test/namespaces: Fail # custom elements not supported
custom/document_register_type_extensions_test/parsing: Fail # custom elements not supported
custom/document_register_type_extensions_test/registration: Fail # custom elements not supported
custom/entered_left_view_test: Fail # custom elements not supported
custom/element_upgrade_test: Fail # custom elements not supported
custom/document_register_basic_test: Fail # custom elements not supported
custom/document_register_type_extensions: Fail # custom elements not supported
custom_elements_23127_test/baseline: Fail # custom elements not supported
custom_elements_23127_test/c1t: Fail # custom elements not supported
custom_elements_23127_test/c2: Fail # custom elements not supported
[ $compiler == dart2js && $cps_ir && $browser ]
js_typed_interop_side_cast_exp_test: RuntimeError # Corner case in package:js that we might want to remove (See comment in #24978).
js_typed_interop_test/static_method_tearoff_1: RuntimeError # Tree-shaking a used tear-off (#24978, #25720).