languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 08:24:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Extract appending nodes to the list into a helper method.

Browse source 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2417053002 .
This commit is contained in:
Konstantin Shcheglov 2016-10-13 13:29:36 -07:00
parent 809c80fa49
commit 318e842389
1 changed files with 20 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
pkg/analyzer/lib/src/dart/sdk/patch.dart
View file

@ -197,14 +197,9 @@ class SdkPatcher {
patchMember.offset);
}
}
// Append new top-level declarations.
Token lastToken = baseClass.endToken.previous;
for (ClassMember newMember in membersToAppend) {
newMember.endToken.setNext(lastToken.next);
lastToken.setNext(newMember.beginToken);
baseClass.members.add(newMember);
lastToken = newMember.endToken;
}
// Append new class members.
_appendToNodeList(
baseClass.members, membersToAppend, baseClass.leftBracket);
}
void _patchDirectives(
@ -279,13 +274,8 @@ class SdkPatcher {
}
}
// Append new top-level declarations.
Token lastToken = baseUnit.endToken.previous;
for (CompilationUnitMember newDeclaration in declarationsToAppend) {
newDeclaration.endToken.setNext(lastToken.next);
lastToken.setNext(newDeclaration.beginToken);
baseUnit.declarations.add(newDeclaration);
lastToken = newDeclaration.endToken;
}
_appendToNodeList(baseUnit.declarations, declarationsToAppend,
baseUnit.endToken.previous);
}
/**
@ -309,6 +299,21 @@ class SdkPatcher {
return unit;
}
/**
* Append [newNodes] to the given [nodes] and attach new tokens to the end
* token of the last [nodes] items, or, if it is empty, to [defaultPrevToken].
*/
static void _appendToNodeList(
NodeList<AstNode> nodes, List<AstNode> newNodes, Token defaultPrevToken) {
Token prevToken = nodes.endToken ?? defaultPrevToken;
for (AstNode newNode in newNodes) {
newNode.endToken.setNext(prevToken.next);
prevToken.setNext(newNode.beginToken);
nodes.add(newNode);
prevToken = newNode.endToken;
}
}
/**
* Return `true` if [metadata] has the `@patch` annotation.
*/