We were missing a string marked as translated.
Also, this files shouldn't have the nautilus style since they are a
copy pasted code, so this patch just copied them and therefore the
changes look bigger than what it should be.
When icons are enabled on desktop, we should be able to "eject"
the mountable devices on the selection menu. We were not setting
the actions visiblity correctly, which makes for example the "eject"
selection menu item not showing up.
This patch sets the correct initial conditions.
https://bugzilla.gnome.org/show_bug.cgi?id=768355
We need to have our own copy and ownership of the parameter data,
if not later on when we do async operations the data might be already
freed.
This was making batch rename crash every time.
This is to follow the common pattern of not transferring the ownership
from caller to called.
https://bugzilla.gnome.org/show_bug.cgi?id=770586
'Other locations' is already listed in the sidebar. So there is no
need for allowing the user to bookmark 'Other Locations'.
This commit makes the bookmark button in toolbar insensitive for
'Other Locations'.
https://bugzilla.gnome.org/show_bug.cgi?id=771163
Even if late... I just realized neither NautilusDirectory or
NautilusFile are thread safe.
We were using them from two different threads for checking conflicts,
and that was crashing when the internal hash table was modified and
accessed from the different threads.
The ideal fix would be to make NautilusDirectory and NautilusFile thread
safe, but that's a big work. So for now, call the main thread for using
them.
https://bugzilla.gnome.org/show_bug.cgi?id=771129
We were using the view as the destination for compression and
decompression.
However, the parent of the files is not always the view. This is the
case in list view when the "allow expand folder" setting is set and the
selection is different than the root location of the view.
To fix it, use a parent of one of the selected files, we assume all
files has the same parent.
https://bugzilla.gnome.org/show_bug.cgi?id=771470
We weren't checking if there is some file selected to enable/disable
the compress action, which was causing the context menu item be always
displayed if we clicked an element that is not a file.
As odd as it sounds, this happens when allow to expand folders in list
view, since the "empty" element is selectable but not a file.
To fix that, check whether we have a file selected or not.
https://bugzilla.gnome.org/show_bug.cgi?id=771469