This reverts commit ba665f5371.
NautilusFilesView should be agnostic to the inner widgetry. So,
it should not be GtkListItemWidget|listitem.select action.
Also, moving this whole function is not necessary. The true cause of
the bug[0] was that NautilusFilesView was not forwarding the focus
event its child. Which turned out to be an AdwBin bug. Good news is
this bug has been fixed in libadwaita main[1] and stable[2] branches.
So let's revert this workaround.
[0] https://gitlab.gnome.org/GNOME/nautilus/-/issues/3354
[1] 0e30d48f66
[2] 9962168906
This is a follow-up to commit 1206af7d12
It fixed a bug where we were validating but not accepting the filename.
try_accept() and validate() do almost the same job except the first also emits
::name-accepted if valid, or, if duplicate, shows feedback without delay.
The 'go-up' and 'go-down' icons in the batch rename dialog do not seem to have any tooltips.
> Tooltips can be set for any UI element. They are primarily used to convey additional information about what controls (often icon buttons) do, but can also be used to show additional information about app content.
More information: https://developer.gnome.org/hig/patterns/feedback/tooltips.html
Cleanup ui layout via using AdwActionRow with .property style class
instead of adding GtkLabels for file attributes values.
Note: Long file paths (parent folder, link target, original folder)
become multiline.
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/3183
The mime type x-directory/smb-share is not used by any current programs
anymore. A Github search resulted only in nautilus forks and references
to the deprecated gnome-vfs.
Allow passing a file's parent to get_filesystem_use_preview and
get_filesystem_remote. This resolves the multi-level parent checking
discussed in [1], by only checking one parent at most.
[1] https://gitlab.gnome.org/GNOME/nautilus/-/issues/3336
GtkCheckButton has the label property, so embedding a GtkLabel
to it is unnecessary. This fixes the warning that says
"Finalizing GtkCheckButton [...], but it still has children left:
GtkLabel".
Also, add a mnemonic.
Because of the "Reset" button, the "Replace and "Rename" button
use the letter "P" and "N" respectively for their mnemonics,
which is odd, since the letter "R" would be more practical
to use; and "Replace and "Rename" never appear together.
So, use the letter "R" for "Replace and "Rename" and "E"
for the "Reset" button.
Each module's shutdown() should have been called in unload(), but
as we know, unload() never ended up getting called. Instead
call it during teardown()
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/1971
Our modules never would reach the unload point anyways and GModule
doesn't actually unload the module, so let's remove anything related
to unloading to simplify.
Related: https://gitlab.gnome.org/GNOME/glib/-/issues/667
Related: 72df62600d
Also:
- Increase margins around content to make the UI more
balanced
- Ditch the .view style class to improve consistency,
because other Nautilus windows don't use this style class
- Put the GtkGrid directly in the content widget
These types are part of xdg-mime specification and already have
translations that are identical to the ones that we have. Remove
them from here to reduce duplicate work for the translators.