Commit graph

240 commits

Author SHA1 Message Date
Tyler James Leonhardt 0715386207
Return scope array that was given to us so that account icon number goes away (#151027) 2022-06-01 14:16:24 -07:00
Logan Ramos 3a8b1fe03e
More telemetry comments (#150303)
* Add owners to all telemetry events

* More comments

* Add comments to non typescript GDPR annotation

* Another comment
2022-05-24 16:00:55 -07:00
Tyler James Leonhardt 847629239b
add owner and comment to some telemetry events (#148752) 2022-05-05 17:30:51 -04:00
Logan Ramos b16dc5f6ef
Upgrade tas client modules (#148796)
* Upgrade tas client modules

* Fix root package being wrong version

Co-authored-by: SteVen Batten <6561887+sbatten@users.noreply.github.com>
2022-05-05 13:37:33 -04:00
Joyce Er 9556854c8f
Bump vscode-tas-client for CG (#148673) 2022-05-03 17:37:34 -07:00
João Moreno af684a4906
fixes #148414 (#148418) 2022-05-02 07:14:26 -07:00
Tyler Leonhardt e2ec6f0a54
more accurate naming of pages 2022-04-27 15:40:41 -07:00
Tyler Leonhardt 842a41c8ab
add additional log statement 2022-04-27 15:38:56 -07:00
Tyler Leonhardt a900709990
better handling of prompting and ensure PAT doesn't show up in supported products 2022-04-25 17:27:26 -07:00
Tyler Leonhardt ed6d360182
add fallback auth server for github auth and better fallback logic 2022-04-15 15:48:29 -07:00
Tyler Leonhardt 5919378269
don't surface error on gets and remove microsoft secret migration. Fixes #146553 2022-04-14 12:18:33 -07:00
Tyler Leonhardt 46452a2dbf
ensure GitHub Edu telemetry fires only per account not per session 2022-04-11 11:04:53 -07:00
Tyler Leonhardt 62866e4fa5
use URL class in a few places 2022-03-29 16:20:08 -07:00
Tyler Leonhardt b1fb11e18c
have code-oss use device code flow 2022-03-28 09:05:28 -07:00
Tyler Leonhardt bee517564c
remove leading / so that local dev would work 2022-03-23 16:03:26 -07:00
Tyler Leonhardt 39c6779828
depend on stable vscode.dev for auth extensions 2022-03-21 09:35:34 -07:00
Tyler James Leonhardt 18df55c4d4
Use vscode.dev for GH auth (#145424)
* Use vscode.dev for GH auth

* use correct urls and fix URLSearchParams typing
2022-03-18 15:58:44 -07:00
Logan Ramos 9b7268acf9
Update telemetry module 2022-03-18 11:34:33 -04:00
Robo 32d40cf44e
chore: update to electron 17 (#143223)
* chore: bump electron@17.0.0

* Revert "chore: revert to electron@13 (#143851)"

This reverts commit df645f1450.

* chore: bump electron@17.1.0

* Revert "ci: fix build with latest node-gyp"

This reverts commit c3e948aa30.

* chore: revert ci changes for node v16

* chore: update yarn.lock

* chore: bump electron@17.1.1
2022-03-11 00:51:37 +09:00
Tyler Leonhardt c254a23e72
update vscode-tas-client 2022-02-28 16:23:14 -08:00
Robo df645f1450
chore: revert to electron@13 (#143851)
* Revert "chore: update to electron 16 (#137241)"

This reverts commit 01df559c18.
This reverts commit 46301339b7

* ci: fix remote compiler for sdl-scan

* chore: fix remote/.yarnrc

* chore: fix build/npm/postinstall.js

* chore: rm crash reporter from shared process

* chore: rm crash reporter from ext host

* chore: fix build/lib/layersChecker.ts

* :chore: preserve some more changes

* fix tests

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2022-02-24 17:49:49 +01:00
dependabot[bot] ad70ffe4e9
Bump follow-redirects in /extensions/github-authentication (#142891)
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-21 12:41:24 +01:00
Robo 01df559c18
chore: update to electron 16 (#137241)
* chore: bump electron@15.3.0

* chore: bump node@16.x

* chore: enable render process reuse

* Revert "watcher - use `type` property for crash reporter location"

This reverts commit bfa488dd8f.

* Revert "watcher - enable crash reports on linux (#136264)"

This reverts commit af261488f8.

* chore: enable crashpad on linux

* chore: bump electron@15.3.1

* chore: update api changes

* chore: bump @vscode/sqlite3@5.0.3

* spec: skip non-context aware module unittests

* chore: fix perf hook integration with node environment

* fix: adopt fs api changes

* chore: fix integration tests

* chore: bump electron@15.3.2

* chore: bump electron@16.0.0

* temp(macOS): kill test instances in OSS

* Revert "temp(macOS): kill test instances in OSS"

This reverts commit b0d796c8d64227a5ec012c060bbbee7d9da27568.

* chore: update chromium version for clang downloader

* some 💄 changes

* align with changes

* adopt more fs.rm

* 💄

* chore: bump @vscode/sqlite3@5.0.4

* fix layers check to account for duplicated types from node.js

* update todo for type casts

* smoke - fix compile issue

* chore: update module cache

* watcher - fix unhandled rejection (fix #137416)

* ci: update node version

* enable stack dumping

* update electron types to 16.x

* chore: bump @vscode/sqlite3@5.0.5

Refs https://github.com/microsoft/vscode/issues/137496

* fix layer issue

* add `AbortSignal` to core types

* chore: update linux compile flags

Refs 797723ec83

* ci: fix linux build

* ci: update github ci cache

* ci: fix remote build in github ci

* ci: better fix for remote build

* chore: bump azure cache

* chore: fix merge conflict

* :chore: update to electron@16.0.2

* chore: bump @vscode/sqlite3@5.0.7

* ci: update to gcc-4.9 for remote

Refs https://github.com/microsoft/vscode/issues/137659

* ci: switch to buster for linux arm

Refs https://github.com/microsoft/vscode/issues/137927

* ci: fix build on linux arm64

* ci: fix arm client compiler toolchain

Refs #137927

* chore: bump electron@16.0.3

* ci: fix compile flags for the c toolchain

* chore: bump electron@16.0.4

* Add experimental dark mode flag (#139109)

* Add experimental dark mode flag

* Apply PR feedback

* chore: bump electron@16.0.6

* chore: bump electron@16.0.7

Fixes https://github.com/microsoft/vscode/issues/138792
Fixes https://github.com/microsoft/vscode/issues/139300

* chore: experimental highlight API

* smoke - fix compile issue

* FIXME: custom ELECTRON_RUN_AS_NODE with node worker

* Revert "chore: bump electron@16.0.7"

This reverts commit 5fd01cf37c.

* Revert "Revert "chore: bump electron@16.0.7""

This reverts commit a7f1b73951.

* chore: fix github linux workflow

* chore: address review feedback

* chore: bump electron@16.0.8

* ci: revert to stretch distro for linux arm

Refs https://github.com/microsoft/vscode/issues/137927

* ci: force build

* chore: update yarn.lock

* address feedback

* Revert "FIXME: custom ELECTRON_RUN_AS_NODE with node worker"

This reverts commit 7b48fa3732.

* ci: fix remote folder build

* chore: fix github linux ci

* 🆙 `versionSpec`

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Raymond Zhao <raymondzhao@microsoft.com>
2022-02-08 20:09:00 +01:00
Johannes Rieken 4a130c40ed
enable @typescript-eslint/member-delimiter-style, https://github.com/microsoft/vscode/issues/140391 2022-02-02 14:35:33 +01:00
Tyler Leonhardt c68d433ac8
copy & continue. Fixes microsoft/vscode-internalbacklog#2613 2022-01-27 16:55:27 -08:00
dependabot[bot] e137d37e79
Bump node-fetch from 2.6.1 to 2.6.7 in /extensions/github-authentication (#141537)
Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.1 to 2.6.7.
- [Release notes](https://github.com/node-fetch/node-fetch/releases)
- [Commits](https://github.com/node-fetch/node-fetch/compare/v2.6.1...v2.6.7)

---
updated-dependencies:
- dependency-name: node-fetch
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-01-26 10:16:05 -08:00
Logan Ramos c047af40b2
Fix compilation 2022-01-19 16:18:14 -05:00
Logan Ramos b22ee20028
Move to @vscode/extension-telemetry 2022-01-19 15:57:17 -05:00
dependabot[bot] 43822f57e0
Bump follow-redirects in /extensions/github-authentication (#140797)
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.5 to 1.14.7.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.5...v1.14.7)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-01-17 10:57:41 -08:00
svennergr 22e45e9f88
Add proper error message on getUserInfo (#140277)
* Add proper error message on getUserInfo

* improved error message on getUserInfo

either display the response message or the http status text

Co-authored-by: Sven Grossmann <mail@grossmann.dev>
2022-01-10 11:35:20 -08:00
Logan Ramos 932ab8e485
Update vscode extension telemetry modules 2021-12-28 11:06:48 -05:00
Tyler Leonhardt e8a26d3ebf
ensure we treat scopes sorted and we only return a single session since GH only supports a single log in 2021-12-20 17:12:53 -05:00
Tyler James Leonhardt f67a8b753f
Use device flow over PAT when we are running in a server full environment but not in a supported uri (#139255)
* initial attempt

* use github-authentication instead

* rework error handling

* update copy

* explain why Workspace
2021-12-15 22:07:49 -05:00
Tyler Leonhardt a3e60d2dff
Add messages for rejected promises 2021-12-07 16:23:04 -08:00
Johannes Rieken 09c9d4c293
use enabledApiProposals instead of wildcard property, also update compilation units to only include d.ts-files that are needed, https://github.com/microsoft/vscode/issues/131165 2021-11-12 11:05:57 +01:00
Johannes Rieken a4d426a1c2
split vscode.proposed.d.ts into a file per proposal, https://github.com/microsoft/vscode/issues/131165 2021-11-12 09:48:17 +01:00
Raymond Zhao 023cfc9959
Bump axios 2021-11-11 13:59:22 -08:00
Johannes Rieken 68e819043c
use tsconfig.json#include for vscode.d.ts and vscode.proposed.d.ts, enables to remove most ref.d.ts-files 2021-11-09 15:53:35 +01:00
Johannes Rieken 9254a8cd27
move vscode.d.ts and vscode.proposed.d.ts into src/vscode-dts-folder, https://github.com/microsoft/vscode/issues/131165 2021-11-09 15:00:03 +01:00
Logan Ramos 00de6a5f2f
Update telemetry module 2021-11-08 10:00:44 -05:00
Tyler Leonhardt 4d496f61bc
remove keytar fallback in keychain and add a ton more logging to microsoft auth. ref #133201 2021-10-25 11:16:37 -07:00
Joyce Er b97ab80c18
Fix typo in PAT auth flow error message 2021-10-20 16:37:02 -07:00
João Moreno a390f81744
no hack is better hack
Co-authored-by: Tyler <TylerLeonhardt@users.noreply.github.com>
2021-10-11 18:02:36 +02:00
Tyler Leonhardt 5364c56768
include insiders.vscode in nocors 2021-10-08 11:32:28 -07:00
Logan Ramos a4342f3add
Bump telemetry module 2021-10-01 16:52:56 -04:00
Tyler Leonhardt ab184912e6
make sure we splice the sessions if they have the same set of scopes for github authentication 2021-09-23 16:46:31 -07:00
Logan Ramos 282f499c22
Update extension telemetry module 2021-09-23 11:26:57 -04:00
Logan Ramos 420436d4c4
Fix #133493 2021-09-21 13:36:30 -04:00
Sandeep Somavarapu 961c2e353d
remove web extension kind in builtin extensions 2021-09-01 15:09:21 +02:00
Logan Ramos 8dbad73de5
Update built in extensions telemetry 2021-08-27 15:45:42 -04:00
Logan Ramos ecc7fdac90
Bump extension telemetry module 2021-08-27 11:29:48 -04:00
Tyler Leonhardt 520fa49e68
refactor github auth to be a bit simpler. Remove PAT for GitHub auth since Settings Sync doesn't allow for it and add timeout so that GitHub Auth is not stuck. 2021-08-16 16:34:21 -07:00
Logan Ramos da7d76d2ec
Update extension telemetry module 2021-08-10 12:43:41 -04:00
Logan Ramos 6aa5b9226b
Update extension telemetry module 2021-08-09 13:16:08 -04:00
Tyler Leonhardt a8332b75e4
delete extra afterTokenLoad 2021-08-03 16:24:28 -07:00
Tyler Leonhardt 37a8fe959c
no longer call /user to verify tokens 2021-08-03 14:50:07 -07:00
Logan Ramos 9350fa3c9d
Bump telemetry module to fix packaging 2021-08-02 14:29:37 -04:00
Logan Ramos b7a07daa5a
Fix #129727 2021-08-02 13:04:26 -04:00
Logan Ramos 87e0cb1d43
Fix #129474 2021-07-29 11:39:03 -04:00
Logan Ramos c8e6d08e3a
Update to the latest extension module 2021-07-26 13:44:43 -04:00
Tyler Leonhardt c7e45c4fa4
Add a bunch of logging to github-authentication
Co-authored-by: Eric Amodio <eamodio@users.noreply.github.com>
2021-07-23 15:28:06 -07:00
Tyler Leonhardt c1b4cf00b9
update auth extensions to use packageJSON property instead 2021-07-23 11:48:39 -07:00
Tyler Leonhardt 8a4ace6ebf
maintain promise instead in github-auth to ensure the exp service doesn't get created twice 2021-07-23 09:24:40 -07:00
Tyler Leonhardt a8134002cd
lazily load experimentation service in github-authentication 2021-07-23 09:07:41 -07:00
Tyler Leonhardt 54a2e15f6b
remove unused variable 2021-07-22 17:40:13 -07:00
Tyler Leonhardt 3ed425bef9
Rework github authentication extension to make less HTTP requests.
Co-authored-by: Eric Amodio <eamodio@users.noreply.github.com>
2021-07-22 17:25:59 -07:00
VocalTrance 715798221b
Fix typo in github-authentication/github.ts (#129100) 2021-07-21 06:30:45 -07:00
Martin Aeschlimann 7ded90e452
Merge branch 'main' into joh/webpack5 2021-07-09 09:50:10 +02:00
Tyler James Leonhardt 87d692b7bf
Add scopes property to login telemetry (#128261)
* Add scopes property to login telemetry
2021-07-08 21:48:44 -07:00
Martin Aeschlimann 7ebe6a6054
adopt web extensions to webpack 5 2021-07-08 21:41:03 +02:00
Tyler Leonhardt e09ee35542
add useful readmes for the auth providers fixes #127688 fixes #127689 2021-07-06 15:43:59 -07:00
Tyler Leonhardt 1d1b9961d7
sort scopes on filter for getSessions in the github auth provider. Fixes https://github.com/github/codespaces/issues/3109 2021-06-30 10:15:24 -07:00
Tyler Leonhardt 6b6be7efe1
just return if the acceptedStates don't match fixes #126084 2021-06-28 17:12:06 -07:00
Tyler Leonhardt 4a011b5297
add additional logging around github auth 2021-06-28 16:27:52 -07:00
Kai Maetzel c200dc4909
fix isNoCorsEnvironment (#126718) 2021-06-18 17:36:59 -07:00
Pavel Kulyov cf7c86de97
extensions/github-authentication: fix typo (#126072)
Closes: #125468
2021-06-11 18:45:33 +00:00
Oleg Demchenko 61f34055fa
Auth session API fix (#125792)
* Adjust "provider is not registered" exception behavior

* Process cancellation in GH auth provider

`e.message` is always `undefined`
2021-06-10 20:14:08 +00:00
Matvii Hodovaniuk 67561036cf
Replace map with forEach (#115378)
The callback provided to the map call on this array should return a value, otherwise map will always return an array of undefined values. If the desired behaviour is to just iterate through all elements, then consider using forEach or a for-of loop instead.
2021-06-07 11:01:10 -07:00
Tyler Leonhardt e0c8a76b7a
don't sort scope list. Fixes Microsoft/vscode-pull-request-github#2751 2021-05-27 16:45:59 -07:00
João Moreno 0637663fcf
fix isNoCorsEnvironment 2021-05-27 11:45:12 +02:00
João Moreno 25a12c75c5
use dummy uri 2021-05-19 20:40:07 +02:00
Benjamin Pasero 159479eb5a
Allow to show status bar entries with an id and name (fix #74972) 2021-05-19 14:03:37 +02:00
Kevin Abel 4978a1891e
Implement GitHub Enterprise authn provider (#115940) 2021-05-07 14:13:11 -07:00
Robo bce4d71f64
chore: bump node@14.x in devDependencies (#122905) 2021-05-04 10:04:13 +02:00
João Moreno 87a33e998d
disable edu telemetry on nocors 2021-04-27 16:03:57 +02:00
Sandeep Somavarapu ac151b40a5
enable virtual workspace capability 2021-04-23 10:20:23 +02:00
SteVen Batten f9fc28d47d update ext manifest schema validation and built-in exts 2021-04-21 11:54:42 -07:00
João Moreno 034157dea8
gh auth: back to prod auth 2021-04-21 15:00:24 +02:00
João Moreno d60dbbf646
gh auth: fetch json 2021-04-21 10:48:01 +02:00
João Moreno 3668a573ad
gh auth: fix staging server selection 2021-04-21 10:06:26 +02:00
João Moreno 820e70a460
gh auth: don't reach out to product.json 2021-04-21 09:31:06 +02:00
Rachel Macfarlane c67ac5d083
Remove path from github-authentication 2021-04-20 16:49:23 -07:00
João Moreno 7b23ff442e
more staging detection (#121769)
* more staging detection

* check for scheme
2021-04-20 13:19:06 -07:00
João Moreno ad3e7ea1c0
gh auth: look at staging query param (#121768) 2021-04-20 13:04:56 -07:00
Miguel Solorio ac48f78dd6
Add icons for built-in extensions (fixes #81760) 2021-04-20 12:09:24 -07:00
Rachel Macfarlane 94589129a2
Add experimentation service to github auth extension 2021-04-20 09:25:01 -07:00
Rachel Macfarlane 296c417c07
Add workspace trust property to auth extensions 2021-04-15 09:22:15 -07:00
João Moreno a09d640311
github auth: improve test env detection
cc @RMacfarlane
2021-04-14 08:59:55 +02:00
Matt Bierner 119581fc2a
Use more standard name for shared extension tsconfig
This enables Intellisense in the `tsconfig.base` file
2021-04-12 15:58:38 -07:00
SteVen Batten 9c00242866 updating telemetry module for built-in exts 2021-03-22 16:28:08 -07:00