development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 04:49:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

More telemetry comments (#150303)

Browse source 
* Add owners to all telemetry events

* More comments

* Add comments to non typescript GDPR annotation

* Another comment
This commit is contained in:
Logan Ramos 2022-05-24 19:00:55 -04:00 committed by GitHub
parent f363be172c
commit 3a8b1fe03e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
28 changed files with 66 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
extensions/git/src/commands.ts
View file

@ -416,6 +416,7 @@ export class CommandCenter {
if (!url) {
/* __GDPR__
"clone" : {
"owner": "lszomoru",
"outcome" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
}
*/
@ -441,6 +442,7 @@ export class CommandCenter {
if (!uris || uris.length === 0) {
/* __GDPR__
"clone" : {
"owner": "lszomoru",
"outcome" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
}
*/
@ -499,6 +501,7 @@ export class CommandCenter {
/* __GDPR__
"clone" : {
"owner": "lszomoru",
"outcome" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
"openFolder": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true }
}
@ -518,6 +521,7 @@ export class CommandCenter {
if (/already exists and is not an empty directory/.test(err && err.stderr || '')) {
/* __GDPR__
"clone" : {
"owner": "lszomoru",
"outcome" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
}
*/
@ -527,6 +531,7 @@ export class CommandCenter {
} else {
/* __GDPR__
"clone" : {
"owner": "lszomoru",
"outcome" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
}
*/
@ -2920,6 +2925,7 @@ export class CommandCenter {
/* __GDPR__
"git.command" : {
"owner": "lszomoru",
"command" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
}
*/

4
extensions/git/src/main.ts
View file

@ -192,7 +192,9 @@ export async function _activate(context: ExtensionContext): Promise<GitExtension
outputChannelLogger.logWarning(err.message);
/* __GDPR__
"git.missing" : {}
"git.missing" : {
"owner": "lszomoru"
}
*/
telemetryReporter.sendTelemetryEvent('git.missing');

1
extensions/git/src/repository.ts
View file

@ -1864,6 +1864,7 @@ export class Repository implements Disposable {
if (didHitLimit) {
/* __GDPR__
"statusLimit" : {
"owner": "lszomoru",
"ignoreSubmodules": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
"limit": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
"statusLength": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true }

3
extensions/github-authentication/src/githubServer.ts
View file

@ -496,6 +496,7 @@ export class GitHubServer implements IGitHubServer {
/* __GDPR__
"session" : {
"owner": "TylerLeonhardt",
"isEdu": { "classification": "NonIdentifiableDemographicInfo", "purpose": "FeatureInsight" }
}
*/
@ -530,6 +531,7 @@ export class GitHubServer implements IGitHubServer {
/* __GDPR__
"ghe-session" : {
"owner": "TylerLeonhardt",
"version": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
}
*/
@ -601,6 +603,7 @@ export class GitHubEnterpriseServer implements IGitHubServer {
/* __GDPR__
"ghe-session" : {
"owner": "TylerLeonhardt",
"version": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
}
*/

2
extensions/typescript-language-features/src/languageFeatures/completions.ts
View file

@ -554,6 +554,7 @@ class CompletionAcceptedCommand implements Command {
if (item instanceof MyCompletionItem) {
/* __GDPR__
"completions.accept" : {
"owner": "mjbvz",
"isPackageJsonImport" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
"isImportStatementCompletion" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
"${include}": [
@ -820,6 +821,7 @@ class TypeScriptCompletionItemProvider implements vscode.CompletionItemProvider<
) {
/* __GDPR__
"completions.execute" : {
"owner": "mjbvz",
"duration" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
"type" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
"count" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },

1
extensions/typescript-language-features/src/languageFeatures/organizeImports.ts
View file

@ -32,6 +32,7 @@ class OrganizeImportsCommand implements Command {
public async execute(file: string, sortOnly = false): Promise<any> {
/* __GDPR__
"organizeImports.execute" : {
"owner": "mjbvz",
"${include}": [
"${TypeScriptCommonProperties}"
]

2
extensions/typescript-language-features/src/languageFeatures/quickFix.ts
View file

@ -37,6 +37,7 @@ class ApplyCodeActionCommand implements Command {
): Promise<boolean> {
/* __GDPR__
"quickFix.execute" : {
"owner": "mjbvz",
"fixName" : { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" },
"${include}": [
"${TypeScriptCommonProperties}"
@ -67,6 +68,7 @@ class ApplyFixAllCodeAction implements Command {
public async execute(args: ApplyFixAllCodeAction_args): Promise<void> {
/* __GDPR__
"quickFixAll.execute" : {
"owner": "mjbvz",
"fixName" : { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" },
"${include}": [
"${TypeScriptCommonProperties}"

1
extensions/typescript-language-features/src/languageFeatures/refactor.ts
View file

@ -36,6 +36,7 @@ class DidApplyRefactoringCommand implements Command {
public async execute(args: DidApplyRefactoringCommand_Args): Promise<void> {
/* __GDPR__
"refactor.execute" : {
"owner": "mjbvz",
"action" : { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" },
"${include}": [
"${TypeScriptCommonProperties}"

1
extensions/typescript-language-features/src/tsServer/server.ts
View file

@ -230,6 +230,7 @@ export class ProcessBasedTsServer extends Disposable implements ITypeScriptServe
if (!executeInfo.token || !executeInfo.token.isCancellationRequested) {
/* __GDPR__
"languageServiceErrorResponse" : {
"owner": "mjbvz",
"${include}": [
"${TypeScriptCommonProperties}",
"${TypeScriptRequestErrorProperties}"

6
extensions/typescript-language-features/src/typescriptServiceClient.ts
View file

@ -388,6 +388,7 @@ export default class TypeScriptServiceClient extends Disposable implements IType
/* __GDPR__
"tsserver.spawned" : {
"owner": "mjbvz",
"${include}": [
"${TypeScriptCommonProperties}"
],
@ -418,6 +419,7 @@ export default class TypeScriptServiceClient extends Disposable implements IType
/* __GDPR__
"tsserver.error" : {
"owner": "mjbvz",
"${include}": [
"${TypeScriptCommonProperties}"
]
@ -443,6 +445,7 @@ export default class TypeScriptServiceClient extends Disposable implements IType
this.error(`TSServer exited with code: ${code}. Signal: ${signal}`);
/* __GDPR__
"tsserver.exitWithCode" : {
"owner": "mjbvz",
"code" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },
"signal" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },
"${include}": [
@ -601,6 +604,7 @@ export default class TypeScriptServiceClient extends Disposable implements IType
/* __GDPR__
"serviceExited" : {
"owner": "mjbvz",
"${include}": [
"${TypeScriptCommonProperties}"
]
@ -846,6 +850,7 @@ export default class TypeScriptServiceClient extends Disposable implements IType
private fatalError(command: string, error: unknown): void {
/* __GDPR__
"fatalError" : {
"owner": "mjbvz",
"${include}": [
"${TypeScriptCommonProperties}",
"${TypeScriptRequestErrorProperties}"
@ -977,6 +982,7 @@ export default class TypeScriptServiceClient extends Disposable implements IType
/* __GDPR__
"typingsInstalled" : {
"owner": "mjbvz",
"installedPackages" : { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" },
"installSuccess": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },
"typingsInstallerVersion": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },

1
extensions/typescript-language-features/src/utils/largeProjectStatus.ts
View file

@ -49,6 +49,7 @@ class ExcludeHintItem {
this._item.show();
/* __GDPR__
"js.hintProjectExcludes" : {
"owner": "mjbvz",
"${include}": [
"${TypeScriptCommonProperties}"
]

14
src/vs/platform/diagnostics/node/diagnosticsService.ts
View file

@ -536,8 +536,10 @@ export class DiagnosticsService implements IDiagnosticsService {
try {
const stats = await collectWorkspaceStats(folder, ['node_modules', '.git']);
type WorkspaceStatsClassification = {
'workspace.id': { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };
rendererSessionId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };
owner: 'lramos15';
comment: 'Metadata related to the workspace';
'workspace.id': { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'A UUID given to a workspace to identify it.' };
rendererSessionId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The ID of the session' };
};
type WorkspaceStatsEvent = {
'workspace.id': string | undefined;
@ -548,9 +550,11 @@ export class DiagnosticsService implements IDiagnosticsService {
rendererSessionId: workspace.rendererSessionId
});
type WorkspaceStatsFileClassification = {
rendererSessionId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };
type: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true };
count: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true };
owner: 'lramos15';
comment: 'Helps us gain insights into what type of files are being used in a workspace';
rendererSessionId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The ID of the session.' };
type: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true; comment: 'The type of file' };
count: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true; comment: 'How many types of that file are present' };
};
type WorkspaceStatsFileEvent = {
rendererSessionId: string;

3
src/vs/platform/extensionManagement/common/abstractExtensionManagementService.ts
View file

@ -616,6 +616,7 @@ export function reportTelemetry(telemetryService: ITelemetryService, eventName:
const errorcode = error ? error instanceof ExtensionManagementError ? error.code : ExtensionManagementErrorCode.Internal : undefined;
/* __GDPR__
"extensionGallery:install" : {
"owner": "sandy081",
"success": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true },
"duration" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true },
"durationSinceUpdate" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
@ -628,6 +629,7 @@ export function reportTelemetry(telemetryService: ITelemetryService, eventName:
*/
/* __GDPR__
"extensionGallery:uninstall" : {
"owner": "sandy081",
"success": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true },
"duration" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true },
"errorcode": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" },
@ -638,6 +640,7 @@ export function reportTelemetry(telemetryService: ITelemetryService, eventName:
*/
/* __GDPR__
"extensionGallery:update" : {
"owner": "sandy081",
"success": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true },
"duration" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true },
"errorcode": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" },

1
src/vs/platform/extensionManagement/common/extensionGalleryService.ts
View file

@ -994,6 +994,7 @@ abstract class AbstractExtensionGalleryService implements IExtensionGalleryServi
const startTime = new Date().getTime();
/* __GDPR__
"galleryService:downloadVSIX" : {
"owner": "sandy081",
"duration": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true },
"${include}": [
"${GalleryExtensionTelemetryData}"

2
src/vs/workbench/browser/parts/editor/editorGroupView.ts
View file

@ -575,6 +575,7 @@ export class EditorGroupView extends Themable implements IEditorGroupView {
/* __GDPR__
"editorOpened" : {
"owner": "bpasero",
"${include}": [
"${EditorTelemetryDescriptor}"
]
@ -611,6 +612,7 @@ export class EditorGroupView extends Themable implements IEditorGroupView {
/* __GDPR__
"editorClosed" : {
"owner": "bpasero",
"${include}": [
"${EditorTelemetryDescriptor}"
]

1
src/vs/workbench/contrib/debug/browser/variablesView.ts
View file

@ -541,6 +541,7 @@ CommandsRegistry.registerCommand({
if (ext || await tryInstallHexEditor(notifications, progressService, extensionService, commandService)) {
/* __GDPR__
"debug/didViewMemory" : {
"owner": "connor4312",
"debugType" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
}
*/

2
src/vs/workbench/contrib/debug/common/debugTelemetry.ts
View file

@ -18,6 +18,7 @@ export class DebugTelemetry {
const extension = dbgr.getMainExtensionDescriptor();
/* __GDPR__
"debugSessionStart" : {
"owner": "connor4312",
"type": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
"breakpointCount": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
"exceptionBreakpoints": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
@ -44,6 +45,7 @@ export class DebugTelemetry {
/* __GDPR__
"debugSessionStop" : {
"owner": "connor4312",
"type" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
"success": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
"sessionLengthInSeconds": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },

1
src/vs/workbench/contrib/extensions/browser/extensionEditor.ts
View file

@ -562,6 +562,7 @@ export class ExtensionEditor extends EditorPane {
}
/* __GDPR__
"extensionGallery:openExtension" : {
"owner": "sandy081",
"recommendationReason": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
"${include}": [
"${GalleryExtensionTelemetryData}"

1
src/vs/workbench/contrib/extensions/browser/extensionRecommendationsService.ts
View file

@ -234,6 +234,7 @@ export class ExtensionRecommendationsService extends Disposable implements IExte
if (recommendationReason) {
/* __GDPR__
"extensionGallery:install:recommendations" : {
"owner": "sandy081",
"recommendationReason": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
"${include}": [
"${GalleryExtensionTelemetryData}"

2
src/vs/workbench/contrib/extensions/browser/extensionsWorkbenchService.ts
View file

@ -1455,6 +1455,7 @@ export class ExtensionsWorkbenchService extends Disposable implements IExtension
if (changed[i]) {
/* __GDPR__
"extension:enable" : {
"owner": "sandy081",
"${include}": [
"${GalleryExtensionTelemetryData}"
]
@ -1462,6 +1463,7 @@ export class ExtensionsWorkbenchService extends Disposable implements IExtension
*/
/* __GDPR__
"extension:disable" : {
"owner": "sandy081",
"${include}": [
"${GalleryExtensionTelemetryData}"
]

1
src/vs/workbench/contrib/localization/electron-sandbox/localization.contribution.ts
View file

@ -133,6 +133,7 @@ export class LocalizationWorkbenchContribution extends Disposable implements IWo
const logUserReaction = (userReaction: string) => {
/* __GDPR__
"languagePackSuggestion:popup" : {
"owner": "TylerLeonhardt",
"userReaction" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
"language": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
}

3
src/vs/workbench/contrib/search/common/searchModel.ts
View file

@ -1076,6 +1076,7 @@ export class SearchModel extends Disposable {
Promise.race([currentRequest, Event.toPromise(progressEmitter.event)]).finally(() => {
/* __GDPR__
"searchResultsFirstRender" : {
"owner": "roblourens",
"duration" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true }
}
*/
@ -1091,6 +1092,7 @@ export class SearchModel extends Disposable {
} finally {
/* __GDPR__
"searchResultsFinished" : {
"owner": "roblourens",
"duration" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true }
}
*/
@ -1119,6 +1121,7 @@ export class SearchModel extends Disposable {
/* __GDPR__
"searchResultsShown" : {
owner": "roblourens",
"count" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
"fileCount": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
"options": { "${inline}": [ "${IPatternInfo}" ] },

5
src/vs/workbench/contrib/surveys/browser/ces.contribution.ts
View file

@ -66,6 +66,7 @@ class CESContribution extends Disposable implements IWorkbenchContribution {
const sendTelemetry = (userReaction: 'accept' | 'remindLater' | 'neverShowAgain' | 'cancelled') => {
/* __GDPR__
"cesSurvey:popup" : {
"owner": "digitarald",
"userReaction" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
}
*/
@ -141,7 +142,9 @@ class CESContribution extends Disposable implements IWorkbenchContribution {
}
}
/* __GDPR__
"cesSurvey:schedule" : { }
"cesSurvey:schedule" : {
"owner": "digitarald"
}
*/
this.telemetryService.publicLog('cesSurvey:schedule');

3
src/vs/workbench/contrib/tags/electron-sandbox/workspaceTags.ts
View file

@ -89,6 +89,7 @@ export class WorkspaceTags implements IWorkbenchContribution {
private reportWorkspaceTags(tags: Tags): void {
/* __GDPR__
"workspce.tags" : {
"owner": "lramos15",
"${include}": [
"${WorkspaceTags}"
]
@ -116,6 +117,7 @@ export class WorkspaceTags implements IWorkbenchContribution {
set.forEach(item => list.push(item));
/* __GDPR__
"workspace.remotes" : {
"owner": "lramos15",
"domains" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
}
*/
@ -192,6 +194,7 @@ export class WorkspaceTags implements IWorkbenchContribution {
if (Object.keys(tags).length) {
/* __GDPR__
"workspace.azure" : {
"owner": "lramos15",
"${include}": [
"${AzureTags}"
]

1
src/vs/workbench/contrib/terminal/browser/terminalTypeAheadAddon.ts
View file

@ -1411,6 +1411,7 @@ export class TypeAheadAddon extends Disposable implements ITerminalAddon {
private _sendLatencyStats(stats: PredictionStats) {
/* __GDPR__
"terminalLatencyStats" : {
"owner": "Tyriar",
"min" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true },
"max" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true },
"median" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true },

4
src/vs/workbench/contrib/watermark/browser/watermark.ts
View file

@ -181,7 +181,9 @@ export class WatermarkContribution extends Disposable implements IWorkbenchContr
this.handleEditorPartSize(container, this.editorGroupsService.contentDimension);
/* __GDPR__
"watermark:open" : { }
"watermark:open" : {
"owner": "digitarald"
}
*/
this.telemetryService.publicLog('watermark:open');
}

1
src/vs/workbench/services/extensions/electron-sandbox/electronExtensionService.ts
View file

@ -612,6 +612,7 @@ export abstract class ElectronExtensionService extends AbstractExtensionService
const sendTelemetry = (userReaction: 'install' | 'enable' | 'cancel') => {
/* __GDPR__
"remoteExtensionRecommendations:popup" : {
"owner": "sandy081",
"userReaction" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
"extensionId": { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" }
}

1
src/vs/workbench/services/timer/browser/timerService.ts
View file

@ -514,6 +514,7 @@ export abstract class AbstractTimerService implements ITimerService {
// report IStartupMetrics as telemetry
/* __GDPR__
"startupTimeVaried" : {
"owner": "jrieken",
"${include}": [
"${IStartupMetrics}"
]