development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 04:49:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

no longer call /user to verify tokens

Browse source
This commit is contained in:
Tyler Leonhardt 2021-08-03 14:50:00 -07:00
parent 2be9d3f7e0
commit 37a8fe959c
No known key found for this signature in database
GPG key ID: 1BC2B6244363E77E
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
extensions/github-authentication/src/github.ts
View file

@ -45,7 +45,7 @@ export class GitHubAuthenticationProvider implements vscode.AuthenticationProvid
this._githubServer = new GitHubServer(type, this._telemetryReporter);
// Contains the current state of the sessions we have available.
this._sessionsPromise = this.readAndVerifySessions(true);
this._sessionsPromise = this.readSessions();
const friendlyName = this.type === AuthProviderType.github ? 'GitHub' : 'GitHub Enterprise';
this._disposable = vscode.Disposable.from(
@ -87,7 +87,7 @@ export class GitHubAuthenticationProvider implements vscode.AuthenticationProvid
private async checkForUpdates() {
const previousSessions = await this._sessionsPromise;
this._sessionsPromise = this.readAndVerifySessions(false);
this._sessionsPromise = this.readSessions();
const storedSessions = await this._sessionsPromise;
const added: vscode.AuthenticationSession[] = [];
@ -116,7 +116,7 @@ export class GitHubAuthenticationProvider implements vscode.AuthenticationProvid
}
}
private async readAndVerifySessions(force: boolean): Promise<vscode.AuthenticationSession[]> {
private async readSessions(): Promise<vscode.AuthenticationSession[]> {
let sessionData: SessionData[];
try {
Logger.info('Reading sessions from keychain...');
@ -139,7 +139,7 @@ export class GitHubAuthenticationProvider implements vscode.AuthenticationProvid
const sessionPromises = sessionData.map(async (session: SessionData) => {
let userInfo: { id: string, accountName: string } | undefined;
if (force || !session.account) {
if (!session.account) {
try {
userInfo = await this._githubServer.getUserInfo(session.accessToken);
setTimeout(() => this.afterTokenLoad(session.accessToken), 1000);
@ -152,6 +152,8 @@ export class GitHubAuthenticationProvider implements vscode.AuthenticationProvid
}
}
setTimeout(() => this.afterTokenLoad(session.accessToken), 1000);
Logger.trace(`Read the following session from the keychain with the following scopes: ${session.scopes}`);
return {
id: session.id,