Commit graph

240 commits

Author SHA1 Message Date
Logan Ramos ecc7fdac90
Bump extension telemetry module 2021-08-27 11:29:48 -04:00
Tyler Leonhardt 520fa49e68
refactor github auth to be a bit simpler. Remove PAT for GitHub auth since Settings Sync doesn't allow for it and add timeout so that GitHub Auth is not stuck. 2021-08-16 16:34:21 -07:00
Logan Ramos da7d76d2ec
Update extension telemetry module 2021-08-10 12:43:41 -04:00
Logan Ramos 6aa5b9226b
Update extension telemetry module 2021-08-09 13:16:08 -04:00
Tyler Leonhardt a8332b75e4
delete extra afterTokenLoad 2021-08-03 16:24:28 -07:00
Tyler Leonhardt 37a8fe959c
no longer call /user to verify tokens 2021-08-03 14:50:07 -07:00
Logan Ramos 9350fa3c9d
Bump telemetry module to fix packaging 2021-08-02 14:29:37 -04:00
Logan Ramos b7a07daa5a
Fix #129727 2021-08-02 13:04:26 -04:00
Logan Ramos 87e0cb1d43
Fix #129474 2021-07-29 11:39:03 -04:00
Logan Ramos c8e6d08e3a
Update to the latest extension module 2021-07-26 13:44:43 -04:00
Tyler Leonhardt c7e45c4fa4
Add a bunch of logging to github-authentication
Co-authored-by: Eric Amodio <eamodio@users.noreply.github.com>
2021-07-23 15:28:06 -07:00
Tyler Leonhardt c1b4cf00b9
update auth extensions to use packageJSON property instead 2021-07-23 11:48:39 -07:00
Tyler Leonhardt 8a4ace6ebf
maintain promise instead in github-auth to ensure the exp service doesn't get created twice 2021-07-23 09:24:40 -07:00
Tyler Leonhardt a8134002cd
lazily load experimentation service in github-authentication 2021-07-23 09:07:41 -07:00
Tyler Leonhardt 54a2e15f6b
remove unused variable 2021-07-22 17:40:13 -07:00
Tyler Leonhardt 3ed425bef9
Rework github authentication extension to make less HTTP requests.
Co-authored-by: Eric Amodio <eamodio@users.noreply.github.com>
2021-07-22 17:25:59 -07:00
VocalTrance 715798221b
Fix typo in github-authentication/github.ts (#129100) 2021-07-21 06:30:45 -07:00
Martin Aeschlimann 7ded90e452
Merge branch 'main' into joh/webpack5 2021-07-09 09:50:10 +02:00
Tyler James Leonhardt 87d692b7bf
Add scopes property to login telemetry (#128261)
* Add scopes property to login telemetry
2021-07-08 21:48:44 -07:00
Martin Aeschlimann 7ebe6a6054
adopt web extensions to webpack 5 2021-07-08 21:41:03 +02:00
Tyler Leonhardt e09ee35542
add useful readmes for the auth providers fixes #127688 fixes #127689 2021-07-06 15:43:59 -07:00
Tyler Leonhardt 1d1b9961d7
sort scopes on filter for getSessions in the github auth provider. Fixes https://github.com/github/codespaces/issues/3109 2021-06-30 10:15:24 -07:00
Tyler Leonhardt 6b6be7efe1
just return if the acceptedStates don't match fixes #126084 2021-06-28 17:12:06 -07:00
Tyler Leonhardt 4a011b5297
add additional logging around github auth 2021-06-28 16:27:52 -07:00
Kai Maetzel c200dc4909
fix isNoCorsEnvironment (#126718) 2021-06-18 17:36:59 -07:00
Pavel Kulyov cf7c86de97
extensions/github-authentication: fix typo (#126072)
Closes: #125468
2021-06-11 18:45:33 +00:00
Oleg Demchenko 61f34055fa
Auth session API fix (#125792)
* Adjust "provider is not registered" exception behavior

* Process cancellation in GH auth provider

`e.message` is always `undefined`
2021-06-10 20:14:08 +00:00
Matvii Hodovaniuk 67561036cf
Replace map with forEach (#115378)
The callback provided to the map call on this array should return a value, otherwise map will always return an array of undefined values. If the desired behaviour is to just iterate through all elements, then consider using forEach or a for-of loop instead.
2021-06-07 11:01:10 -07:00
Tyler Leonhardt e0c8a76b7a
don't sort scope list. Fixes Microsoft/vscode-pull-request-github#2751 2021-05-27 16:45:59 -07:00
João Moreno 0637663fcf
fix isNoCorsEnvironment 2021-05-27 11:45:12 +02:00
João Moreno 25a12c75c5
use dummy uri 2021-05-19 20:40:07 +02:00
Benjamin Pasero 159479eb5a
Allow to show status bar entries with an id and name (fix #74972) 2021-05-19 14:03:37 +02:00
Kevin Abel 4978a1891e
Implement GitHub Enterprise authn provider (#115940) 2021-05-07 14:13:11 -07:00
Robo bce4d71f64
chore: bump node@14.x in devDependencies (#122905) 2021-05-04 10:04:13 +02:00
João Moreno 87a33e998d
disable edu telemetry on nocors 2021-04-27 16:03:57 +02:00
Sandeep Somavarapu ac151b40a5
enable virtual workspace capability 2021-04-23 10:20:23 +02:00
SteVen Batten f9fc28d47d update ext manifest schema validation and built-in exts 2021-04-21 11:54:42 -07:00
João Moreno 034157dea8
gh auth: back to prod auth 2021-04-21 15:00:24 +02:00
João Moreno d60dbbf646
gh auth: fetch json 2021-04-21 10:48:01 +02:00
João Moreno 3668a573ad
gh auth: fix staging server selection 2021-04-21 10:06:26 +02:00
João Moreno 820e70a460
gh auth: don't reach out to product.json 2021-04-21 09:31:06 +02:00
Rachel Macfarlane c67ac5d083
Remove path from github-authentication 2021-04-20 16:49:23 -07:00
João Moreno 7b23ff442e
more staging detection (#121769)
* more staging detection

* check for scheme
2021-04-20 13:19:06 -07:00
João Moreno ad3e7ea1c0
gh auth: look at staging query param (#121768) 2021-04-20 13:04:56 -07:00
Miguel Solorio ac48f78dd6
Add icons for built-in extensions (fixes #81760) 2021-04-20 12:09:24 -07:00
Rachel Macfarlane 94589129a2
Add experimentation service to github auth extension 2021-04-20 09:25:01 -07:00
Rachel Macfarlane 296c417c07
Add workspace trust property to auth extensions 2021-04-15 09:22:15 -07:00
João Moreno a09d640311
github auth: improve test env detection
cc @RMacfarlane
2021-04-14 08:59:55 +02:00
Matt Bierner 119581fc2a
Use more standard name for shared extension tsconfig
This enables Intellisense in the `tsconfig.base` file
2021-04-12 15:58:38 -07:00
SteVen Batten 9c00242866 updating telemetry module for built-in exts 2021-03-22 16:28:08 -07:00
Rachel Macfarlane 5b5dd90655 Fix manually providing PAT for GitHub auth, fixes #118675 2021-03-10 14:48:33 -08:00
Sandeep Somavarapu bc62648b05 Revert "Remove authentication provider package.json declaration"
This reverts commit 811dc8d45a.
2021-03-05 14:02:57 +01:00
Rachel Macfarlane 811dc8d45a Remove authentication provider package.json declaration 2021-03-01 14:11:26 -08:00
Rachel Macfarlane 6a6b9a5cc8 Possible fix for #115918 2021-02-22 15:44:38 -08:00
Rachel Macfarlane 78707e2d79 Fix #117098 2021-02-19 14:57:06 -08:00
Rachel Macfarlane 4e19a9f16a Update telemetry classification type for isEdu check 2021-02-17 11:36:29 -08:00
Ladislau Szomoru 992cf6bd44
Update node-fetch (#116560) 2021-02-13 10:28:08 +01:00
Rachel Macfarlane 2f277cb41e Add github session telemetry event 2021-02-12 15:39:04 -08:00
Rachel Macfarlane 14669c2e45 Make scopes parameter optional to getSessions and remove getAllSessions 2021-02-12 09:13:11 -08:00
Rachel Macfarlane eceff53351 Rename login/logout to createSession/removeSession 2021-02-11 16:46:47 -08:00
Rachel Macfarlane 650906c369 Pass scopes through to authentication providers 2021-02-11 14:15:36 -08:00
Rachel Macfarlane 9118a3461c Make onDidChangeSessions event for auth providers fire complete session 2021-02-11 10:14:28 -08:00
João Moreno ec805db5ed
add repository field to extensions package.json 2021-01-29 15:30:45 +01:00
Rachel Macfarlane 93ae815ba1 Feedback on secrets API #112249 2021-01-20 09:24:48 -08:00
Rachel Macfarlane c85297669e Move id, label, and options to authentication provider registration 2021-01-11 10:53:17 -08:00
Rachel Macfarlane ced3bb4bb9 Secrets API feedback 2021-01-05 10:17:05 -08:00
Rachel Macfarlane 998e5e2ea6 onDidChangePassword -> onDidChange in secrets API 2021-01-04 22:20:07 -08:00
Rachel Macfarlane 7db413d4c1 Move secrets API to extension context 2021-01-04 22:04:40 -08:00
Alexandru Dima f74ad9692f
Align @types/* dev dependencies (#112718) 2020-12-18 13:28:39 +01:00
Alexandru Dima 65c59b509b
Merge pull request #112798 from microsoft/alex/node-modules-types-keytar
Use the root typings for keytar since we are loading the root node module
2020-12-18 10:56:01 +01:00
Alexandru Dima aa2864d53f
Remove most of the yarn license warnings 2020-12-18 10:26:14 +01:00
Alexandru Dima 2dd359c715
Use the root typings for keytar since we are loading the root node module (#112718) 2020-12-18 09:39:10 +01:00
Alexandru Dima e0498f0cdd
Share typescript node module (#112718) 2020-12-17 20:58:11 +01:00
Rachel Macfarlane 03c38e6702 Add more logging to github auth provider 2020-11-06 15:10:09 -08:00
Rachel Macfarlane 4059ff428f Allow cancelling GitHub sign in, fixes #109101 2020-11-05 16:39:25 -08:00
Alex Ross 04863391e9
Fix scope checking mismatch (#109665) 2020-10-29 17:05:21 -07:00
Rachel Macfarlane 928e79f838 Verify GitHub tokens on auth provider start, fixes #108680 2020-10-26 16:01:58 -07:00
Rachel Macfarlane 102e0e6d84 Handle incomplete login requests gracefully, fixes #109102 2020-10-23 09:45:50 -07:00
Rachel Macfarlane 31419adc34 Polish onDidChangePassword changes 2020-10-12 10:31:16 -07:00
Rachel Macfarlane 4c0811c9c2 Removing polling from auth extensions, fixes #107480 2020-10-09 16:33:53 -07:00
Rachel Macfarlane 64d64c70ff Check token scopes for manually provided tokens 2020-10-06 16:16:57 -07:00
Rachel Macfarlane dafce599a6
Add getPassword, setPassword, and deletePassword APIs, #95475
Co-authored-by: SteVen Batten <sbatten@microsoft.com>
2020-10-06 14:57:16 -07:00
Matt Bierner 50cc1d0e97 Update to use TS 4.1 for building VS Code 2020-09-16 11:58:01 -07:00
Rachel Macfarlane 8eb9cdaba9 Fix #105955, make sure auth provider registration completes when getSession is called 2020-09-02 11:51:59 -07:00
Rachel Macfarlane 650197b991 Add authentication contribution point, #103507 2020-08-27 11:51:18 -07:00
Rachel Macfarlane 8871a28963 Make github-authentication a UI extension again 2020-08-26 09:01:42 -07:00
Matt Bierner 8ba70d8bdc Revert "Make github-authentication a UI extension again"
This reverts commit cd55420e7e.

This change seems to have caused issues activating extensions
2020-08-24 20:19:58 -07:00
Rachel Macfarlane cd55420e7e Make github-authentication a UI extension again 2020-08-24 18:44:14 -07:00
Rachel Macfarlane 3f392ec5a3 Revert github-authentication extensionKind 2020-08-24 10:45:39 -07:00
Rachel Macfarlane cc29a81447 Update github authentication extension kind 2020-08-14 10:12:59 -07:00
Rachel Macfarlane 1961260ef3 Update github token input prompt 2020-08-05 13:37:06 -07:00
Rachel Macfarlane 12f63d9c66 Stabilize authentication consumer side, fixes #100993 2020-07-28 09:58:16 -07:00
Alex Dima 91cdca1bdb
Do not ship unnecessary files with extensions 2020-07-24 13:57:51 +02:00
Rachel Macfarlane cd5b4a7c80 Emit activation event for auth providers when getSession is called 2020-07-20 14:23:14 -07:00
Rachel Macfarlane 1ac2178ed0 Show input box for PAT in test environments instead of doing auth flow 2020-07-17 10:46:48 -07:00
Rachel Macfarlane a155fcf762 Address feedback on auth provider API 2020-07-16 16:03:17 -07:00
Rachel Macfarlane 0a30c7a64d Add GDPR comments for auth provider telemetry 2020-07-08 11:22:21 -07:00
Rachel Macfarlane 348e2b4c6e displayName -> label, use providerIds in favor of getProviderIds, #100993 2020-07-06 18:23:12 -07:00
Rachel Macfarlane ab7a5ec3ad Address part of feedback for #100993 2020-07-06 08:51:24 -07:00
Martin Aeschlimann d0a272d025 use shared webpack config for browser 2020-06-25 23:30:00 +02:00
Rachel Macfarlane 629e1d7e16 Remove old getSessions and login methods from auth provider API 2020-06-24 15:33:09 -07:00
Martin Aeschlimann 917064c80c move polyfills to build/polyfills 2020-06-11 21:54:43 +02:00
Martin Aeschlimann e9c7969f93 add polyfills/** to vscodeignore 2020-06-11 10:18:39 +02:00
Eric Amodio 774c4baa8f Adapts extension to work on the web/serverless 2020-06-08 18:13:26 -04:00
Rachel Macfarlane d37370d89d Fix #96368 2020-06-01 10:11:06 -07:00
Rachel Macfarlane 4e15a24678 Support directly entering PAT for github auth as well as entering url 2020-06-01 09:49:13 -07:00
Rachel Macfarlane a79822ac0a Remove old auth provider migration code 2020-05-28 12:55:52 -07:00
Rachel Macfarlane a6c47beb1b Remove unused code in github auth provider 2020-05-27 09:37:54 -07:00
Rachel Macfarlane 87b0c54586 Make AuthenticationSession a class and remove getAccessToken method, fixes #91554 2020-05-15 14:34:04 -07:00
Rachel Macfarlane cbb0b04d7d Add supportsMultipleAccounts to auth providers 2020-05-11 18:32:36 -07:00
Rachel Macfarlane 11ec8269ed Pass correct host for VSO token 2020-04-28 15:17:22 -07:00
Rachel Macfarlane a1a98d07da Fix github authentication in the web, fixes #96406 2020-04-28 14:00:41 -07:00
Rachel Macfarlane b05b32bfd8 Use github auth server for provider 2020-04-27 08:10:46 -07:00
Rachel Macfarlane badd41f04a Better error handling in github auth provider 2020-04-23 12:16:33 -07:00
Rachel Macfarlane 2e5312cd61 Add account id to authentication session object 2020-04-22 18:00:16 -07:00
Rachel Macfarlane 8fdb90a496 Add .vscodeignore file to github auth extension 2020-04-21 12:13:23 -07:00
Rachel Macfarlane fd88fb9667 Await keychain write on logout for github auth 2020-04-21 11:16:45 -07:00
Rachel Macfarlane b665721d95 Try downgrading vscode-extension-telemetry package 2020-04-16 22:50:48 -07:00
Rachel Macfarlane 87287d0275 Code cleanup, remove stuff related to sign in commands 2020-04-16 19:29:56 -07:00
Rachel Macfarlane c63a842f00 Add basic telemetry to auth providers 2020-04-16 11:59:07 -07:00
Rachel Macfarlane 1b9a442590 Move github config generation to own build step 2020-04-14 22:59:08 -07:00
Rachel Macfarlane 061f4967f9 Show sign in entry for all auth providers in accounts menu, fixes #94488 2020-04-13 14:28:07 -07:00
Rachel Macfarlane 917c420302 Improvements to 'manage trusted extensions' flow 2020-04-01 23:13:50 -07:00
Rachel Macfarlane 852df3025d Revert "Issue distinct sessions per extension, remove session when extension is removed from trusted list"
This reverts commit 85119afc7b.
2020-03-30 17:03:29 -07:00
Rachel Macfarlane 85119afc7b Issue distinct sessions per extension, remove session when extension is removed from trusted list 2020-03-30 14:34:42 -07:00
Rachel Macfarlane 7ca13ca33b Github auth provider - revoke token on logout 2020-03-28 08:15:30 -07:00
Rachel Macfarlane ab91532466 Add 'manage trusted extensions' option to account quickpick, #90385 2020-03-27 15:38:53 -07:00
Rachel Macfarlane 8c50263c35 Show notification when writing to keychain fails, #92972 2020-03-25 16:25:44 -07:00
Rachel Macfarlane d9d90a0d3d Use GitHub app for VSO, closes #92675 2020-03-23 07:52:22 -07:00
Rachel Macfarlane d21cadb83f Use fs to read github auth config file 2020-03-23 07:52:22 -07:00
Rachel Macfarlane 2b86488f03 Add account context menu, #90385 2020-03-20 09:51:35 -07:00
Christof Marti 1f720ae43a Revert "Only write config file during postinstall if process env variables are present (#91793)"
This reverts commit b2b488fa43.
2020-03-06 11:34:06 +01:00
Rachel Macfarlane b2b488fa43
Only write config file during postinstall if process env variables are present (#91793) 2020-03-02 12:45:33 -08:00
Rachel Macfarlane eee9122c87 accessToken -> getAccessToken, fixes #91570 2020-02-26 15:25:01 -08:00
Rachel Macfarlane 7a13028b70 Lowercase auth provider ids, fixes #91538 2020-02-26 15:06:53 -08:00
Rachel Macfarlane 858457d2e6 Fix rehydrating of GitHub auth provider data 2020-02-25 10:38:42 -08:00
Rachel Macfarlane bf0a32e729 Add support for other vscode environments for github auth 2020-02-24 11:14:11 -08:00
Joao Moreno cc5dd0c98b refactor build 2020-02-21 15:30:01 +01:00
Rachel Macfarlane 167c422e4b Handle no github auth config 2020-02-20 14:38:10 -08:00
Rachel Macfarlane eed39324b6
Add GitHub authentication provider extension, closes #90384 2020-02-20 10:56:16 -08:00