development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 04:49:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

have code-oss use device code flow

Browse source
This commit is contained in:
Tyler Leonhardt 2022-03-28 09:05:19 -07:00
parent 67ed9421c5
commit b1fb11e18c
No known key found for this signature in database
GPG key ID: 1BC2B6244363E77E
2 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
extensions/github-authentication/src/common/env.ts
View file

@ -7,7 +7,11 @@ import { Uri } from 'vscode';
const VALID_DESKTOP_CALLBACK_SCHEMES = [
'vscode',
'vscode-insiders',
'code-oss',
// On Windows, some browsers don't seem to redirect back to OSS properly.
// As a result, you get stuck in the auth flow. We exclude this from the
// list until we can figure out a way to fix this behavior in browsers.
// The behavior was experienced on Windows.
// 'code-oss',
'vscode-wsl',
'vscode-exploration'
];

4
extensions/github-authentication/src/github.ts
View file

@ -45,7 +45,9 @@ export class GitHubAuthenticationProvider implements vscode.AuthenticationProvid
if (this.type === AuthProviderType.github) {
this._githubServer = new GitHubServer(
// We only can use the Device Code flow when we are running with a remote extension host.
context.extension.extensionKind === vscode.ExtensionKind.Workspace,
context.extension.extensionKind === vscode.ExtensionKind.Workspace
// This should only matter when we are running in code-oss. See the other change in this commit.
|| vscode.env.uiKind === vscode.UIKind.Desktop,
this._logger,
this._telemetryReporter);
} else {