Commit graph

586 commits

Author SHA1 Message Date
Ryan Macnak 1ebeb79942 Remove runtime 'dart_app' as it became identical to 'vm'.
Merge compiler 'dart2app' and 'dart2appjit' and rename to 'app_jit' since they came to mean the same thing.

Update status files to reflect these changes.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2541533004 .
2016-12-01 16:47:33 -08:00
William Hesse 6f7005ee71 Update status for co19 tests on browsers.
BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org/2538443002 .
2016-11-28 16:32:41 +01:00
Erik Ernst 4912fd1501 Make initializing formal access available by default
This CL changes dart2js such that the effect that we used to get with
option '--initializing-formal-access' is now obtained unconditionally,
i.e., that extension is now enabled by default.

dart2js will continue to accept the option, such that scripts passing
the option will not break.

The CL is _not_ intended to be landed at this time, the plan is to
enable the feature in a coordinated manner when all tools are ready.

R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/2141023002 .
2016-11-25 10:15:21 +01:00
Ryan Macnak 12de13d1ae An isolate created with spawn function doesn't necessarily agree with its parent on the library private keys.
(The long-standing issue that spawn function should use snapshots would also fix this.)

Encountered by the analyzer in https://codereview.chromium.org/2492933002/

BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/2509413002 .
2016-11-23 15:36:01 -08:00
Johnni Winther 03bf746918 Remove static clues from spawn_uri_child_isolate.dart
- the tests should be able to work without it.

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2497293003 .
2016-11-15 13:19:29 +01:00
Sigmund Cherem 2bec7b5adb Skip package-resolution tests in dartium
TBR=lrn@google.com

Review URL: https://codereview.chromium.org/2500203002 .
2016-11-14 15:18:47 -08:00
Sigmund Cherem f460a8706d Add implementation of Isolate.resolvePackageUri for dart2js.
This uses 'packages/' as the default base to resolve uris from, but also exposes
a hook to allow users to overwrite it.

BUG= https://github.com/dart-lang/sdk/issues/25594
R=het@google.com, lrn@google.com

Review URL: https://codereview.chromium.org/2495383003 .
2016-11-14 15:11:49 -08:00
Florian Schneider a74262c0e9 Enable now-passing tests for Android precompilation
Remove other obsolete entries.

Fixes #26373.
Fixes #27378.

R=rmacnak@google.com, whesse@google.com

Review URL: https://codereview.chromium.org/2431163007 .
2016-10-21 12:16:47 -07:00
Sigmund Cherem f6680d13a2 One more round of status file updates to get the bots green.
TBR=sra@google.com

Review URL: https://codereview.chromium.org/2285213003 .
2016-08-29 08:14:33 -07:00
Sigmund Cherem 342eb3f296 Additional status file fixes
TBR=sra@google.com

Review URL: https://codereview.chromium.org/2283273002 .
2016-08-26 18:29:19 -07:00
Sigmund Cherem 13a090a879 More status fixes
TBR=sra@google.com,het@google.com

Review URL: https://codereview.chromium.org/2280193002 .
2016-08-26 13:46:14 -07:00
Sigmund Cherem fc0bf7a85b First set of test triage for fast-startup
Review URL: https://codereview.chromium.org/2285823002 .
2016-08-26 10:04:41 -07:00
Florian Schneider 021ebb2033 Correct and GC unrecognized flags from our tests.
Fix some misspelled flags.

Remove some non-existent flags.

Fix --short_socket_read and --short_socket_write flags used in IO tests.

Running with --ignore-unrecognized-flags is still on because some flags are only visible
in DEBUG mode.

BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/2247733005 .
2016-08-15 18:28:11 -07:00
John McCutchan 268082769b Initial status file updates for $hot_reload_rollback
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2207653002 .
2016-08-02 11:03:44 -07:00
John McCutchan f79756b88d Hot reload status file updates
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2164063002 .
2016-07-20 11:02:23 -07:00
John McCutchan 7fa9393105 Remove windows debug print and trace shutdown on some tests
BUG=

Review URL: https://codereview.chromium.org/2153813003 .
2016-07-15 14:53:54 -07:00
John McCutchan c692a64e5a Rework how enums are implemented and reloaded
- Enum instances now hold their index and their label. Before the labels were held in a static array to the side and the index was used to look up the label.

- Before and after reload enum instances are now paired (by label) and put into the 'become' table.

Fixes https://github.com/dart-lang/sdk/issues/26877

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2153143002 .
2016-07-15 10:52:20 -07:00
John McCutchan 6c27b6e381 Tweak for hot reload status file
Enum identity tests can sometimes pass.

BUG=

Review URL: https://codereview.chromium.org/2147183003 .
2016-07-14 07:56:56 -07:00
John McCutchan c6141005a9 More status file updates for hot reload
BUG=

Review URL: https://codereview.chromium.org/2151743003 .
2016-07-14 07:14:25 -07:00
Todd Turnidge 77b99396e8 Disallow deferred loading when using isolate reloading.
Update status files.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2144113002 .
2016-07-13 15:25:06 -07:00
John McCutchan 04dc67e2b3 More hot reload status file updates
BUG=

Review URL: https://codereview.chromium.org/2143213002 .
2016-07-12 13:54:16 -07:00
John McCutchan 24a0988df6 Hot reload fixes for isolate tests
- [x] Bump maximum number of vm arguments (fixes a bunch of reload crashes....)
- [x] Only check that an isolate has reload if it was ever runnable.
- [x] Skip some isolate tests that use deferred libraries or are checking for closure identity.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2141763002 .
2016-07-11 13:58:26 -07:00
Lasse R.H. Nielsen 191ab42d64 Make VM resolvePackageUri fail on package:foo and package:/foo.
R=asiva@google.com, floitsch@google.com

Committed: eb49613cbf

Review URL: https://codereview.chromium.org/1998603002 .
2016-06-14 12:22:15 +02:00
Ryan Macnak ef8baa8760 Add test harness option for app snapshots with unoptimized code.
./tools/test.py -m all -c dart2appjit -r dart_app --use-blobs

Rename 'dart_product' runtime to 'dart_app'.

Rename Dart_PrecompiledJITSnapshotBlob to Dart_CreateAppJITSnapshot and add documentation.

Remove out-of-date scripts in tools/precompilation.

R=fschneider@google.com

Review URL: https://codereview.chromium.org/1992703005 .
2016-05-26 10:37:47 -07:00
Ryan Macnak 7d3cd143f7 Update status for
./tools/test.py -mall
  ./tools/test.py -mdebug,release --checked
  ./tools/test.py -mrelease,product -cdart2app -rdart_product
  ./tools/test.py -mrelease --checked -cdart2app -rdart_product

Missing
  ./tools/test.py -mdebug -cdart2app -rdart_product
  ./tools/test.py -mdebug --checked -cdart2app -rdart_product

R=asiva@google.com

Review URL: https://codereview.chromium.org/1991543002 .
2016-05-18 12:54:34 -07:00
Florian Schneider b349c2cbd6 Temporarily update test status for Android
BUG=
R=kustermann@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/1924833003 .
2016-05-02 11:19:43 +02:00
Ivan Posva 3b2a695d71 - Properly return null if an unknown package is resolved.
- Allow short form package:foo imports.

R=asiva@google.com

Review URL: https://codereview.chromium.org/1822863002 .
2016-03-22 09:02:04 -07:00
Sigmund Cherem 385f3350c5 Update status of cpsir tests in checked mode: skipping for now, since more than
75% fail for one reason, once we fix that we can triage in more detail.

Review URL: https://codereview.chromium.org/1771893002 .
2016-03-07 10:20:41 -08:00
Ryan Macnak e880063e88 Include the canonical static closure when serializing ClosureData.
BUG=http://dartbug.com/25892
R=asiva@google.com

Review URL: https://codereview.chromium.org/1771483002 .
2016-03-07 09:06:26 -08:00
Ryan Macnak 167616b83e Skip mirror tests more generally for $mode == product instead of $runtime == dart_product.
Reduces failures in tools/test.py -mproduct.

R=asiva@google.com

Review URL: https://codereview.chromium.org/1760043002 .
2016-03-03 10:06:59 -08:00
Ryan Macnak 3fd5ffdbd4 Make tools/build.py -cprecompiler -rdart_precompiled green:
- Create a separate compilation output directory for each VMOptions varient so they can run in parallel.
- Run both the snapshotter and assembler from the test harness instead of a wrapper script so crashes in the snapshotter are correctly identified by the test harness.
- Delete the assembly source for the precompiled shared library as we go to limit space required to run the test suite (now 61GB for X64 release).
- Remove the VMOption --optimization-counter-threshold in when running precompilation tests.
- Don't look at a library prefix's import list during load(), it was removed by tree-shaking.
- Trace types of TypeParameters.
- Trace types of a Function's owner and parent.
- Update status file for remaining 4 failures under http://dartbug.com/25892.

R=fschneider@google.com

Review URL: https://codereview.chromium.org/1732323005 .
2016-03-01 15:19:11 -08:00
Siva Annamalai 5c53e14d55 - Skip tests which use dart:mirrors in product mode
Review URL: https://codereview.chromium.org/1728663002 .
2016-02-24 18:13:20 -08:00
Siva Annamalai 809c205cae - Fix --run-fullsnapshot flag processing issue in non product mode.
- Adjust status files for product mode issues (Process.run, SpawnUri,
  test expecting line numbers)

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1720193002 .
2016-02-22 15:33:34 -08:00
William Hesse 270ad3f552 Remove ContentShellOnAndroid from status files
Dartium and content_shell are no longer built or tested on Android.
A separate issue is filed to remove support from the test scripts:
https://github.com/dart-lang/sdk/issues/25832

BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org/1720813002 .
2016-02-22 10:20:22 +01:00
Siva Annamalai 64a5845d19 Fix status files to account for dart_product runtime.
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1688423002 .
2016-02-17 12:22:35 -08:00
Todd Turnidge be3acab294 Use Stopwatch instead of DateTime to measure elapsed time in tests.
Improve timer_repeat_test.dart to not totally punt on testing the timing.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/1683233003 .
2016-02-10 11:21:40 -08:00
Asger Feldthaus aba2e1ea99 dart2js cps: Fix bug in pulling of assignments into a var.
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/1609943002 .
2016-01-19 16:55:45 -08:00
Ivan Posva 4f54e6aee5 - Add support for passing data: based URIs as packageConfig to
Isolate.spawnUri.
- Loosen the expected mimeType and encoding for data: URI based
  file loading.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1585103006 .
2016-01-15 17:01:58 -08:00
Ivan Posva b2a186c2dd - Readjust Dartium status files.
BUG=

Review URL: https://codereview.chromium.org/1591063002 .
2016-01-15 11:22:24 -08:00
Ivan Posva 7b75f2dbb7 - Allow specifying of package: URIs for packageConfig and packageRoot when
spawning a new isolate.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1586653003 .
2016-01-14 08:20:59 -08:00
Ivan Posva b508064e9e - Further updates of status files for Dartium.
BUG=

Review URL: https://codereview.chromium.org/1582913002 .
2016-01-13 09:17:17 -08:00
Ivan Posva 8741a8dcda - Update status files.
BUG=

Review URL: https://codereview.chromium.org/1579213003 .
2016-01-13 01:39:40 -08:00
Ivan Posva ca40bd9233 Fix build:
- Update status files.

BUG=

Review URL: https://codereview.chromium.org/1580353002 .
2016-01-12 21:06:27 -08:00
Ivan Posva d3b2afc6e0 Fix static warning in test:
- Remove void type from async function.

BUG=

Review URL: https://codereview.chromium.org/1585503003 .
2016-01-12 19:27:39 -08:00
Ivan Posva cf502e87f4 - Add packages directory missed by .gitignore file.
BUG=

Review URL: https://codereview.chromium.org/1588453002 .
2016-01-12 19:18:11 -08:00
Ivan Posva 6d066c7e53 Add package config support to dart:isolate
- Add "static Future<Uri> get packageRoot;",
  "static Future<Uri> get packageConfig;" and
  "static Future<Uri> resolvePackageUri(Uri packageUri)" to Isolate class.
- Added "Uri packageRoot, Uri packageConfig, bool automaticPackageResolution: false" parameters to spawnUri.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1553233002 .
2016-01-12 18:19:04 -08:00
Asger Feldthaus e876b9aba9 dart2js cps: Update status files.
BUG=

Review URL: https://codereview.chromium.org/1563183005 .
2016-01-07 12:07:25 -08:00
Sigmund Cherem c10c55bb92 cpsir: update status files
Review URL: https://codereview.chromium.org/1563833003 .
2016-01-06 14:27:24 -08:00
Kevin Millikin 044b283a3c dart2js: Initial implementation of inlining.
Perform a depth-first postorder traversal of the call graph of known
functions.  Make an inlining decision based on the vector of argument
types at the call site, and cache inlining decisions.  For positive
inlining decisions, cache the optimized function body specialized to
the receiver and argument types at the call site.

Future work:
  * Real inlining heuristics.
  * Propagate result types of inlined calls.
  * Specialized for constant arguments when it makes sense.
  * Performance improvements.

R=asgerf@google.com, sra@google.com

Committed: d63053fea8

Review URL: https://codereview.chromium.org/1537663002 .
2015-12-23 10:12:19 +01:00
Kevin Millikin 75eb350abc Revert "dart2js: Initial implementation of inlining."
This reverts commit d63053fea8.

Reverted due to test failures for compiler expected output.  Those tests
need to be rebaselined to reflect the effects of inlining.

TBR=whesse@google.com
BUG=

Review URL: https://codereview.chromium.org/1542003003 .
2015-12-22 13:48:36 +01:00