Skip mirror tests more generally for $mode == product instead of $runtime == dart_product.

Reduces failures in tools/test.py -mproduct.

R=asiva@google.com

Review URL: https://codereview.chromium.org/1760043002 .
This commit is contained in:
Ryan Macnak 2016-03-03 10:06:59 -08:00
parent 8cd8d219ca
commit 167616b83e
7 changed files with 24 additions and 22 deletions

View file

@ -84,7 +84,7 @@ cc/CodeImmutability: Fail,OK # Address Sanitizer turns a crash into a failure.
[ $noopt ]
dart/byte_array_test: Crash # Incompatible flag --disable_alloc_stubs_after_gc
[ $noopt || $compiler == precompiler || $compiler == dart2app ]
[ $noopt || $compiler == precompiler || $mode == product ]
dart/redirection_type_shuffling_test: CompileTimeError # Imports dart:mirrors
[ $noopt || $runtime == dart_precompiled ]

View file

@ -142,8 +142,21 @@ Language/Errors_and_Warnings/static_warning_t04: RuntimeError # co19 issue 45
Language/Errors_and_Warnings/static_warning_t05: RuntimeError # co19 issue 45
Language/Errors_and_Warnings/static_warning_t06: RuntimeError # co19 issue 45
[ $noopt || $compiler == precompiler ]
[ $noopt || $compiler == precompiler || $mode == product ]
Language/Metadata/*: SkipByDesign # Uses dart:mirrors
[ $runtime == dart_precompiled || $runtime == dart_product ]
LibTest/isolate/Isolate/spawnUri*: Skip # Isolate.spawnUri
[ $runtime == dart_precompiled ]
Language/Expressions/Constants/identifier_denotes_a_constant_t05: Crash # Issue 25892
Language/Expressions/Constants/static_method_t01: Crash # Issue 25892
[ $noopt || $compiler == precompiler ]
LibTest/collection/ListBase/ListBase_class_A01_t02: Pass, Timeout
LibTest/collection/ListMixin/ListMixin_class_A01_t02: Pass, Timeout
LibTest/core/Map/Map_class_A01_t04: Pass, Timeout
LibTest/core/Uri/encodeQueryComponent_A01_t02: Pass, Timeout
LibTest/collection/ListBase/ListBase_class_A01_t02: Pass, Timeout
LibTest/collection/ListMixin/ListMixin_class_A01_t02: Pass, Timeout
LibTest/core/Map/Map_class_A01_t04: Pass, Timeout
@ -152,15 +165,6 @@ Language/Mixins/Mixin_Application/error_t01: Pass
Language/Mixins/Mixin_Application/error_t02: Pass
Language/Mixins/declaring_constructor_t01: Pass
[ $runtime == dart_precompiled ]
LibTest/isolate/Isolate/spawnUri*: RuntimeError # Isolate.spawnUri
Language/Expressions/Constants/identifier_denotes_a_constant_t05: Crash # Issue 25892
Language/Expressions/Constants/static_method_t01: Crash # Issue 25892
[ $runtime == dart_product ]
LibTest/isolate/Isolate/spawnUri*: Skip # Isolate.spawnUri
Language/Metadata/*: SkipByDesign # Uses dart:mirrors
[ $runtime == vm && $mode == product ]
LibTest/typed_data/Float32List/runtimeType_A01_t01: Fail,OK # Expects exact type name.
LibTest/typed_data/Float32x4List/runtimeType_A01_t01: Fail,OK # Expects exact type name.

View file

@ -192,8 +192,10 @@ package_resource_test: Crash # Issue 25911
stacktrace_current_test: Pass, RuntimeError
error_stack_trace1_test: Pass, RuntimeError
[ $noopt || $compiler == precompiler || $mode == product ]
apply3_test: SkipByDesign # Imports dart:mirrors
[ $noopt || $compiler == precompiler ]
apply3_test: CompileTimeError # Imports dart:mirrors
regexp/stack-overflow_test: RuntimeError, OK # Smaller limit with irregex interpreter
big_integer_huge_mul_vm_test: Pass, Timeout # --no_intrinsify
big_integer_parsed_mul_div_vm_test: Pass, Timeout # --no_intrinsify
@ -202,4 +204,3 @@ int_parse_radix_test: Pass, Timeout # --no_intrinsify
[ $runtime == dart_product ]
data_resource_test: Skip # Resolve URI not supported yet in product mode.
package_resource_test: Skip # Resolve URI not supported yet in product mode.
apply3_test: SkipByDesign # Imports dart:mirrors

View file

@ -139,7 +139,7 @@ package_resolve_test: SkipByDesign # Uses Isolate.resolvePackageUri
spawn_uri_fail_test: SkipByDesign # Uses dart:io.
scenarios/*: SkipByDesign # Use automatic package resolution, spawnFunction and .dart URIs.
[ $noopt || $compiler == precompiler || $runtime == dart_product ]
[ $noopt || $compiler == precompiler || $mode == product ]
# Imports dart:mirrors
count_test: SkipByDesign
cross_isolate_message_test: SkipByDesign

View file

@ -124,7 +124,7 @@ stacktrace_rethrow_error_test: Pass, RuntimeError
stacktrace_rethrow_nonerror_test: Pass, RuntimeError
stacktrace_test: Pass, RuntimeError
[ $noopt || $compiler == precompiler || $runtime == dart_product ]
[ $noopt || $compiler == precompiler || $mode == product ]
# Imports dart:mirrors
const_evaluation_test: SkipByDesign
deferred_constraints_constants_test: SkipByDesign

View file

@ -354,11 +354,9 @@ async/dart2js_uncaught_error_test: Skip # JS-integration only test
[ $noopt && $arch == simarm64 ]
async/slow_consumer2_test: Pass, RuntimeError # Issue 25726
[ $noopt || $compiler == precompiler ]
[ $noopt || $compiler == precompiler || $mode == product ]
mirrors/*: SkipByDesign
[ $noopt || $compiler == precompiler ]
convert/chunked_conversion_utf88_test: Pass, Timeout
convert/utf85_test: Pass, Timeout
[ $runtime == vm && $mode == product ]
mirrors/mirrors_reader_test: Fail,OK # Expects exact type name.

View file

@ -15,9 +15,8 @@ source_mirrors_test: Slow, Pass
[ ($compiler == none || $compiler == precompiler) && $runtime != vm ]
dart2js_test: SkipByDesign # Uses dart:io.
[ $compiler == dart2js && $mode == debug ]
dummy_compiler_test: Slow, Pass
[ $noopt || $compiler == precompiler || $compiler == dart2app ]
[ $noopt || $compiler == precompiler || $mode == product ]
source_mirrors_test: SkipByDesign # Imports dart:mirrors