Hot reload fixes for isolate tests

- [x] Bump maximum number of vm arguments (fixes a bunch of reload crashes....)
- [x] Only check that an isolate has reload if it was ever runnable.
- [x] Skip some isolate tests that use deferred libraries or are checking for closure identity.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2141763002 .
This commit is contained in:
John McCutchan 2016-07-11 13:58:26 -07:00
parent c706a355b1
commit 24a0988df6
4 changed files with 9 additions and 4 deletions

View file

@ -1624,7 +1624,7 @@ static Dart_GetVMServiceAssetsArchive GetVMServiceAssetsArchiveCallback = NULL;
void main(int argc, char** argv) {
char* script_name;
const int EXTRA_VM_ARGUMENTS = 2;
const int EXTRA_VM_ARGUMENTS = 8;
CommandLineOptions vm_options(argc + EXTRA_VM_ARGUMENTS);
CommandLineOptions dart_options(argc);
bool print_flags_seen = false;

View file

@ -1718,7 +1718,7 @@ void Isolate::Shutdown() {
}
}
if (FLAG_check_reloaded &&
if (FLAG_check_reloaded && is_runnable() &&
(this != Dart::vm_isolate()) &&
!ServiceIsolate::IsServiceIsolateDescendant(this)) {
if (!HasAttemptedReload()) {

View file

@ -207,3 +207,9 @@ issue_24243_parent_isolate_test: Skip # Requires checked mode
[ $compiler == precompiler && $runtime == dart_precompiled && $system == android ]
*: Skip # Issue #26373
[ $hot_reload ]
deferred_in_isolate_test: SkipByDesign # Requires deferred libraries
deferred_in_isolate2_test: SkipByDesign # Requires deferred libraries
function_send_test: SkipByDesign # Closure identity
issue_21398_parent_isolate2_test: SkipByDesign # Requires deferred libraries

View file

@ -377,7 +377,6 @@ convert/utf85_test: Pass, Timeout
mirrors/accessor_cache_overflow_test: Skip
[ $hot_reload ]
convert/chunked_conversion_utf88_test: Pass, Timeout
convert/streamed_conversion_json_utf8_decode_test: Fail, Crash
async/multiple_timer_test: Pass, Fail # Timing related
async/stream_transformer_test: SkipByDesign # Closure identity
mirrors/*: Skip # Issue 26836