languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 16:41:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

- Fix --run-fullsnapshot flag processing issue in non product mode.

Browse source 
- Adjust status files for product mode issues (Process.run, SpawnUri,
  test expecting line numbers)

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1720193002 .
This commit is contained in:
Siva Annamalai 2016-02-22 15:33:34 -08:00
parent 0c4e64c8ef
commit 809c205cae
6 changed files with 22 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
runtime/bin/main.cc
View file

@ -411,8 +411,10 @@ static bool ProcessRunFullSnapshotOption(
#ifndef DART_PRODUCT_BINARY
Log::PrintErr("Full Application snapshots can only be be run with"
" dart_product\n");
#endif
return false;
#else
return ProcessSnapshotOptionHelper(filename, &run_full_snapshot);
#endif // defined(DART_PRODUCT_BINARY)
}

6
runtime/tests/vm/vm.status
View file

@ -85,6 +85,12 @@ dart/byte_array_test: Crash # Incompatible flag --disable_alloc_stubs_after_gc
dart/redirection_type_shuffling_test: CompileTimeError # Imports dart:mirrors
dart/optimized_stacktrace_test: RuntimeError # Expects line and column numbers
[ $compiler == dart2app ]
dart/optimized_stacktrace_test: RuntimeError # Expects line and column numbers
[ $runtime == dart_product ]
dart/data_uri_spawn_test: Skip # Isolate.spawnUri
[ $runtime == dart_precompiled ]
dart/inline_stack_frame_test: Fail # Issue 24783 - inlined frames missing
dart/data_uri_spawn_test: RuntimeError # Isolate.spawnUri

2
samples/samples.status
View file

@ -24,5 +24,5 @@ sample_extension/test/sample_extension_test: Skip # Issue 14705
[ $arch == simarm64 ]
*: Skip
[ $noopt || $runtime == dart_precompiled ]
[ $noopt || $runtime == dart_precompiled || $runtime == dart_product ]
sample_extension: RuntimeError # Platform.executable

5
tests/co19/co19-runtime.status
View file

@ -154,9 +154,12 @@ Language/Mixins/declaring_constructor_t01: Pass
Language/Expressions/Property_Extraction/Named_Constructor_Extraction/deferred_type_t01: Pass
Language/Metadata/*: Skip # Uses dart:mirrors
[ $runtime == dart_precompiled || $runtime == dart_product ]
[ $runtime == dart_precompiled ]
LibTest/isolate/Isolate/spawnUri*: RuntimeError # Isolate.spawnUri
[ $runtime == dart_product ]
LibTest/isolate/Isolate/spawnUri*: Skip # Isolate.spawnUri
[ $runtime == vm && $mode == product ]
LibTest/typed_data/Float32List/runtimeType_A01_t01: Fail,OK # Expects exact type name.
LibTest/typed_data/Float32x4List/runtimeType_A01_t01: Fail,OK # Expects exact type name.

4
tests/corelib/corelib.status
View file

@ -190,3 +190,7 @@ regexp/stack-overflow_test: RuntimeError, OK # Smaller limit with irregex interp
big_integer_huge_mul_vm_test: Pass, Timeout # --no_intrinsify
big_integer_parsed_mul_div_vm_test: Pass, Timeout # --no_intrinsify
int_parse_radix_test: Pass, Timeout # --no_intrinsify
[ ($runtime == dart_product) ]
data_resource_test: Skip # Resolve URI not supported yet in product mode.
package_resource_test: Skip # Resolve URI not supported yet in product mode.

4
tests/isolate/isolate.status
View file

@ -176,3 +176,7 @@ spawn_uri_multi_test: Skip # Isolate.spawnUri
spawn_uri_vm_test: Skip # Isolate.spawnUri
issue_21398_parent_isolate_test: Skip # Isolate.spawnUri
error_at_spawnuri_test: Skip # Isolate.spawnUri
[ $runtime == dart_product ]
spawn_uri_missing_from_isolate_test: Skip # SpawnUri in product mode
spawn_uri_missing_test: Skip # SpawnUri in product mode