Commit graph

42486 commits

Author SHA1 Message Date
Martin Kustermann b1c04f0538 Avoid random stacktraces being printed from tools/test.py during test runs
Previously the testing script was just printing interleaved stack traces with
all the other output. Which means it's not associatable with a single test and
is highly confusing!

This CL associates the stack trace information of tests which time out to the
particular test which timed out.

R=whesse@google.com

Review URL: https://codereview.chromium.org/2524733004 .
2016-11-23 08:39:27 +01:00
Ryan Macnak 171da0489f Fuchsia sockets:
- Remove CheckConnect.
  - Enable NODELAY.
  - Add testSimpleReadWriteClose to hello_fuchsia_test.

Add stub implementation of OS::MaxRSS so Observatory can load without crashing the target VM.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2523133002 .
2016-11-22 16:52:21 -08:00
Paul Berry 05a6045674 Rename AstFactory -> AstTestFactory.
This paves the way for introducing a new AstFactory class that will be
part of the analyzer public API.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2524903002 .
2016-11-22 16:09:51 -08:00
Todd Turnidge 193ddba4db Revert "Implement rewind: drop one or more frames from the debugger."
This reverts commit af1875be91.

BUG=

Review URL: https://codereview.chromium.org/2521413002 .
2016-11-22 16:05:26 -08:00
Todd Turnidge af1875be91 Implement rewind: drop one or more frames from the debugger.
Not yet implemented on dbc.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2523053002 .
2016-11-22 15:26:08 -08:00
Paul Berry e9ebfd4b39 Disable test_import_short_absolute on Windows.
Fixes #27870

R=scheglov@google.com

Review URL: https://codereview.chromium.org/2522113002 .
2016-11-22 15:18:29 -08:00
Konstantin Shcheglov 7ec65fb9ca Fix for exception duirng indexing a reference to MultiplyDefinedElement.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2529433003 .
2016-11-22 15:03:41 -08:00
John McCutchan ea94a5dcb0 Don't pass --print_snapshot_sizes in product mode
BUG=

Review URL: https://codereview.chromium.org/2521323003 .
2016-11-22 14:47:05 -08:00
Stephen Adams 9e80530980 dart2js/kernel: Implement type literal (constant) and JS_INTERCEPTOR_CONSTANT
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2529483002 .
2016-11-22 14:44:30 -08:00
Brian Wilkerson 4e762c8dbf Fix failures caused by earlier CL
R=paulberry@google.com

Review URL: https://codereview.chromium.org/2523853002 .
2016-11-22 13:49:19 -08:00
Brian Wilkerson 1767def635 Respect the rest of the analysis-based options
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2523833002 .
2016-11-22 13:12:32 -08:00
Konstantin Shcheglov f1f036f018 Implement 'displayName' for accessor and varaible elements in linker.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2527523002 .
2016-11-22 12:59:21 -08:00
John McCutchan e3a8b8085f Add RETURN_NULL_ERROR to new apis
BUG=

Review URL: https://codereview.chromium.org/2524853002 .
2016-11-22 12:53:00 -08:00
Ryan Macnak b83fb06741 Fuchsia sockets:
- Enable FDUtils::AvailableBytes.
 - Disable Socket::SetNoDelay.
 - Implement Socket::GetRemotePeer same as Linux.
 - Implement Socket::ParseAddress same as Linux.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2522923002 .
2016-11-22 12:49:01 -08:00
Konstantin Shcheglov 366e727048 Implement search for other local elements.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2529473002 .
2016-11-22 12:48:15 -08:00
Paul Berry 679e8fd9ff Respect the "allowErrors" parameter in _ResynthesizeAstTest.checkLibrary.
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2527453002 .
2016-11-22 12:46:55 -08:00
Konstantin Shcheglov 9bc4c73e2d Stop returning declaration matches from search for references.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2518183003 .
2016-11-22 12:32:51 -08:00
Brian Wilkerson 89cab97dd8 Add tests for the real generic method syntax
R=vsm@google.com

Review URL: https://codereview.chromium.org/2524463005 .
2016-11-22 12:23:26 -08:00
Konstantin Shcheglov 26307d77b6 Implement SearchEngine for the new driver.
Only search for references, and only to local variables is implemented so far.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2521363003 .
2016-11-22 12:01:52 -08:00
John McCutchan ed47486f60 Fix gen_snapshot product mode build
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2527473002 .
2016-11-22 11:35:27 -08:00
Brian Wilkerson e63105555b Remove uses of configuration data
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2522543007 .
2016-11-22 11:26:08 -08:00
John McCutchan 2510646aaf Wire up the stub native resolver for all libraries in gen_snapshot
Fixes https://github.com/flutter/flutter/issues/6952

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2518233003 .
2016-11-22 11:15:25 -08:00
Ryan Macnak f98363b118 Mark standalone/io/socket_info_ipv6_test as failing on Windows.
Issue #27876

Review URL: https://codereview.chromium.org/2523813002 .
2016-11-22 11:14:46 -08:00
Jacob Richman 1b339deab2 Support lazy JS types.
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2515353003 .
2016-11-22 10:55:35 -08:00
Konstantin Shcheglov 9f1ca4a119 Make AnalysisSErver APIs to access unit/node/element asynchronous.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2526473003 .
2016-11-22 10:46:06 -08:00
Vyacheslav Egorov 2cb8640ac1 Kernel: fix -c dartkp -r dart_precompiled testing configuration.
Pass full snapshot path to the dart_precompiled_runtime executable.

BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org/2517243004 .
2016-11-22 19:34:58 +01:00
Konstantin Shcheglov 4fea218f77 Deoptimize Search - request a new resolved unit for local search.
It seems to me that it would be easier to integrate if we keep the
same search technique - search for Element references. I think any
saving can be only for local elements search. If it turns out to
be expensive, we could add priority results caching in the driver.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2521913004 .
2016-11-22 10:34:26 -08:00
Paul Berry 3a6972095f Add support for "??" to summaries.
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2514353005 .
2016-11-22 10:10:19 -08:00
Ryan Macnak 5ee71cae9d Don't include usage counters, etc in snapshots with code. If we already have code, eagerly recompiling in unlikely to have new type feedback.
Print snapshot sizes when generating an AOT snapshot from gen_snapshot (e.g., Flutter).
Remove some unnecessary symbols.
Use named constants for exit codes.
Use Log::PrintErr instead of fprintf(stderr) so we see error messages in adb logcat.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2517683002 .
2016-11-22 09:59:06 -08:00
Ryan Macnak f62713e97c Fix app snapshots on IA32 Windows.
The file size is not rounded up after the isolate snapshot if there are no rodata/instruction pieces. The other OS's use mmap instead of read, which is apparently okay with over-reading the file.

Fixes #27786

R=asiva@google.com

Review URL: https://codereview.chromium.org/2521883002 .
2016-11-22 09:20:51 -08:00
Ryan Macnak 6c45f24fa6 Report a peer address over IPv4 as IPv4.
R=asiva@google.com

Review URL: https://codereview.chromium.org/2518263002 .
2016-11-22 09:19:08 -08:00
Brian Wilkerson a3e1a0d395 Enable generic method support by default
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2488043002 .
2016-11-22 09:16:19 -08:00
Konstantin Shcheglov ab0a8e775f Use single unit/node/element.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2525693002 .
2016-11-22 09:13:31 -08:00
Regis Crelier 21b6f8904c Fix dartium build (test now passes).
Review URL: https://codereview.chromium.org/2523753002 .
2016-11-22 08:49:11 -08:00
Dan Rubel f109556fb7 remove unused DDC --package-paths options and MultiPackageResolver
R=vsm@google.com

Review URL: https://codereview.chromium.org/2527433002 .
2016-11-22 11:20:23 -05:00
Johnni Winther f6fbc40423 Fix kernel/impact_test
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2521993002 .
2016-11-22 16:21:37 +01:00
Johnni Winther e4c612fc3e Handle forwarding constructors of unnamed mixin applications for reflection
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2519383002 .
2016-11-22 15:58:50 +01:00
Johnni Winther a710603553 Update stacktrace_test with negative tests
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2519883002 .
2016-11-22 15:47:06 +01:00
Asger Feldthaus fbb698393d Update third_party/pkg/kernel version
This CL also updates the use of kernel in dart2js, and
updates the VM/kernel status files.

This is a preliminary step to moving kernel into the
SDK repository.

BUG=
R=het@google.com, johnniwinther@google.com, kmillikin@google.com, sigmund@google.com, vegorov@google.com

Committed: 5d66d0e5dc

Review URL: https://codereview.chromium.org/2518023002 .

Reverted: d69e048d60
2016-11-22 15:22:20 +01:00
Asger Feldthaus d69e048d60 Revert "Update third_party/pkg/kernel version"
This reverts commit 5d66d0e5dc.

BUG=

Review URL: https://codereview.chromium.org/2514323005 .
2016-11-22 14:35:56 +01:00
Asger Feldthaus 5d66d0e5dc Update third_party/pkg/kernel version
This CL also updates the use of kernel in dart2js, and
updates the VM/kernel status files.

This is a preliminary step to moving kernel into the
SDK repository.

BUG=
R=het@google.com, johnniwinther@google.com, kmillikin@google.com, sigmund@google.com, vegorov@google.com

Review URL: https://codereview.chromium.org/2518023002 .
2016-11-22 13:42:13 +01:00
Erik Ernst 9bf3b95cc5 Enable syntax-only support for generic functions by default, take 2.
Fixed some status entries since the first land-revert of this CL.

This addresses https://github.com/dart-lang/sdk/issues/27501.

R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/2520293002 .
2016-11-22 12:33:43 +01:00
Kevin Millikin 3e969cf241 Remove a dead load and smi untag on all platforms.
BUG=
R=kustermann@google.com, vegorov@google.com

Review URL: https://codereview.chromium.org/2520223003 .
2016-11-22 11:25:43 +01:00
Jennifer Messerly 180107cec3 add test, fixes #27807
this appears to have been already working correctly

R=vsm@google.com

Review URL: https://codereview.chromium.org/2517193004 .
2016-11-21 16:44:16 -08:00
Vijay Menon de9e3a3005 Set auto breakpoint at various errors
Any reason not to do this?  I generally find when framework code wraps these errors, it just complicates finding the original bug.  Better to just trap.

Perhaps should just inline the call to debugger though.  I put in dart.debugger with the thought of making it configurable.

R=jacobr@google.com, jmesserly@google.com

Review URL: https://codereview.chromium.org/2519873004 .
2016-11-21 14:40:46 -08:00
Stephen Adams ed4c2cb457 Build CFG for various JS() foreign methods
BUG=
R=het@google.com

Committed: a897bc3832

Review URL: https://codereview.chromium.org/2404123002 .

Reverted:  476ffbda5e
2016-11-21 14:24:32 -08:00
John McCutchan deafdbf978 Re-disable the complex reload test on Windows
BUG=

Review URL: https://codereview.chromium.org/2517333002 .
2016-11-21 14:15:08 -08:00
Konstantin Shcheglov da9fcf3854 Start implementing search support in AnalysisDriver.
Only local variable and label for now.
More local elements and non-local search in following CLs.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2522503004 .
2016-11-21 13:30:19 -08:00
Jennifer Messerly a4760b2fd1 add test, fixes #27808: void return type can subtype dynamic
this appears to already by implemented

R=vsm@google.com

Review URL: https://codereview.chromium.org/2520043002 .
2016-11-21 13:27:23 -08:00
John McCutchan 94a9061925 Handle kPausePostRequest in C++ debugger api implementation
- Fixes https://github.com/flutter/flutter/issues/6890

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2515403003 .
2016-11-21 13:13:21 -08:00