Respect the rest of the analysis-based options

R=scheglov@google.com

Review URL: https://codereview.chromium.org/2523833002 .
This commit is contained in:
Brian Wilkerson 2016-11-22 13:12:32 -08:00
parent f1f036f018
commit 1767def635

View file

@ -501,9 +501,17 @@ class _OptionsProcessor {
var strongMode = analyzer[AnalyzerOptions.strong_mode];
_applyStrongOptions(options, strongMode);
// Set filters.
var filters = analyzer[AnalyzerOptions.errors];
_applyProcessors(options, filters);
// Process language options.
var language = analyzer[AnalyzerOptions.language];
_applyLanguageOptions(options, language);
// Process excludes.
var excludes = analyzer[AnalyzerOptions.exclude];
_applyExcludes(options, excludes);
}
}
@ -612,6 +620,15 @@ class _OptionsProcessor {
}
}
void _applyExcludes(AnalysisOptionsImpl options, Object excludes) {
if (excludes is YamlList) {
List<String> excludeList = toStringList(excludes);
if (excludeList != null) {
options.excludePatterns = excludeList;
}
}
}
void _applyLanguageOption(
AnalysisOptionsImpl options, Object feature, Object value) {
bool boolValue = toBool(value);
@ -640,6 +657,11 @@ class _OptionsProcessor {
}
}
void _applyProcessors(AnalysisOptionsImpl options, Object codes) {
ErrorConfig config = new ErrorConfig(codes);
options.errorProcessors = config.processors;
}
void _applyStrongModeOption(
AnalysisOptionsImpl options, Object feature, Object value) {
bool boolValue = toBool(value);