languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 16:41:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Respect the "allowErrors" parameter in _ResynthesizeAstTest.checkLibrary.

Browse source 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2527453002 .
This commit is contained in:
Paul Berry 2016-11-22 12:46:55 -08:00
parent 9bc4c73e2d
commit 679e8fd9ff
2 changed files with 22 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
pkg/analyzer/test/src/summary/resynthesize_ast_test.dart
View file

@ -6,6 +6,7 @@ library analyzer.test.src.summary.resynthesize_ast_test;
import 'package:analyzer/dart/ast/ast.dart';
import 'package:analyzer/dart/element/element.dart';
import 'package:analyzer/error/error.dart';
import 'package:analyzer/src/dart/element/element.dart';
import 'package:analyzer/src/generated/engine.dart'
show AnalysisContext, AnalysisOptionsImpl;
@ -881,6 +882,12 @@ abstract class _ResynthesizeAstTest extends ResynthesizeTest
Source source = addTestSource(text);
LibraryElementImpl resynthesized = _encodeDecodeLibraryElement(source);
LibraryElementImpl original = context.computeLibraryElement(source);
if (!allowErrors) {
List<AnalysisError> errors = context.computeErrors(source);
if (errors.where((e) => e.message.startsWith('unused')).isNotEmpty) {
fail('Analysis errors: $errors');
}
}
checkLibraryElements(original, resynthesized);
return resynthesized;
}

26
pkg/analyzer/test/src/summary/resynthesize_common.dart
View file

@ -4540,47 +4540,51 @@ typedef F();''');
}
test_unresolved_annotation_namedConstructorCall_noClass() {
checkLibrary('@foo.bar() class C {}');
checkLibrary('@foo.bar() class C {}', allowErrors: true);
}
test_unresolved_annotation_namedConstructorCall_noConstructor() {
checkLibrary('@String.foo() class C {}');
checkLibrary('@String.foo() class C {}', allowErrors: true);
}
test_unresolved_annotation_prefixedIdentifier_badPrefix() {
checkLibrary('@foo.bar class C {}');
checkLibrary('@foo.bar class C {}', allowErrors: true);
}
test_unresolved_annotation_prefixedIdentifier_noDeclaration() {
checkLibrary('import "dart:async" as foo; @foo.bar class C {}');
checkLibrary('import "dart:async" as foo; @foo.bar class C {}',
allowErrors: true);
}
test_unresolved_annotation_prefixedNamedConstructorCall_badPrefix() {
checkLibrary('@foo.bar.baz() class C {}');
checkLibrary('@foo.bar.baz() class C {}', allowErrors: true);
}
test_unresolved_annotation_prefixedNamedConstructorCall_noClass() {
checkLibrary('import "dart:async" as foo; @foo.bar.baz() class C {}');
checkLibrary('import "dart:async" as foo; @foo.bar.baz() class C {}',
allowErrors: true);
}
test_unresolved_annotation_prefixedNamedConstructorCall_noConstructor() {
checkLibrary('import "dart:async" as foo; @foo.Future.bar() class C {}');
checkLibrary('import "dart:async" as foo; @foo.Future.bar() class C {}',
allowErrors: true);
}
test_unresolved_annotation_prefixedUnnamedConstructorCall_badPrefix() {
checkLibrary('@foo.bar() class C {}');
checkLibrary('@foo.bar() class C {}', allowErrors: true);
}
test_unresolved_annotation_prefixedUnnamedConstructorCall_noClass() {
checkLibrary('import "dart:async" as foo; @foo.bar() class C {}');
checkLibrary('import "dart:async" as foo; @foo.bar() class C {}',
allowErrors: true);
}
test_unresolved_annotation_simpleIdentifier() {
checkLibrary('@foo class C {}');
checkLibrary('@foo class C {}', allowErrors: true);
}
test_unresolved_annotation_unnamedConstructorCall_noClass() {
checkLibrary('@foo() class C {}');
checkLibrary('@foo() class C {}', allowErrors: true);
}
test_unresolved_export() {