The CHANGELOG was missing information on the removal of
`pkg/analyzer/lib/src/generated/constant.dart` in this CL https://dart-review.googlesource.com/c/sdk/+/324342.
This CL adds that change to the change log.
Change-Id: Ib8e7276d033cbd89e8eff447d2d96826cc6c9a96
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345349
Commit-Queue: Kallen Tu <kallentu@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Closes https://github.com/dart-lang/sdk/pull/54562
GitOrigin-RevId: f3b2502c0124f287f3eccc021c5f1623839ae3d7
Change-Id: I6af749c16a5358e910bc883ef1ddfc65c30a0c3c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345369
Reviewed-by: Lasse Nielsen <lrn@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Brian Quinlan <bquinlan@google.com>
Commit-Queue: Brian Quinlan <bquinlan@google.com>
As discussed, the "context" prefix was confusing. I'm not sure "default" adds anything so I went with just `featureSet`.
Let me know what you think!
Change-Id: I3e7ca7ac86c3ab7d96f4d4eee34d58904403d2fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345600
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
- Rename some compile time errors tests to end with "error_test.dart"
- Delete runtime tests that no longer perform the operations they
claim to be testing. In many cases they do nothing at all.
Change-Id: I49c7b50d6628f56641b878635b32dbc0bc016bbb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345345
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Maybe related to https://github.com/dart-lang/sdk/issues/38629. These tests have been skipped for so long, enabling them took some work, to migrate them from '.packages' files to package config files.
Some other tidying in the test file:
* inline `byteStorePath`, only used once.
* simplify `_packagesFileContent` and `_getPackagesFileContent`
into a static getter.
* simplify `_defaultPluginContent` into a const String, so it can
be used as a function parameter default value
The diff is way bigger than the functional changes, because we sort
elements.
This reverts commit aa6b6470e3.
Change-Id: I9dc533710255534ec27454712a1a64facf5dd12d
Cq-Include-Trybots: luci.dart.try:analyzer-win-release-try,flutter-analyze-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345367
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
There seems to be a problem with convincing ddc that null-checking
is sufficient for late final field.
Fixes b/319411590
TEST=ci
Change-Id: I1a396201d2a1edf960c0f73e5e0d0ab5be8d9475
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345580
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
Another successful sortie commit.
Change-Id: Ie1e44f3d4c816f30d0129a193f9d360b27c1fe3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345521
Reviewed-by: Lasse Nielsen <lrn@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
This one goes all the way to the top, arm64 == x64! The python's involved.
Change-Id: Ib97b279587b0eaa2cbe4d4915c9f878787b6fd0e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345543
Reviewed-by: Alexander Thomas <athom@google.com>
The operator predence wasn't what I thought it was and reclient gets
downloaded on windows-arm64 where no package is available.
Change-Id: I89b474f1107f2445d5e76a2912cee8bcacf4a667
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345520
Reviewed-by: Martin Kustermann <kustermann@google.com>
Remove older version tags in vm_service and clean up old experiments.
Bug: b/318347018
Change-Id: I6bf87e46878d57d05d7f9d64674ce0c573364d4a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345302
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
The method is introduced as a preliminary step in sharing constraint
gathering and solving engine between the Analyzer and the CFE.
Change-Id: I321a931908054bc08dff0626adcd23deb046230f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/343781
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Bug: b/296994239
Change-Id: Ie8630bcece5c2f62c5693afe654fb9d6367b33e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345286
Commit-Queue: Jonas Termansen <sortie@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Now that we no longer expect to compile unmigrated code, we can clean up
tests that use old language versions. This will enable code cleanup in
backends.
Change-Id: If5711b3bf7c97546168b7fbe6949452e84d4bd40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345368
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
This allows using the new scope finder and facilitates expression
compilation with and in extension types.
For now the script uri is optional (and only passable in the new json
input via package:frontend_server), and only if the script uri is passed
we'll use the new scope finder.
Flutter etc should be updated to pass the new data.
Change-Id: I36eed1ea76a825e63e4c5b9ea60daf18aee39f3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/342400
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Anna Gringauze <annagrin@google.com>
This CL standardizes some comment formats, adds a few missing doc comments, and updates a few others.
It also adds text to a few annotations indicating they are likely to be deprecated in a future release and what the migration path is.
Contributes to https://github.com/dart-lang/sdk/issues/54389
Change-Id: I4fc6d9767378b855a1ab2a1978747fbe18850605
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/342281
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Parker Lougheed <parlough@gmail.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
The old website no longer works for the current format and is archived, so stop directing users there. Same for the package which is no longer hosted on pub.
Change-Id: I9bc6782680859771964587c0af7679f829fa8f95
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345481
Auto-Submit: Parker Lougheed <parlough@gmail.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
Reviewed-by: Mayank Patke <fishythefish@google.com>
We still need to maintain W^X on iOS and Mac OS X.
TEST=ci
Change-Id: I78f005055d090d54f5da478164a73f18e11a32ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345303
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Slava Egorov <vegorov@google.com>
E.g. weekly bot run
176 failed with "getIsolate: (112) Service has disappeared" among other things this.
173 failed with "getIsolate: (112) Service has disappeared".
172 failed with "getIsolate: (112) Service has disappeared".
168 failed with "[Sentinel kind: Collected, valueAsString: <collected>] from getIsolate()".
This will probably fix such issues, although I haven't been able to
reproduce them so I can't be certain.
Change-Id: I3fae76c6031d1a9dbf495e12412f4f95e567c6fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345304
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
We are no longer using Dart VM in a setting where this
matters as a security measure and it just complicates
portability for no benefit.
There is an indication that it is causing problems when
running Linux build of Dart VM under Docker on Mac OS X.
Fixes https://github.com/dart-lang/sdk/issues/54446
TEST=ci
Cq-Include-Trybots: luci.dart.try:vm-fuchsia-release-arm64-try,vm-fuchsia-release-x64-try
Change-Id: I11bdaa8faebaca1df6fd59097049bdaea9cb8e12
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/344581
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Slava Egorov <vegorov@google.com>
Developers that are not ready to migrate can use --use-goma to enable it
themselves if RBE is not meeting their needs. I omitted advertising that
long-existing option in the message since it literally takes five
minutes to migrate to RBE and so far it has had feature parity on Linux.
Bug: b/296994239
Change-Id: I026cd38e644f15da2a0cc641d461a5476de5786e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/342360
Commit-Queue: Jonas Termansen <sortie@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
The stable channel now has builds for all the platforms as there are no
longer any unstable platforms. Let's see if it works since there's no
reason to bump to a 3.3 dev since nobody has needed it yet.
Change-Id: If32e18aa3d26b12b8b7c24d0d36158a922174354
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345284
Commit-Queue: Jonas Termansen <sortie@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Auto-Submit: Jonas Termansen <sortie@google.com>
Bug:#54423
Change-Id: I483d51861390cd4c5def02295a976db4363b84bb
CoreLibraryReviewExempt: Documentation-only change
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/342762
Reviewed-by: Lasse Nielsen <lrn@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Prevents auto-linking to incorrect issue when the tool's output is committed. Do this by removing the hash from `#number` in the commit message, and replacing the PR link at the of the message with a fully qualified reference that resolves to the correct repository on GitHub.
An example of the new output:
```
yaml (98a3aab..509fd72):
509fd72 Mon Dec 11 16:37:13 2023 -0800 Kevin Moore update lints, require Dart 3.0 (dart-lang/yaml#156)
yaml_edit (9b9d33c..47eb20e):
47eb20e Mon Jan 1 13:13:22 2024 +0000 dependabot[bot] Bump actions/stale from 8.0.0 to 9.0.0 (dart-lang/yaml_edit#63)
a39ec39 Wed Dec 20 11:51:28 2023 -0800 Kevin Moore blast_repo fixes (dart-lang/yaml_edit#62)
```
Closes https://github.com/dart-lang/sdk/issues/53857
Change-Id: I23e9d556c69445189a916ce33091a9c77ae15941
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/344361
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Auto-Submit: Parker Lougheed <parlough@gmail.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Previously `VariableDeclaration.initializer` was sometimes not null even
when a function parameter is required.
[1] fixes this, which breaks dart2wasm. This CL prepares `initializer`
usage in prep for [1].
[1]: https://dart-review.googlesource.com/c/sdk/+/345240/1
Change-Id: Ie16156d01eb3659719f004996adce7acc3511b12
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345300
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
They existed for 7+ years, but now its time to remove them :-)
The remaining tests were covering not AnalysisDriver specific cases,
mostly constants, type inference, and resolution. These are already
covered by specific test classes.
Change-Id: Ie203c5358ee63e59b6aea3381c58a25e2a5ebcb8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345342
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
