languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 23:28:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

[vm] Disable --write-protect-code on non-Mac OSes.

Browse source 
We still need to maintain W^X on iOS and Mac OS X.

TEST=ci

Change-Id: I78f005055d090d54f5da478164a73f18e11a32ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345303
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Slava Egorov <vegorov@google.com>
This commit is contained in:
Vyacheslav Egorov 2024-01-09 20:28:55 +00:00 committed by Commit Queue
parent c338b85771
commit e9f51b8534
1 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
runtime/vm/code_patcher.cc
View file

@ -10,7 +10,20 @@
namespace dart {
DEFINE_FLAG(bool, write_protect_code, true, "Write protect jitted code");
#if defined(DART_HOST_OS_MACOS) || defined(DART_HOST_OS_MACOS_IOS)
// On iOS even with debugger attached we must still guarantee that memory
// is never executable and writable at the same time. On Mac OS X
// com.apple.security.cs.allow-jit entitelement allows WX memory regions to be
// created - but we should not rely on this entitelement to be present.
static constexpr bool kShouldWriteProtectCodeByDefault = true;
#else
static constexpr bool kShouldWriteProtectCodeByDefault = false;
#endif
DEFINE_FLAG(bool,
write_protect_code,
kShouldWriteProtectCodeByDefault,
"Write protect jitted code");
#if defined(TARGET_ARCH_IA32)
WritableInstructionsScope::WritableInstructionsScope(uword address,