[infra] Disable Goma by default on Linux.

Developers that are not ready to migrate can use --use-goma to enable it
themselves if RBE is not meeting their needs. I omitted advertising that
long-existing option in the message since it literally takes five
minutes to migrate to RBE and so far it has had feature parity on Linux.

Bug: b/296994239
Change-Id: I026cd38e644f15da2a0cc641d461a5476de5786e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/342360
Commit-Queue: Jonas Termansen <sortie@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
This commit is contained in:
Jonas Termansen 2024-01-09 11:44:28 +00:00 committed by Commit Queue
parent e609c8232b
commit 1253413b71

View file

@ -417,9 +417,10 @@ def ProcessOptions(args):
return False
if os.environ.get('RBE_cfg') == None and \
socket.getfqdn().endswith('.corp.google.com') and \
(args.rbe or args.goma) and \
sys.platform in ['linux']:
print('You can speed up your build by following: go/dart-rbe')
if not args.rbe and not args.goma:
print('Goma is no longer enabled by default since RBE is ready.')
return True
@ -446,7 +447,7 @@ def AddCommonGnOptionArgs(parser):
help='Disable goma',
dest='goma',
action='store_false')
parser.set_defaults(goma=not use_rbe)
parser.set_defaults(goma=not use_rbe and sys.platform not in ['linux'])
parser.add_argument('--rbe', help='Use rbe', action='store_true')
parser.add_argument('--no-rbe',