Commit graph

45034 commits

Author SHA1 Message Date
Peter von der Ahé 88a92f805a Move all main methods to tool/.
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2722223006 .
2017-03-02 14:41:06 +01:00
Peter von der Ahé 628be2b36a Apply transformers and other work arounds to get boostrapping to work.
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2723173002 .
2017-03-02 14:31:58 +01:00
Erik Ernst 1e483f0bcc Specification adjustments for covariant overrides in Dart 1.
Addresses the 1.50 bullet in sdk issue #28164.

R=lrn@google.com

Review-Url: https://codereview.chromium.org/2678003002 .
2017-03-02 13:41:37 +01:00
Jens Johansen a00f168dc1 Mark regress_22445_test as now passing
BUG=

Review-Url: https://codereview.chromium.org/2729573003 .
2017-03-02 13:27:01 +01:00
Zhivka Gucevska 1b82e0c3a0 Initial implementation of interpreter for Kernel
Basic framework, evaluation of BasicLiterals and dummy evaluation
of print.

BUG=
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2722283003 .
2017-03-02 13:19:27 +01:00
Peter von der Ahé 6176847e36 Consolidate analyzer dependencies.
This allows us to create a smaller .dill file for Fasta.

R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2723113002 .
2017-03-02 12:59:47 +01:00
Peter von der Ahé 369c94815d Rename FeContext to FastaContext.
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2726843003 .
2017-03-02 12:38:32 +01:00
Peter von der Ahé c59ecd801c Remove package imports from itself.
Without this, we risk creating two different libraries at runtime. One
named file:///something/ and one named package:front_end/something.
These libraries are different and if enums from one gets mixed with
the other, you get very confusing errors (to apparently identical enums
aren't equal).

R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2726793003 .
2017-03-02 12:34:46 +01:00
Peter von der Ahé 27ce0a4fdc Clean up co19 status file.
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2725143002 .
2017-03-02 12:18:04 +01:00
Peter von der Ahé 501c0e7c45 Clean up language_kernel.status.
R=kmillikin@google.com, vegorov@google.com

Review-Url: https://codereview.chromium.org/2730453003 .
2017-03-02 11:59:13 +01:00
Martin Kustermann e9bc952bcd Update tests/language/vm/causal_async_exception_stack_test
Review-Url: https://codereview.chromium.org/2732433002 .
2017-03-02 11:46:00 +01:00
Jens Johansen 89b68e905b Set dartAsyncMarker the same as asyncMarker unless explicitly set
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2728683005 .
2017-03-02 11:13:38 +01:00
Martin Kustermann bd59a9724e Regenerate baseline files for kernel/test/baseline_strong_mode_test
Review-Url: https://codereview.chromium.org/2731483002 .
2017-03-02 11:06:43 +01:00
Lasse R.H. Nielsen 00cd7580c1 Use FutureOr in Completer.complete.
R=floitsch@google.com

Committed: a4a7d98dce
Review-Url: https://codereview.chromium.org/2722203002 .
2017-03-02 10:11:08 +01:00
Konstantin Shcheglov ce58e89d3c Fix parsing [a]sync[*] function body modifiers with Fasta.
The Fasta'a parser is crazy as it is now. It says that something is a
return statement, but it is actually an expression function body. That
seems too much dart2js specific.

R=paulberry@google.com, ahe@google.com
BUG=

Review-Url: https://codereview.chromium.org/2728773002 .
2017-03-01 16:20:20 -08:00
pq b17f4b2b5d CompletionSuggestion API for arg list text ranges.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2726923003 .
2017-03-01 16:10:46 -08:00
Paul Berry c6d1a0d381 Re-remove AstBuilder.accumulateIdentifierComponents.
This was removed in 3fbeb5d064 and
accidentally re-introduced in 4500bb0920
(presumably due to merge conflict resolution).

Review-Url: https://codereview.chromium.org/2724143002 .
2017-03-01 15:30:34 -08:00
pq d826b1f931 Default arg support continued (flutter-intellij#553).
Default arg support for:
  * inherited refs
  * imported refs
  * type members
  * local constructors

BUG=
R=brianwilkerson@google.com, scheglov@google.com

See: https://github.com/flutter/flutter-intellij/issues/553
Review-Url: https://codereview.chromium.org/2728653004 .
2017-03-01 15:00:47 -08:00
Paul Berry 70408f7549 Add a data structure to keep track of modifiers in AstBuilder.
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2725983002 .
2017-03-01 14:43:11 -08:00
Paul Berry 8decc11ac0 Add AstBuilder support for fields.
R=ahe@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2723883002 .
2017-03-01 13:24:17 -08:00
Konstantin Shcheglov 9fa139215b Parse 'x.y' as PrefixedIdentifier, not PropertyAccess with Fasta.
OTOH, 'x?.y' or '(x).y' should be parsed as PropertyAccess.

R=paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2722283002 .
2017-03-01 13:12:51 -08:00
Konstantin Shcheglov 86b5a088ad Parse InstanceCreationExpression with Fasta.
R=paulberry@google.com, ahe@google.com
BUG=

Review-Url: https://codereview.chromium.org/2727753002 .
2017-03-01 13:04:46 -08:00
Konstantin Shcheglov 270a6900f6 Fix cascade tests with Fasta.
There are still failing cascade tests, but these are because of parsing
differences, not because of problems with the test implementation.

R=paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2726753003 .
2017-03-01 11:45:35 -08:00
pq d1bfe8bccb Calculate default args for local reference completions.
First step towards wiring up default args for completions.

See: https://github.com/flutter/flutter-intellij/issues/553

Next up: similar enhancements for type_members, imported_refs, etc.

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2722253002 .
2017-03-01 11:45:01 -08:00
Konstantin Shcheglov 99b1f617dc Mark not-optional-parameters methods of AstFactory as deprecated.
...and use non-deprecated versions in AstTestFactory.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2726943002 .
2017-03-01 11:43:55 -08:00
Konstantin Shcheglov 93bf98045c Fix parseAssignableSelector() tests and parse '?.' with Fasta.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2727663005 .
2017-03-01 11:33:22 -08:00
Konstantin Shcheglov 3d0a94278e Parse FunctionExpressionInvocation with Fasta.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2728703002 .
2017-03-01 11:19:27 -08:00
Florian Schneider 67c42c7d10 Fix compiler warning with shift of negative value.
It seems newer versions of gcc complain about undefined behavior.

Fixes #28923.

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2723233002 .
2017-03-01 10:47:07 -08:00
Konstantin Shcheglov cc7c61124b Always parse 'x.y' as a prefixed identifier.
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2722153003 .
2017-03-01 10:42:51 -08:00
Kevin Millikin d921f94367 Change a C++ type to avoid triggering an ASSERT.
Malloc'd memory is uninitialized so C++ constructors are not run.  For
class Ref, operator= asserts (basically) that the constructor has been
run.

BUG=
R=asgerf@google.com

Review-Url: https://codereview.chromium.org/2723123002 .
2017-03-01 16:50:24 +01:00
Dmitry Stefantsov 9c340f9eb1 Revert last 4 commits by @lrn
Reverted commits:
* ef097edad6. ("Make Analyzer, VM and
  dart2js accept URI strings as part-of library identifier.")
* e8e1857814. ("Fix bad example of URI
  part-of to be bad, not good.")
* 58f7a92ede. ("Add changelog entry for
  allowing URI in part-of.")
* a4a7d98dce. ("Use FutureOr in
  Completer.complete.")

TBR=lrn@google.com

Review-Url: https://codereview.chromium.org/2724853002 .
2017-03-01 16:44:52 +01:00
Lasse R.H. Nielsen a4a7d98dce Use FutureOr in Completer.complete.
R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2722203002 .
2017-03-01 14:36:46 +01:00
Lasse R.H. Nielsen 58f7a92ede Add changelog entry for allowing URI in part-of.
R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2722183002 .
2017-03-01 14:04:44 +01:00
Lasse R.H. Nielsen e8e1857814 Fix bad example of URI part-of to be bad, not good.
Review-Url: https://codereview.chromium.org/2722173002 .
2017-03-01 13:40:03 +01:00
Lasse R.H. Nielsen ef097edad6 Make Analyzer, VM and dart2js accept URI strings as part-of library identifier.
R=brianwilkerson@google.com, floitsch@google.com, hausner@google.com, johnniwinther@google.com, sigmund@google.com

Review-Url: https://codereview.chromium.org/2640853005 .
2017-03-01 12:15:11 +01:00
Peter von der Ahé bb72d5e8a0 Let parser handle factory modifiers.
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2721623002 .
2017-03-01 11:38:01 +01:00
Asger Feldthaus ea4a89ba03 Add some tests for calls with checks in strong mode.
Tests checks due to covariant subtyping, dynamic calls, and their
interaction with tear-offs.

The tests use explicit type annotations so they can run
independently of frontend type inference.

R=dmitryas@google.com, leafp@google.com

Review-Url: https://codereview.chromium.org/2725563003 .
2017-03-01 11:28:23 +01:00
Kevin Millikin 8166deb009 Mark vm/lazy_deopt_vm_test as slow
BUG=
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2722113002 .
2017-03-01 11:27:48 +01:00
Vyacheslav Egorov 8e267b29c1 Update status files for debug mode dartk/dartkp.
R=kustermann@google.com
BUG=

Review-Url: https://codereview.chromium.org/2722103002 .
2017-03-01 10:31:42 +01:00
Asger Feldthaus af10678cb3 Add source information to the covariance checks inserted for strong mode
BUG=
R=dmitryas@google.com

Review-Url: https://codereview.chromium.org/2718363003 .
2017-03-01 09:51:10 +01:00
danrubel 0c290ae456 echo analysis options information if dartanalyzer --verbose is specified
With this change, if the dartanalyzer --verbose option is specified
then you will see additional output indicating which analysis options
file was read:

Loaded analysis options from /path/to/.analysis_options

In addition, if there are any command line flags that specify/override
an analysis option then you will see something similar to this:

Analysis options: strong = true

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2726783002 .
2017-02-28 17:49:43 -08:00
Jacob Richman a6a206062d Custom formatter cleanup Fix case where displaying a class constructor generated unreadable huge output. Fix case where exceptions were throw. Correct display of statics, fix indentation bugs. Add improved custom formatter test to main repro. As a drive by fix, switch hashCode to use a symbol instead of the name $identityHash as $identityHash was making custom formatter test output unstable.
BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2703263002 .
2017-02-28 17:47:53 -08:00
Jennifer Messerly fe294f3753 unfork DDC's copy of most SDK libraries
There's some changes in strong mode errors we may want to follow up on.

Unforks the following: async, collection, convert, core, developer, internal, io, isolate, math, mirrors.

Does not unfork: html, indexed_db, js, js_util, svg, typed_data, web_audio, web_gl, web_sql.

R=vsm@google.com

Review-Url: https://codereview.chromium.org/2698353003 .
2017-02-28 17:10:52 -08:00
Paul Berry 79cce42e38 Add an AST factory method for fieldDeclaration with all optional named parameters.
Also add 'covariantKeyword' to the Impl constructors and named factories.

R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2722033002 .
2017-02-28 16:43:31 -08:00
Paul Berry 8849a29406 Implement AstBuilder.handleOperatorName.
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2723873002 .
2017-02-28 16:36:03 -08:00
Chris Bracken c9442bb8a2 Unset GREP_OPTIONS when extracting processor count
If GREP_OPTIONS includes -n or --line-number, matches will be emitted
with a line number following the filename. Unset GREP_OPTIONS to ensure
we're getting expected output.

BUG=
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2721953004 .
2017-02-28 16:00:32 -08:00
Dan Rubel bfb8e82c6e Document dartanalyzer analysis options changes (#28928) 2017-02-28 15:19:52 -08:00
Konstantin Shcheglov 36cec1faef Parse ParenthesizedExpression as Fasta.
R=paulberry@google.com, ahe@google.com
BUG=

Review-Url: https://codereview.chromium.org/2726693002 .
2017-02-28 15:08:23 -08:00
Paul Berry fb1bc6ad83 Add preliminary support for method declarations to AstBuilder.
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2706293014 .
2017-02-28 15:05:31 -08:00
Paul Berry f55f111d7a Update kompile.status to reflect e260980624
Commit e260980624 changed some Fasta
tests from "crash" to "fail".

R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2725683003 .
2017-02-28 15:04:03 -08:00