languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 09:12:08 +00:00
Code Issues Packages Projects Releases Wiki Activity
45034 commits 11 branches 6011 tags 1.4 GiB
Commit graph

45034 commits

This branch
This branch
All branches
Author SHA1 Message Date
Ben Konyi 68a102cab2 Fixed tests not having MallocHooks initialized for tests in release mode. 
Revert "Revert "Fixed issue in MallocHooks where a MallocHookScope was accidentally removed during a merge, causing a deadlock in the hooks. Also turned off stack trace collection in a test that was timing out as a result of the stack trace collection.""

This reverts commit 1a5b555aa9.

BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2711353003 .
 2017-02-24 13:56:06 -08:00
Konstantin Shcheglov 123c8a9668 Fix for serializing cascades with not-assignment access to properties. 
This was triggering a small avalanche of inference failures internally.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2711423002 .
 2017-02-24 12:59:48 -08:00
Leaf Petersen ef120f105f When metadata is not requested, elide signature information that is 
not needed for dynamic checks (static fields/getters/setters and constructors).

BUG=
R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2711253004 .
 2017-02-24 12:59:09 -08:00
Konstantin Shcheglov 8d4e252fd1 Support for the 'covariant' keyword for formal parameters. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2716043003 .
 2017-02-24 12:50:17 -08:00
Konstantin Shcheglov 392a9c5bb2 Work around the problem when type inference fails and StrongTypeSystemImpl.inferGenericFunctionCall() returns null. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2712913004 .
 2017-02-24 12:47:20 -08:00
Konstantin Shcheglov 3d88437bda Add AST factories for formal parameters with all optional named parameters. 
Also add 'covariantKeyword' to the Impl constructors and named factories.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2713173003 .
 2017-02-24 12:09:43 -08:00
Stephen Adams b7b12b564a Refined types for most HtmlElement factory constructors 
The body of new DivElement() is marked as returning a DivElement, instead of inferred to return Element.
The more precise receiver type allows svg polyfills to be excluded, allowsing the HtmlElement methods to be identified as the single target and inlined.

This tends to improve the code generated for idioms like

    new DivElement()..classes.add('foo')

    var e1 = new DivElement();
    e1.children.add(e2);

BUG=
R=alanknight@google.com

Review-Url: https://codereview.chromium.org/2705213003 .
 2017-02-24 11:23:06 -08:00
Devon Carew 25dfd0fa80 Deprecate execution.setSubscriptions. 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2713513007 .
 2017-02-24 11:01:00 -08:00
Florian Schneider 864166a758 Fix VM crash when parsing a non-existing redirecting constructor 
Fixes #28217.

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2710363002 .
 2017-02-24 10:26:31 -08:00
John McCutchan 08769082fb Change Library service protocol ids 
Switch the service protocol id for a Library from:

"/libraries/<library_table_index>"

to:

"/libraries/<library_private_key>"

The library table index is not stable across reloads but library ids
are expected to be stable.

BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2703373010 .
 2017-02-24 09:50:04 -08:00
Brian Wilkerson 5f931a26e0 Re-mark test as failing until real solution is found (TBR) 
Review-Url: https://codereview.chromium.org/2714073005 .
 2017-02-24 09:21:11 -08:00
Martin Kustermann 72cd2a06f6 fasta: Cache source bytes to ensure we use the same bytes for outline and bodies, Gives also around 2.5% 
Running fasta on dart2js sources shows no significant RSS memory
increase (within flakiness range).

R=ahe@google.com

Review-Url: https://codereview.chromium.org/2709573005 .
 2017-02-24 17:32:30 +01:00
Brian Wilkerson be65669b34 Fix tests that are failing on windows 
Review-Url: https://codereview.chromium.org/2713913003 .
 2017-02-24 08:18:54 -08:00
Florian Loitsch 13a2bef855 Mark driver_test as failing on windows. 
Review-Url: https://codereview.chromium.org/2715973002 .
 2017-02-24 17:08:36 +01:00
Martin Kustermann eb903b955e Add more debugging support to coredump archiving code 
It seems sometimes we cannot find the coredumps but we are unable to
reproduce it (even on the bots). So let's add some more debugging
information.

R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2713193002 .
 2017-02-24 17:06:28 +01:00
Martin Kustermann cc45d27027 Disable usage of site_config boto file 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2710333004 .
 2017-02-24 17:04:40 +01:00
Martin Kustermann a94bd17168 fasta: Use more efficient Uint16List/Uint32List for line offset information, use hints for length 
R=ahe@google.com

Review-Url: https://codereview.chromium.org/2709983002 .
 2017-02-24 17:03:39 +01:00
Zach Anderson c6b5c19347 [Fuchsia] Use magenta/process.h for mx_job_default, mx_vmar_root_self 
Those symbols will soon be removed from magenta/syscalls.h.

BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2711273003 .
 2017-02-24 08:00:49 -08:00
John McCutchan 8a33d63811 Fix checked mode failure of causal_async_star_stack_contents test 
BUG=

Review-Url: https://codereview.chromium.org/2719503002 .
 2017-02-24 07:30:40 -08:00
John McCutchan 6a312d429b Fix causal_async_star_stack_contents_test with optimization-counter-threshold=5 
There was an off by one error when generating the causal async stack trace
in the debugger. We were always adding one more frame pass the sentinel frame.
This frame is always _Closure.call which is filtered out by the debugger
already. However when --optimization-counter-threshold=5, _Closure.call was
inlined and we ended up appending the inliner to the stack trace. The
inliner is not filtered out by the debugger so we got an extra frame in
the stack trace.

Fixes #28861

BUG=
R=fschneider@google.com

Review-Url: https://codereview.chromium.org/2707413002 .
 2017-02-24 06:58:39 -08:00
Florian Loitsch 37b7a1ac9c Fix typing for lookup-map test. 
Review-Url: https://codereview.chromium.org/2713203002 .
 2017-02-24 15:58:09 +01:00
John McCutchan 97062168e4 Avoid marking functions inlinable when FLAG_causal_async_stacks is false 
BUG=

Review-Url: https://codereview.chromium.org/2712003003 .
 2017-02-24 06:54:50 -08:00
Asger Feldthaus a2e55c953d Add LibraryIndex class for finding classes and members by name. 
The new class becomes a superclass of CoreTypes, which now gets its
functionality from that class, but also exposes commonly used built-in
members as fields.

This replaces a couple of ad-hoc linear searches spread throughout
the code.

The canonical names are not a convenient interface for transformers, so
the idea is that they can use LibraryIndex to address their own runtime
libraries.

To avoid name clashes and still have a somewhat convenient interface,
getters and setters are prefixed by 'get:' and 'set:' in the lookup
table (and only in the lookup table), and top-level members can be
accessed using '::' as the class name. This is the same convention
used by the VM, although it is currently not required to be the same.

R=dmitryas@google.com, karlklose@google.com, kmillikin@google.com

Review-Url: https://codereview.chromium.org/2706243011 .
 2017-02-24 14:49:12 +01:00
Florian Loitsch 58550a2efc Fix fasta strong mode errors (and a lint). 
Review-Url: https://codereview.chromium.org/2711053004 .
 2017-02-24 14:01:36 +01:00
Florian Loitsch d0dc7be4a1 Use a confuse function. 
Review-Url: https://codereview.chromium.org/2712603006 .
 2017-02-24 13:35:20 +01:00
Martin Kustermann f3bef9983b Convert arguments to ''.join() to strings in tools/utils.py 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2710333003 .
 2017-02-24 12:23:26 +01:00
Vyacheslav Egorov f746f27870 Fix issues in dart:io implementation found by fasta. 
R=kustermann@google.com
BUG=https://github.com/dart-lang/sdk/issues/28882

Review-Url: https://codereview.chromium.org/2718673002 .
 2017-02-24 12:19:55 +01:00
Jens Johansen 26b6ecdf63 Enable causal stacktrace in kernel 
R=kmillikin@google.com, kustermann@google.com

Committed: b29829660b
Review-Url: https://codereview.chromium.org/2690873005 .
 2017-02-24 12:11:30 +01:00
Vyacheslav Egorov cb530221cf Pass patched_sdk path down to fasta as an Uri. 
R=kmillikin@google.com
BUG=

Review-Url: https://codereview.chromium.org/2719453002 .
 2017-02-24 11:08:03 +01:00
Vyacheslav Egorov 0e11683bd8 Fix the placement of the platform.dill file generated by patch_sdk. 
R=kmillikin@google.com
BUG=

Review-Url: https://codereview.chromium.org/2716793003 .
 2017-02-24 10:45:54 +01:00
Peter von der Ahé f4c6699816 Store redirecting constructors. 
Fixes https://github.com/dart-lang/sdk/issues/28859

R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2707263009 .
 2017-02-24 09:04:15 +01:00
Konstantin Shcheglov ddddb2c50d Revert "Add NormalFormalParameter.covariantKeyword setter and factory parameter." 
This reverts commit 57b78f422e.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2710393002 .
 2017-02-23 21:22:00 -08:00
Devon Carew 42cd232ba5 Fix pkg/analyzer_plugin/tool/spec/check_all_test. 
BUG=

Review-Url: https://codereview.chromium.org/2715853003 .
 2017-02-23 21:07:32 -08:00
Ben Konyi 1a5b555aa9 Revert "Fixed issue in MallocHooks where a MallocHookScope was accidentally removed during a merge, causing a deadlock in the hooks. Also turned off stack trace collection in a test that was timing out as a result of the stack trace collection." 
This reverts commit 44a9a4ede3.

BUG=

Review-Url: https://codereview.chromium.org/2714083002 .
 2017-02-23 19:21:00 -08:00
Ben Konyi 44a9a4ede3 Fixed issue in MallocHooks where a MallocHookScope was accidentally removed during a merge, causing a deadlock in the hooks. Also turned off stack trace collection in a test that was timing out as a result of the stack trace collection. 
Updated MallocHooks to collect stack traces when memory is allocated.

BUG=
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2718523003 .
 2017-02-23 18:58:50 -08:00
Ben Konyi 2b81624bb2 Revert "Revert "[test.dart] Complain if there is non-utf8 formatted data in test output"" 
This reverts commit 7af8f320a7.

TBR=zra@google.com
BUG=

Review-Url: https://codereview.chromium.org/2710603009 .
 2017-02-23 17:08:15 -08:00
Ben Konyi 7af8f320a7 Revert "[test.dart] Complain if there is non-utf8 formatted data in test output" 
This reverts commit c294dec5e6.

TBR=zra@google.com
BUG=

Review-Url: https://codereview.chromium.org/2705213006 .
 2017-02-23 16:57:31 -08:00
Devon Carew 0f7fc43df5 Remove the --no-error-notification flag. 
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2713053002 .
 2017-02-23 16:55:46 -08:00
Zachary Anderson 3dc6a628b8 Fix standalone status file 
Review-Url: https://codereview.chromium.org/2716753002 .
 2017-02-23 15:23:11 -08:00
Konstantin Shcheglov 57b78f422e Add NormalFormalParameter.covariantKeyword setter and factory parameter. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2714843002 .
 2017-02-23 14:48:57 -08:00
Ben Konyi b19e499042 Removed MallocHookScope and replaced it with MallocLocker, which behaves like MutexLocker but also keeps track of which thread current holds the lock using MallocLocker. 
BUG=
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2715493005 .
 2017-02-23 14:45:06 -08:00
Konstantin Shcheglov 91d62cb226 Remove addFile() invocations in analyzer_cli. 
Now that we always get errors when we ask for the result, we don't need
adding these files. This makes analysis of shared tests about 15-20% faster.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2711233002 .
 2017-02-23 14:41:31 -08:00
Devon Carew fbb613a3fe Update the statuses of various analysis server integration tests. 
BUG=
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2717523003 .
 2017-02-23 14:23:55 -08:00
Paul Berry 0c1facfd9b Split parser tests that exercise class members to their own class. 
In future CLs I will get these tests to pass.

R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2713553011 .
 2017-02-23 14:22:16 -08:00
Zach Anderson c294dec5e6 [test.dart] Complain if there is non-utf8 formatted data in test output 
related #28872

R=ahe@google.com

Review-Url: https://codereview.chromium.org/2710003005 .
 2017-02-23 14:15:26 -08:00
Konstantin Shcheglov 48714187b3 Run src/task/strong tests with analysis driver. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2715533008 .
 2017-02-23 14:13:51 -08:00
Vijay Menon 4021fecb1a Streamline field symbol names 
Original CL from Kasper. :-)

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2703373003 .
 2017-02-23 14:11:21 -08:00
danrubel 0679f88215 gracefully degrade if lints option not defined 
Review-Url: https://codereview.chromium.org/2710323002 .
 2017-02-23 17:06:05 -05:00
Konstantin Shcheglov f19f6d8ca6 Always return computed errors, even for not added files. 
There is no penalty for computing it, we have already computed, it is
just a matter of returning them or not.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2709633009 .
 2017-02-23 13:55:32 -08:00
danrubel abee739921 rework analyzer_cli to use ContextBuilder getAnalysisOptions 
This is a follow on to https://codereview.chromium.org/2716693003
that refactors analyzer_cli to use ContextBuilder.
As a result, dartanalyzer now correctly finds the default
flutter analysis options when the project references package:flutter
but does not contain an analysis options file.

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2710313002 .
 2017-02-23 16:52:26 -05:00