languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 16:41:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Always parse 'x.y' as a prefixed identifier.

Browse source 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2722153003 .
This commit is contained in:
Konstantin Shcheglov 2017-03-01 10:42:51 -08:00
parent d921f94367
commit cc7c61124b
3 changed files with 11 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
pkg/analyzer/lib/src/generated/parser.dart
View file

@ -6357,11 +6357,6 @@ class Parser {
Expression selectorExpression = parseAssignableSelector(
expression, isOptional || (expression is PrefixedIdentifier));
if (identical(selectorExpression, expression)) {
if (!isOptional && (expression is PrefixedIdentifier)) {
PrefixedIdentifier identifier = expression as PrefixedIdentifier;
expression = astFactory.propertyAccess(
identifier.prefix, identifier.period, identifier.identifier);
}
return expression;
}
expression = selectorExpression;

6
pkg/analyzer/test/generated/parser_fasta_test.dart
View file

@ -434,6 +434,12 @@ class ExpressionParserTest_Fasta extends FastaParserTestCase
.test_parseAssignableExpression_identifier_args_dot_typeParameterComments();
}
@override
@failingTest
void test_parseAssignableExpression_identifier_dot() {
super.test_parseAssignableExpression_identifier_dot();
}
@override
@failingTest
void test_parseAssignableExpression_identifier_question_dot() {

10
pkg/analyzer/test/generated/parser_test.dart
View file

@ -4180,11 +4180,11 @@ abstract class ExpressionParserTestMixin implements AbstractParserTestCase {
Expression expression = parseAssignableExpression('x.y', false);
expect(expression, isNotNull);
assertNoErrors();
var propertyAccess = expression as PropertyAccess;
expect(propertyAccess.target, isNotNull);
expect(propertyAccess.operator, isNotNull);
expect(propertyAccess.operator.type, TokenType.PERIOD);
expect(propertyAccess.propertyName, isNotNull);
var identifier = expression as PrefixedIdentifier;
expect(identifier.prefix.name, 'x');
expect(identifier.period, isNotNull);
expect(identifier.period.type, TokenType.PERIOD);
expect(identifier.identifier.name, 'y');
}
void test_parseAssignableExpression_identifier_index() {