John Messerly
865e808f15
support @virtual
fields, fix #27384
...
R=leafp@google.com
Review URL: https://codereview.chromium.org/2352433002 .
2016-09-19 09:45:24 -07:00
William Hesse
88a64b77bf
Add support for package spec to testing HttpServer.
...
BUG=https://github.com/dart-lang/sdk/issues/27065
R=terry@google.com
Review URL: https://codereview.chromium.org/2347423003 .
2016-09-19 18:43:16 +02:00
Brian Wilkerson
57f1193c01
First steps toward removing MethodTrampoline
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2348353002 .
2016-09-19 08:24:29 -07:00
John McCutchan
699e328105
Fix VM connect element test
...
BUG=
Review URL: https://codereview.chromium.org/2348313002 .
2016-09-19 07:33:44 -07:00
Johnni Winther
e24939f8d6
Handle generic factory constructors in kernel_impact
...
R=het@google.com
Review URL: https://codereview.chromium.org/2341263002 .
2016-09-19 11:35:56 +02:00
William Hesse
9f3b5d8680
Update observatory_tool.py to remove package-root
...
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/2346483007 .
2016-09-19 10:11:31 +02:00
Konstantin Shcheglov
f5a616834e
Use configurations and declared variables to select import/export URIs during prelinking.
...
R=paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/27045
Review URL: https://codereview.chromium.org/2353433002 .
2016-09-18 14:04:01 -07:00
Konstantin Shcheglov
54ee2b88c8
ImportElement/ExportElement 'uri' should be the selected URI.
...
So, that the URI is consistent with the imported/exportedLibrary.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/2343103003 .
2016-09-17 17:26:13 -07:00
Brian Wilkerson
07aa504eb9
Clean up missed references to deprecated code
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2349863002 .
2016-09-17 10:37:29 -07:00
John Messerly
70f6e16c97
fix #27363 , support @checked
on fields
...
Just needed to have the synthetic setter param look for metadata on the field.
R=leafp@google.com
Review URL: https://codereview.chromium.org/2346143003 .
2016-09-16 18:20:23 -07:00
John Messerly
86ae2c8df9
fix #27382 , tweak inference heuristic when we have no upper bound info
...
R=leafp@google.com
Review URL: https://codereview.chromium.org/2348583005 .
2016-09-16 17:28:03 -07:00
John Messerly
cbdfa87b88
add a changelog entry for #27151
...
R=leafp@google.com
Review URL: https://codereview.chromium.org/2338293003 .
2016-09-16 16:06:19 -07:00
Zachary Anderson
fa9922d420
Fix standalone VM build for Android for tcmalloc.
...
Review URL: https://codereview.chromium.org/2347823005 .
2016-09-16 16:05:54 -07:00
John Messerly
0713345b34
address #25232 in strong mode (dart1 behavior unchanged)
...
R=leafp@google.com
Review URL: https://codereview.chromium.org/2340173002 .
2016-09-16 16:04:18 -07:00
Harry Terkelsen
2470d57d0e
dart2js: undo formatting for super long vectors
...
Review URL: https://codereview.chromium.org/2350493002 .
2016-09-16 15:59:01 -07:00
Harry Terkelsen
3d31aa2ff7
dart2js: run dartfmt on tests
...
R=sigmund@google.com
Review URL: https://codereview.chromium.org/2345083003 .
2016-09-16 15:49:23 -07:00
Ryan Macnak
5ecc880ffc
Remove assumption from the heap verifier that objects occupy a narrow range of the address space.
...
Fixes #27373 .
R=zra@google.com
Review URL: https://codereview.chromium.org/2349023002 .
2016-09-16 15:41:47 -07:00
Adam Barth
f7c8140aa3
Fix gn build
...
We need to update the call to make_link.py in the same way the GYP build was
updated.
2016-09-16 15:27:42 -07:00
William Hesse
338e7e25f3
Update status after package root removal
...
BUG=https://github.com/dart-lang/sdk/issues/27378
Committed: 82c24568d4
Reopened to add new commit, fixing CL
Review URL: https://codereview.chromium.org/2347303002 .
2016-09-17 00:22:17 +02:00
Stephen Adams
a51d185ff5
Do not add type information to constants with constructor taking type information
...
R=sigmund@google.com
BUG=
Review URL: https://codereview.chromium.org/2343193002 .
2016-09-16 15:09:28 -07:00
Florian Schneider
9f00ce2b6e
VM: Fix for deadlock with background tasks.
...
We have to do NotifyAll whenever a task finishes.
Also, remove thread notifications when a task is created, since we only ever wait for tasks to finish.
BUG=#27365
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2349853002 .
2016-09-16 15:03:36 -07:00
William Hesse
82c24568d4
Update status after package root removal
...
BUG=https://github.com/dart-lang/sdk/issues/27378
Review URL: https://codereview.chromium.org/2347303002 .
2016-09-16 23:46:06 +02:00
Zachary Anderson
509e6f3eb3
Fixes Dartium build
...
R=asiva@google.com
Review URL: https://codereview.chromium.org/2345773004 .
2016-09-16 13:52:45 -07:00
John McCutchan
cbbb82cfbe
Ship Observatory with non-minified sources
...
This will help our users report more actionable bug reports.
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2348673003 .
2016-09-16 13:00:38 -07:00
Zachary Anderson
aaa6bfca70
Fix boringssl defines for MIPS build.
...
Review URL: https://codereview.chromium.org/2349833002 .
2016-09-16 12:39:39 -07:00
Harry Terkelsen
67ab213718
dart2js: fix tests after moving to .packages in the SDK repo
...
R=sigmund@google.com
Review URL: https://codereview.chromium.org/2346053002 .
2016-09-16 12:07:31 -07:00
John McCutchan
b961fc01ad
Fix bad commit of stale patch set of original CL "Make NoReloadScope thread safe" ( https://codereview.chromium.org/2344193002/ )
...
BUG=
Review URL: https://codereview.chromium.org/2344263002 .
2016-09-16 11:33:43 -07:00
Konstantin Shcheglov
ea0d3e4430
Issue 27374. Include all configuration sources into REFERENCED_SOURCES.
...
VerifyUnitTask verifies all Configuration sources, so we need to know
MODIFICATION_TIME all the sources, even if the configuration is not selected.
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27374
Review URL: https://codereview.chromium.org/2347123004 .
2016-09-16 11:31:32 -07:00
John McCutchan
d5f138e459
Fix async_generator_breakpoint_test so it awaits on isolate resume requests
...
BUG=
Review URL: https://codereview.chromium.org/2344253002 .
2016-09-16 11:24:53 -07:00
John McCutchan
d113638891
Make NoReloadScope thread safe
...
Fixes #27366
BUG=
R=fschneider@google.com
Review URL: https://codereview.chromium.org/2344193002 .
2016-09-16 11:18:36 -07:00
Matthias Hausner
be003d70f2
Fix Windows build
...
BUG=
Review URL: https://codereview.chromium.org/2342303003 .
2016-09-16 11:16:50 -07:00
Brian Wilkerson
772c93ccf2
Rename libraryUri
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2347213002 .
2016-09-16 10:54:25 -07:00
Brian Wilkerson
7eb7573dc4
Initial support for the NNBD proposal
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2342383002 .
2016-09-16 10:51:19 -07:00
Zachary Anderson
5348efba7d
Skip heap verify on 64-bit with an app snapshot
...
See issue: https://github.com/dart-lang/sdk/issues/27373
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2348793004 .
2016-09-16 10:41:19 -07:00
John McCutchan
e2b922b4c5
Fix service test websocket error edge case
...
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2343183002 .
2016-09-16 10:31:05 -07:00
Konstantin Shcheglov
3f264975f8
Issue 27367. Fix linking when setter overrides a field.
...
R=paulberry@google.com , jmesserly@google.com
BUG= https://github.com/dart-lang/sdk/issues/27367
Review URL: https://codereview.chromium.org/2342883004 .
2016-09-16 10:16:46 -07:00
Matthias Hausner
3e0d13bc28
Make compile-time errors catchable
...
If an error happens during the compilation of a function body, an Error is thrown which can be intercepted, and ensures that finally blocks are executed before the isolate is terminated.
The language spec is vague about compilation errors. A doc describing the intentions behind this CL is at
https://docs.google.com/document/d/1_MWOgwJadLCQSBps0zD6Rj5dG4iP1UBuiDvTMH-WMzI/edit#
Example:
1 void bad() {
2 return 5
3 }
4
5 void main(args) {
6 bad();
7 }
Before this CL:
$ dart ~/tmp/e.dart
'file:///Users/hausner/tmp/e.dart': error: line 2 pos 11: semicolon expected
return 5
^
$
After this change:
$ dart ~/tmp/e.dart
Unhandled exception:
'file:///Users/hausner/tmp/e.dart': error: line 2 pos 11: semicolon expected
return 5
^
#0 main (file:///Users/hausner/tmp/e.dart:6:3)
#1 _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:259)
#2 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:148)
$
Notice that the stack trace points to the call site of bad(), not the text location of the syntax error. That's not a bug. The location of the syntax error is given in the error message.
BUG= https://github.com/dart-lang/sdk/issues/23684
R=asiva@google.com , lrn@google.com
Review URL: https://codereview.chromium.org/2044753002 .
2016-09-16 10:10:38 -07:00
Sigmund Cherem
b9a5c77321
Fixs in perf.dart: strong-clean, avoid deprecated apis, minor output tweaks
...
R=brianwilkerson@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org/2349683003 .
2016-09-16 09:57:03 -07:00
John McCutchan
0d831bd5c8
Use Chain.capture instead of runZoned
...
- [x] Swap all calls of runZoned to Chain.capture.
Chain.capture is a wrapper around runZoned that tracks stack traces across asynchronous gaps.
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2349753002 .
2016-09-16 09:44:06 -07:00
Zachary Anderson
3360b3cef9
Update CHANGELOG for tcmalloc change
...
R=asiva@google.com
Review URL: https://codereview.chromium.org/2345273002 .
2016-09-16 09:30:45 -07:00
Konstantin Shcheglov
f4fdf25cb1
Fix dartanalyzer.gyp for SDK summary generation.
...
R=paulberry@google.com , whesse@google.com
BUG=
Review URL: https://codereview.chromium.org/2341303004 .
2016-09-16 09:13:01 -07:00
Zachary Anderson
139db22be5
Use OS-provided trusted root certs on Linux
...
First, the look for trusted root certificates
in standard locations on the file system
(/etc/pki/tls/certs/ca-bundle.crt followed by
/etc/ssl/certs), and only if these do not exist
will we fall back on the compiled-in trusted root
certificates. This behavior can be overridden
with the new flags --root-certs-file and
--root-certs-cache.
R=asiva@google.com
Review URL: https://codereview.chromium.org/2346683003 .
2016-09-16 09:08:51 -07:00
Zachary Anderson
44a04f18f9
Use tcmalloc on Linux
...
Statically linking in the tcmalloc code is enough
to override the built-in malloc. I have this set up to
exclude the code for collecting heap profiles in a
Product build. There's still about a 230KB increase in
binary size, though. I think this isn't a big problem
since right now this is enabled only for server Linux.
product binary size:
before x64: 9569600
after x64: 9807840
increase: 238240 (2.5%)
before ia32: 9122836
after ia32: 9360944
increase: 238108 (2.6%)
before mips: 9418680
after mips: 9640940
increase: 222260 (2.4%)
InitialRSS:
product:
before x64: 6307840
after x64: 7430144
increase: 1122304 (17.8%)
release (--no-profiler)
before x64: 7843840
after x64: 9207808
increase: 1363968 (17.4%)
R=asiva@google.com , whesse@google.com
Review URL: https://codereview.chromium.org/2316813002 .
2016-09-16 08:24:54 -07:00
Brian Wilkerson
22040876bf
Use declared variables to select the correct configuration for resolution
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/2345773003 .
2016-09-16 07:32:40 -07:00
John McCutchan
7fca076fbb
Use dartfmt on Observatory code
...
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2345023003 .
2016-09-16 06:59:51 -07:00
William Hesse
61eee9ee52
Use checked-in .package file for building and testing
...
Stop creating [build dir]/packages directory with symbolic links.
BUG=https://github.com/dart-lang/sdk/issues/23565
R=rnystrom@google.com
Committed: 5d3e356ca7
Review URL: https://codereview.chromium.org/1746743002 .
Reverted: 6d238ba197
2016-09-16 15:03:18 +02:00
Johnni Winther
4eca725670
More features handled in kernel impact.
...
BUG=
R=het@google.com
Review URL: https://codereview.chromium.org/2329403003 .
2016-09-16 12:52:47 +02:00
Johnni Winther
6e62b8af9a
Handle signature types and fields in kernel_impact
...
R=het@google.com
Review URL: https://codereview.chromium.org/2331923002 .
2016-09-16 12:43:41 +02:00
Konstantin Shcheglov
fa24d1caaa
Stop generating index information for SDK and simplify summary generation.
...
The implementation is still element model based, I will switch it to
the AST based approach in a following CL.
R=paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org/2345793002 .
2016-09-15 16:15:20 -07:00
Sigmund Cherem
4af56d5647
entrypoint to measure performance of the analyzer frontend
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org/2339803004 .
2016-09-15 15:43:09 -07:00