Commit graph

41352 commits

Author SHA1 Message Date
John Messerly
a4734d4b33 fix #27353, support @checked covariant parameters in DDC
Seems pretty straightforward. Just added a simple test for now.

R=leafp@google.com

Review URL: https://codereview.chromium.org/2340463009 .
2016-09-15 15:42:04 -07:00
Ryan Macnak
47cc06ae66 Shrink AOT snapshot size and memory usage.
- Conditionally remove fields of Code, Function and ICData that are not used in the AOT runtime.
 - Don't include RawClosureData.context_scope_ in AOT snapshots.
 - Remove parameter names not needed for method resolution.
 - Remove parameter types not needed for function type tests.
 - Deduplicate parameter name and parameter type lists.
 - Shrink and share the initial MegamorphicCache table.

Flutter gallery (IsolateSnapshotReader event)
snapshot size 2731129 -> 2199999 (-19.4%)
initial heap  7899568 -> 5433176 (-31.2%)

R=fschneider@google.com

Review URL: https://codereview.chromium.org/2326483005 .
2016-09-15 15:06:42 -07:00
Brian Wilkerson
ab9ba20c04 Fix recently introduced strong-mode errors
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2344933002 .
2016-09-15 14:37:37 -07:00
John McCutchan
ce8d0653da Improve async stack traces in Observatory
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2333923007 .
2016-09-15 13:44:51 -07:00
Ryan Macnak
57d558fa5f Observatory: Fix instance view of lists.
Fixes #27351.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2342943002 .
2016-09-15 13:35:18 -07:00
Konstantin Shcheglov
cfe56b9241 Issue 27044. Summarize configurations of imports and exports, AST based.
R=paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/27044

Review URL: https://codereview.chromium.org/2342893002 .
2016-09-15 12:00:28 -07:00
Konstantin Shcheglov
37a36f0389 AbstractDartSdk should not return its linked bundle if 'useSummary' is false.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2345743002 .
2016-09-15 11:37:09 -07:00
Konstantin Shcheglov
8c7790215c Rollback 6bee780067, restore PrintWriter.
As we decided, this change conflicts with Angular and other packages,
so it should be rolled back.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2340583006 .
2016-09-15 11:32:35 -07:00
John McCutchan
72b79d970b Improve VM connection flow in Observatory
- [x] Don't show "(Connected)" next to a VM we aren't connected to.
- [x] Navigate to the vm-connect page if we get an initial connection error.
- [x] Fix regression of the 'vm disconnected' notification bubble not appearing.
- [x] Use the Uris helper class instead of hard coded paths
- [x] Improve user inputted URI normalization
- [x] Ignore network errors on stream subscription requests
- [x] On first launch, attempt to connect to the default target and not the last target connected to.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2340973002 .
2016-09-15 11:29:06 -07:00
Jacob Richman
7341e3d34c Cleanup. Fix new analyzer errors due to recent strong mode changes.
BUG=

Review URL: https://codereview.chromium.org/2338323004 .
2016-09-15 10:45:05 -07:00
Jacob Richman
35e7c4c5f5 Always write the source map even if it is inlined. This simplifies bazel rules.
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2342643003 .
2016-09-15 10:33:22 -07:00
Terry Lucas
79f406443d Update status for expected failures in Dartium.
TBR=whesse@google.com

Review URL: https://codereview.chromium.org/2341653005 .
2016-09-15 09:38:55 -07:00
William Hesse
34b7fd39dc Avoid error in testing script if environment is empty.
BUG=
R=eernst@google.com

Review URL: https://codereview.chromium.org/2344903002 .
2016-09-15 18:29:38 +02:00
Ryan Macnak
872b38ef4e Exclude clustered snapshot writer from AOT runtime.
product, stripped, precompiled runtime
4862848 -> 4760663 (-2.1%)

R=fschneider@google.com

Review URL: https://codereview.chromium.org/2346713002 .
2016-09-15 09:24:07 -07:00
Zachary Anderson
bc1dc06687 DBC: Double converstion instructions
R=fschneider@google.com

Review URL: https://codereview.chromium.org/2341683003 .
2016-09-15 09:18:32 -07:00
William Hesse
89539c9665 Return failure result from dartium buildbot_annotated_steps
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org/2344753003 .
2016-09-15 17:46:43 +02:00
Brian Wilkerson
ecc84b26a4 Break up another large file
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2342733002 .
2016-09-15 07:49:27 -07:00
Konstantin Shcheglov
35bf41691e Change summaries setter generation to allow properties named 'value'.
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2339053002 .
2016-09-15 07:08:38 -07:00
Rico Wind
c1efad95c4 Remove ricow@ from failure print out
BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org/2346803002 .
2016-09-15 16:05:48 +02:00
William Hesse
6d238ba197 Revert "Use checked-in .package file for building and testing"
This reverts commit 5d3e356ca7.

BUG=
R=eernst@google.com

Review URL: https://codereview.chromium.org/2340813004 .
2016-09-15 15:46:49 +02:00
William Hesse
5d3e356ca7 Use checked-in .package file for building and testing
Stop creating [build dir]/packages directory with symbolic links.

BUG=https://github.com/dart-lang/sdk/issues/23565
R=rnystrom@google.com

Review URL: https://codereview.chromium.org/1746743002 .
2016-09-15 14:50:30 +02:00
John Messerly
1c957d548d fix DDC build: some inference failures are reported now, so we need to update some test type annotations
Review URL: https://codereview.chromium.org/2347493002 .
2016-09-14 17:39:27 -07:00
Stephen Adams
591f8ea79e Avoid merging conditions across lopp boundary
Fixes https://github.com/dart-lang/sdk/issues/27354

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2339853004 .
2016-09-14 17:08:39 -07:00
Harry Terkelsen
076f4c30c9 kernel -> ssa: implement literal maps
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2335203005 .
2016-09-14 16:59:30 -07:00
John Messerly
79a9409f75 fix #27151, list and map literals infer using up and down info
R=leafp@google.com

Review URL: https://codereview.chromium.org/2343713002 .
2016-09-14 16:35:26 -07:00
John McCutchan
87dcad607e Cleanup some Observatory errors caught by dart2js
Not sure why the analzyer didn't notice these but dart2js (when invoked via pub serve does).

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2339303003 .
2016-09-14 15:45:14 -07:00
Ryan Macnak
cd4c9fc46b Observatory: Fix allocation profile CSV export. Fix heap snapshot in/out reference counts.
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2340883002 .
2016-09-14 15:44:28 -07:00
Harry Terkelsen
a175f914c2 mark dart2js kernel tests as slow
since we have to build all of dart:core for every test, it can take
a long time

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2339703004 .
2016-09-14 13:08:01 -07:00
Jacob Richman
d858c4f2ae Fix build break.
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2346573002 .
2016-09-14 13:07:34 -07:00
Harry Terkelsen
866e4ea550 kernel -> ssa: implement literal lists
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2346543002 .
2016-09-14 11:26:26 -07:00
Jacob Richman
bda62939a2 Support generating inlined source maps and wrapping module contents within a JavaScript eval block to improve the debugging experience.
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org/2337213003 .
2016-09-14 10:54:47 -07:00
Zachary Anderson
360d55b4f6 DBC: Another allocation fast path
R=fschneider@google.com

Review URL: https://codereview.chromium.org/2335363002 .
2016-09-14 10:24:58 -07:00
Brian Wilkerson
37d213e608 Add a tool for viewing instrumentation logs
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2338883003 .
2016-09-14 09:50:46 -07:00
Harry Terkelsen
8be34ddd39 Build entire program with kernel for conversion to ssa.
This CL has the kernel task of the backend building the entire program.
This causes the compiler to resolve a lot more than usual, and so we need
to support many language features in the kernel -> ssa builder to compile
all of the helper functions that are included in the output.

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2338093002 .
2016-09-14 09:42:23 -07:00
Florian Schneider
c134873651 Hot reload testing: Mark slow some tests as Pass, Timeout
These are similar to the other collection tests that take too long in
hot-reload test mode.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2343483002 .
2016-09-14 09:34:45 -07:00
Vijay Menon
9732138317 Testing support for FF and Safari
Also travis support for testing FF.  See:

https://travis-ci.org/dart-lang/sdk/builds/159331789

On FF 48, 1965 out of 1979 tests are passing.  Run locally:
DDC_BROWSERS=Firefox npm test

On Safari 10 (tech preview), it fails immediately due to a static method named "caller".  We disallow it as a field, but not a method right now.  If I hack that out, 1972 out of 1979 tests appear to pass.

Run locally by installing tech preview and running:
DDC_BROWSERS=Safari SAFARI_BIN=/Applications/Safari\ Technology\ Preview.app/Contents/MacOS/Safari\ Technology\ Preview npm test
R=jmesserly@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org/2334763002 .
2016-09-14 08:41:43 -07:00
Dan Rubel
023295912a improve import URI completions at EOF
fixes https://github.com/dart-lang/sdk/issues/27020

R=scheglov@google.com

Review URL: https://codereview.chromium.org/2342473002 .
2016-09-14 11:22:25 -04:00
John Messerly
05e945d1c0 follow up for #25578, add @checked to package:meta
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/2334413002 .
2016-09-13 17:26:24 -07:00
Florian Schneider
743fe92c49 VM: Better handling of OOM errors in the background compiler
Don't expect to find a Dart frame on the stack when an exception
occurs in background compilation.  Propagate OOM error as an
unhandled exception, and disable optimization for the function
where it occurred.

BUG=#27206
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2341523002 .
2016-09-13 17:13:49 -07:00
Matthias Hausner
3e60d48842 Fix parsing of generic closure formal parameter
BUG=#27299
R=regis@google.com

Review URL: https://codereview.chromium.org/2341493002 .
2016-09-13 15:11:10 -07:00
John Messerly
28247a3daa fix #25578, implement @covariant parameter overrides
R=leafp@google.com

Review URL: https://codereview.chromium.org/2336503003 .
2016-09-13 14:57:22 -07:00
Brian Wilkerson
1f10422fd5 Update uses of deprecated API in ddc
R=jmesserly@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2338883002 .
2016-09-13 11:44:38 -07:00
Dan Rubel
4fce5e9022 reduce the relevance of completions starting with "$"
fixes https://github.com/dart-lang/sdk/issues/27303

R=scheglov@google.com

Review URL: https://codereview.chromium.org/2330413004 .
2016-09-13 14:21:31 -04:00
Regis Crelier
69a66ef6ca Update dart2js status file for recently added test.
Review URL: https://codereview.chromium.org/2336333002 .
2016-09-13 10:54:33 -07:00
Zachary Anderson
e2d269225b [fuchsia] Add InitialRSS to status list, add missing launchpad call.
R=asiva@google.com

Review URL: https://codereview.chromium.org/2337883004 .
2016-09-13 10:49:17 -07:00
Zachary Anderson
7d01ca5e0d DBC: A couple allocation fastpaths.
R=fschneider@google.com

Review URL: https://codereview.chromium.org/2331033003 .
2016-09-13 10:21:27 -07:00
Konstantin Shcheglov
453546173e Safe handle removed file while incremental invalidation.
I see these situations happening in internal logs.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2337073003 .
2016-09-13 10:03:01 -07:00
Regis Crelier
4634faa574 Add new language test for generic function parameter (filed issue #27299).
R=hausner@google.com

Review URL: https://codereview.chromium.org/2333973002 .
2016-09-13 09:24:57 -07:00
Konstantin Shcheglov
8c1d5a3b56 Remove LibraryElement.visibleLibraries.
It is not used now.
The only other is smoke, and its only in test, and it is actually
used incorrectly there.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2336913002 .
2016-09-13 07:45:53 -07:00
William Hesse
51d7bf58e4 Update co19 status for content_shell
BUG=
R=eernst@google.com

Review URL: https://codereview.chromium.org/2338783002 .
2016-09-13 14:54:30 +02:00