Commit graph

41352 commits

Author SHA1 Message Date
Konstantin Shcheglov f4186fb463 Issue 27244. Add 'isDeprecated' to HoverInformation.
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27244

Review URL: https://codereview.chromium.org/2310153002 .
2016-09-06 11:31:11 -07:00
Zach Anderson 245b330548 Fix run_vm_tests for Windows
related #27250

Review URL: https://codereview.chromium.org/2312293002 .
2016-09-06 10:57:35 -07:00
Zach Anderson a695975d00 Fixes run_vm_tests Windows shutdown problem
related #27250

R=fschneider@google.com

Review URL: https://codereview.chromium.org/2311283002 .
2016-09-06 10:10:40 -07:00
Jacob Richman 38724f0626 Update web_command code so that it continues to use the legacy module loader. Drive by removal of misleading comments.
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2303163002 .
2016-09-06 09:57:05 -07:00
Carlo Bernaschina cfefe97495 Converted Observatory metrics-page element
Major restyle

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2303173002 .
2016-09-06 09:56:16 -07:00
Kevin Moore ca2285be58 dart:js_util - fix spelling
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/2311563002 .
2016-09-06 09:23:59 -07:00
William Hesse fa32e57693 Fix syntax error in dartium archiving script
This fixes an error introduced in
09e15a425e
https://codereview.chromium.org/2312223002

TBR=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org/2312253002 .
2016-09-06 18:22:09 +02:00
Sigmund Cherem 2503bab254 Refactor how we read global-type-inference data from ssa
R=het@google.com

Review URL: https://codereview.chromium.org/2305623004 .

Committed: a319239145
2016-09-06 09:07:25 -07:00
William Hesse 09e15a425e Add support for new dartium bots to archiver
BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org/2312223002 .
2016-09-06 17:18:24 +02:00
Florian Loitsch 70c48b9a2e Don't propagate synchronous Future.wait errors immediately.
Fixes #27249.

R=lrn@google.com

Review URL: https://codereview.chromium.org/2311923002 .
2016-09-06 11:57:43 +02:00
Florian Loitsch 6255638cd0 Return futures on Stream.cancel when possible.
Deprecate returning `null`.

Also, fixes cases where transformations on a stream didn't forward the cancel future

Fixes #26777.

BUG= http://dartbug.com/26777.
R=lrn@google.com

Review URL: https://codereview.chromium.org/2202533003 .

Committed: 395e7aaa69
Reverted: 99e5328eac
Committed: 1905ddafaa
Reverted: 46a8579c1e
2016-09-05 17:41:22 +02:00
Florian Loitsch e8a46acb2c Fix typo in headers comment.
Fixes #27240
BUG= http://dartbug.com/27240

Review URL: https://codereview.chromium.org/2313503003 .
2016-09-05 16:44:05 +02:00
Johnni Winther a47c6a240c Fix more-specific for interface types with call functions.
R=ahe@google.com

Review URL: https://codereview.chromium.org/2307873002 .
2016-09-05 10:00:26 +02:00
Brian Wilkerson 04d3701fbe Move more error detection out of Scope
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2306223002 .
2016-09-03 10:13:04 -07:00
Sigmund Cherem 38482e555f Revert "Refactor how we read global-type-inference data from ssa"
This reverts commit a319239145. There were some
tests that failed, I'll retry this again once I investigate the underlying
issue.

BUG=

Review URL: https://codereview.chromium.org/2308983002 .
2016-09-02 21:06:26 -07:00
Sigmund Cherem fc74f854e2 Fix static warning - I forgot to remove a field after all the refactorings.
TBR=sra@google.com

Review URL: https://codereview.chromium.org/2302733004 .
2016-09-02 16:55:06 -07:00
Sigmund Cherem e0c9d843b9 No longer store the compilation-context in WorkItem.
This context is pretty local to SSA and just needs to be plumbed from the
builder through the optimizers. This way we don't have reference to this context
anywhere else in the compiler.

R=sra@google.com

Review URL: https://codereview.chromium.org/2302363003 .
2016-09-02 16:36:39 -07:00
Sigmund Cherem a319239145 Refactor how we read global-type-inference data from ssa
R=het@google.com

Review URL: https://codereview.chromium.org/2305623004 .
2016-09-02 16:24:42 -07:00
Zach Anderson 78eed0f9a2 Turn off trace_shutdown flag for Windows
Review URL: https://codereview.chromium.org/2300343004 .
2016-09-02 15:34:53 -07:00
Stephen Adams 6627720227 Rename HForeignNew -> HCreate
In preparation for adding type information as an argument to the JS constructor.

R=het@google.com

Review URL: https://codereview.chromium.org/2306203002 .
2016-09-02 15:12:33 -07:00
Carlo Bernaschina 4b328e442f Added service protocol cross-origin access from localhost for http requests
Related to e6e61332d6

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2308083002 .
2016-09-02 13:59:56 -07:00
Konstantin Shcheglov 2e1c75d809 Issue 27221. Report UNQUALIFIED_REFERENCE_TO_NON_LOCAL_STATIC_MEMBER for staticField.method() in subclasses.
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27221

Review URL: https://codereview.chromium.org/2304293002 .
2016-09-02 12:48:32 -07:00
Konstantin Shcheglov 9512e3f88c RESOLVED_UNIT2 and RESOLVED_UNIT3 can be reused.
With incremental invalidation directives don't change, so we can
reuse these results too. So, it is worth to keep some number of them in
the cache.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2303213003 .
2016-09-02 12:45:58 -07:00
Konstantin Shcheglov ad9db24430 Set 'AnalysisContext.name' to path in ContextBuilder.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2306173002 .
2016-09-02 12:42:58 -07:00
Stephen Adams 9477f7e1e2 Move congruent type variables optimization out of builder into simplifier
BUG=
R=het@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org/2305583005 .
2016-09-02 11:50:48 -07:00
Harry Terkelsen 7502743614 kernel -> ssa: implement if-statements
As part of this change I refactored SsaBranchBuilder to accept a
GraphBuilder argument so that it can work with the new kernel builder.

I also had to add a LocalsHandler accessor to the GraphBuilder.

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2301293002 .
2016-09-02 11:32:49 -07:00
Carlo Bernaschina 62114cee60 Added service protocol cross-origin access from localhost for http requests
Related to e6e61332d6

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2295343006 .
2016-09-02 11:17:11 -07:00
Carlo Bernaschina bc5a41edf8 Fixed crash of Observatory class-view element
Fixes=https://github.com/dart-lang/sdk/issues/27222

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2308003002 .
2016-09-02 11:12:44 -07:00
Stephen Adams 1201bd5528 Dynamicize some mixin type tests
Add dynamic cases to some recent problem tests where dart2js now
optimizes away the type tests.

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2302173003 .
2016-09-02 11:08:06 -07:00
Zachary Anderson 82062f1d95 DBC: Add Android Product build
R=fschneider@google.com

Review URL: https://codereview.chromium.org/2303383002 .
2016-09-02 11:01:51 -07:00
James Robinson 713b392e6b Fix build: mx_handle_get_info -> mx_object_get_info.
R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/2308673002 .
2016-09-02 11:00:00 -07:00
Stephen Adams 921eac74cf Rename $builtinType to $ti
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2306813003 .
2016-09-02 10:53:26 -07:00
Carlo Bernaschina c38769ea9a Converted Observatory timeline-page element
Not fully testable

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2299613004 .
2016-09-02 10:38:40 -07:00
Carlo Bernaschina 2eab4de315 Converted Observatory logging-page element
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2299893003 .
2016-09-02 10:27:48 -07:00
Carlo Bernaschina b31829db24 Converted Observatory json-view element
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2305693003 .
2016-09-02 10:23:29 -07:00
Zach Anderson d640f6ae49 Turn on trace shutdown flag on Windows
There are flaky crashes on the Windows bots that look like they are
happening during shutdown. Temporarily turn on the trace shutdown flag
to help investigate.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2308653002 .
2016-09-02 10:12:53 -07:00
Ryan Macnak 7c74db24ca The psuedo-objects are not instances: give them cids above kInstanceCid.
R=asiva@google.com

Review URL: https://codereview.chromium.org/2301143002 .
2016-09-02 09:34:39 -07:00
Brian Wilkerson 677ef00534 Fix recently introduced strong mode errors
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2302993003 .
2016-09-02 09:08:21 -07:00
William Hesse b39fa1d58d Update status for chrome 53 on linux
BUG=

Review URL: https://codereview.chromium.org/2303263002 .
2016-09-02 14:08:42 +02:00
William Hesse 8c096d6dab Update dependencies in third-party/packages
BUG=
R=lrn@google.com

Review URL: https://codereview.chromium.org/2300363002 .
2016-09-02 13:26:58 +02:00
Johnni Winther 380c0bf3cb Make Enqueuer a pure interface.
R=sra@google.com

Review URL: https://codereview.chromium.org/2289353003 .
2016-09-02 09:00:12 +02:00
Stephen Adams 97842f7fc5 Rerun formatter on dartjs except kernel and shared_messages
BUG=

Review URL: https://codereview.chromium.org/2301953003 .
2016-09-01 20:55:52 -07:00
Stephen Adams 0b041d02c6 Fold HTypeInfoReadVariable of instance creation.
This often replaces an expensive substitution read with a re-use of an indexed read, e.g.:

    t1 = H.setRuntimeTypeInfo(
        new H.WhereIterable(
            t1,
            new Q.CompositeView_removeChild_closure(view)),
        [H.getTypeArgumentByIndex(t1, 0)]);
    this.childViews = P.List_List$from(
        t1,
        true,
        H.getRuntimeTypeArgument(t1, "Iterable", 0));

---->

    t2 = H.getTypeArgumentByIndex(t1, 0);
    this.childViews = P.List_List$from(
        H.setRuntimeTypeInfo(
            new H.WhereIterable(
                t1,
                new Q.CompositeView_removeChild_closure(view)),
            [t2]),
        true,
        t2);

R=sigmund@google.com

Committed: b43ac92770

Reverted:  c3c5ee8c0a

Committed: 5b2e0a19fc

Reverted:  ba11ae416f
These test start passing, but only when optimized:
  language/mixin_regress_13688_test
  language/regress_18713_test

Review URL: https://codereview.chromium.org/2272923002 .
2016-09-01 19:31:09 -07:00
Stephen Adams d72c3f6db6 co19/LibTest/typed_data/Float32x4List/lastWhere_A02_t01 fails
See https://github.com/dart-lang/co19/issues/78

TBR=whesse@google.com

Review URL: https://codereview.chromium.org/2304773002 .
2016-09-01 18:42:18 -07:00
Paul Berry 94309733cd Revert "Remove unnecessary hide clauses"
The `Resource` class wasn't removed from the SDK until version
1.20.0-dev.0.0, which was only recently published.  Reverting this
change to allow people using older SDK releases a little more time to
upgrade.

This reverts commit 2cdafd82c2.

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2299243002 .
2016-09-01 16:08:43 -07:00
Vijay Menon df832444ed Skip flaky (timeout) test
TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2298883005 .
2016-09-01 16:02:51 -07:00
Ryan Macnak 5f2ea64b13 Remove dead code for writing ICData entries.
R=cbernaschina@google.com

Review URL: https://codereview.chromium.org/2307673002 .
2016-09-01 15:58:32 -07:00
Siva Annamalai 63f1261064 Update status file for issue 27225.
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2301263002 .
2016-09-01 15:57:39 -07:00
Stephen Adams e79f66ac06 LibTest/typed_data/Float32x4List/reduce_A01_t01 has type error
See: https://github.com/dart-lang/co19/issues/78

TBR=whesse@google.com

Review URL: https://codereview.chromium.org/2303973002 .
2016-09-01 15:54:23 -07:00
Stan Manilov 7ee54976be Check for non-null assignment when checking casts
The correct behaviour is to check for non-null assignment every time we
check for downcasts, so I moved the invocation.

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2302573003 .
2016-09-01 15:25:24 -07:00