languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 12:48:10 +00:00
Code Issues Packages Projects Releases Wiki Activity
83784 commits 11 branches 6011 tags 1.4 GiB
Commit graph

83784 commits

This branch
This branch
All branches
Author SHA1 Message Date
Sam Rawlins 50b6c83c09 Bump html to avoid dynamic casts 
Change-Id: I43cd0deb5723235847010c710b1cfd87acfdf122
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232222
Auto-Submit: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
 2022-02-09 19:38:46 +00:00
Samuel Rawlins 53b8c768be Revert "Bump csslib; avoid dynamic calls" 
This reverts commit 0c3ddc6f13.

Reason for revert: broke presubmit in google3 https://fusion2.corp.google.com/invocations/093bd78f-1894-4c15-ae7a-06d6ad7458bd/targets/%2F%2Fplay%2Fconsole%2Fui%2Facx_apps%2Fhost_app%2Fshell:app/log

Original change's description:
> Bump csslib; avoid dynamic calls
>
> Change-Id: I6d7a510d58cecce4670a1570c6ab8f2838c6ae50
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232180
> Reviewed-by: Kevin Moore <kevmoo@google.com>
> Commit-Queue: Samuel Rawlins <srawlins@google.com>

TBR=kevmoo@google.com,srawlins@google.com

Change-Id: I370970cdae695842d81da73592c40aed33abb4e1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232201
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-02-09 19:22:12 +00:00
Konstantin Shcheglov 96f5385295 Tests for searching enum children in analysis_server. 
Change-Id: I52b43a606cdac5165aa5ddd6c97741f276c1ebf7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232221
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-09 19:12:56 +00:00
Konstantin Shcheglov be0c8560b4 Search for enum children. 
Change-Id: Id6ab2860f6a88b3b1f747ad8a63045e91e3a0309
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232220
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-09 17:59:56 +00:00
Lasse R.H. Nielsen 4e8d0fee9d Documentation update for Enum class 
Examples added

Closes https://github.com/dart-lang/sdk/pull/48155
https://github.com/dart-lang/sdk/pull/48155

GitOrigin-RevId: 70fb8c1a33072f859f10e3079d13aa0afc3e6d24
Change-Id: Id85fd642f4b3e95207c0542e54256be77120f84d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228440
Reviewed-by: Lasse Nielsen <lrn@google.com>
Commit-Queue: Lasse Nielsen <lrn@google.com>
 2022-02-09 17:50:06 +00:00
Joshua Litt 663d682ab3 [dart2js] Remove pkg/compiler/lib/src/helpers. 
Most of these tools have been replaced by better tools.

We may re-add some of these in the future, but if so then maybe they should live in pkg/compiler/tool.

Change-Id: I673dd27dafad59cc01b0be0705c2032c11fca713
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231980
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Joshua Litt <joshualitt@google.com>
 2022-02-09 17:21:46 +00:00
Sam Rawlins 0c3ddc6f13 Bump csslib; avoid dynamic calls 
Change-Id: I6d7a510d58cecce4670a1570c6ab8f2838c6ae50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232180
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-02-09 17:14:07 +00:00
Michael Thomsen 34b3382e21 Remove a few uses of bin/pub 
Change-Id: Ie21ecb4ddedf8b5f3d10019525fe1b62992812b1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232094
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
 2022-02-09 17:13:37 +00:00
Alexander Aprelev 6b830c4428 [vm/isolate/spawn] Ensure spawnFunction sends closure so type args are preserved. 
Fixes https://github.com/dart-lang/sdk/issues/48035

TEST=spawn_generic_function_test

Change-Id: I28d0ea9123bd31cb1aa288824c3c7688fc2ca8f1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232160
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2022-02-09 16:49:49 +00:00
Konstantin Shcheglov f481cbf2fa Use IS_INVOKED_BY_ENUM_CONSTANT_WITHOUT_ARGUMENTS 
Change-Id: I870ece21708c1e96bf8b3bd4d4373ca6bdade9cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232133
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-09 16:16:56 +00:00
Konstantin Shcheglov 1acf0dce85 Report ENUM_INSTANTIATED_TO_BOUNDS_IS_NOT_WELL_BOUNDED 
Change-Id: I4cef975da984b9bf1da64008292864b716b13e8f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232128
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-09 16:13:06 +00:00
Konstantin Shcheglov 29d364dfd4 Report VALUES_DECLARATION_IN_ENUM 
Change-Id: I8efc240b5bd2740a457eb373bece31afab3c7525
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232130
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-09 15:53:36 +00:00
Konstantin Shcheglov 4e2dc38e0e Report CONST_WITH_NON_CONSTANT_ARGUMENT for enums. 
Bug: https://github.com/dart-lang/sdk/issues/48237

Change-Id: Iffde67714dcea7b022b22a149b573dd3e26668b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232132
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-09 15:53:27 +00:00
Alexander Thomas a4da39f702 [co19] Roll co19 to 0d38c8081e4da585262ed08ddde3dd85dc779dba 
2022-02-07 irina.arkhipets@gmail.com dart-lang/co19#1260: Moved Weak Reference tests to LanguageFeatures/WeakReference directory. Added tests for Finalizer constructor.
2022-02-06 sgrekhov@unipro.ru Fixes dart-lang/co19#1287. Typos fixed
2022-02-04 sgrekhov@unipro.ru dart-lang/co19#1260. WeakReference tests added
2022-02-04 sgrekhov@unipro.ru Fixes dart-lang/co19#1286. Expect an error if mixin application on enum introduces anyv instance variables
2022-02-03 sgrekhov@unipro.ru dart-lang/co19#1285. One more roll failure fixed
2022-02-03 sgrekhov@unipro.ru dart-lang/co19#1285. Roll failures fixed, issue numbers added
2022-02-02 sgrekhov@unipro.ru dart-lang/co19#1260. GC utils library added
2022-02-01 sgrekhov@unipro.ru dart-lang/co19#1260. WeakReferences tests for Expando key added
2022-01-31 sgrekhov@unipro.ru dart-lang/co19#1258. More Enhanced Enums semantics tests added
2022-01-31 sgrekhov@unipro.ru dart-lang/co19#1281. Expected error location updated
2022-01-31 sgrekhov@unipro.ru Fixes dart-lang/co19#1284. Test changed to allow ; after identifier list
2022-01-31 sgrekhov@unipro.ru Fixes dart-lang/co19#1283. Typos fixed
2022-01-31 sgrekhov@unipro.ru Fixes dart-lang/co19#1282. Typo fixed
2022-01-27 sgrekhov@unipro.ru dart-lang/co19#1258. More Enhanced Enums semantics tests added
2022-01-26 sgrekhov@unipro.ru dart-lang/co19#1258. More Enhanced Enums semantics tests added
2022-01-25 sgrekhov@unipro.ru Fixes dart-lang/co19#1258. More Enhanced Enums semantics tests added
2022-01-25 sgrekhov@unipro.ru dart-lang/co19#1280. Roll failure fixed

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: Iae324aa5e53c3f34b630958410a1f1b4a48f64ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231941
Reviewed-by: William Hesse <whesse@google.com>
 2022-02-09 14:56:42 +00:00
Michael Thomsen 9a4b994232 Add older security advisories to changelog 
Change-Id: I79a6d2065b7b2043401ee648a7238b8563729aff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232084
Reviewed-by: Alexander Thomas <athom@google.com>
 2022-02-09 13:41:52 +00:00
William Hesse 5b13e5816e Remove check for standalone pub from linux distribution support 
Copying the pub standalone to the linux Debian package is disabled
in a different CL to the one that was reverted to restore the standalone.

Bug: https://github.com/dart-lang/pub/issues/3292
Change-Id: I276a610dcb3eae2687fd637f59b3206ab7dce6e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232093
Reviewed-by: Alexander Thomas <athom@google.com>
 2022-02-09 13:13:44 +00:00
Sai Sandeep Mutyala 3de72ec6b0 Add fix for sort_unnamed_constructors_first lint. 
Change-Id: I08decb3d05612d0899c570597ce0a3b8e1eb1c02
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231900
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-09 06:51:07 +00:00
Joshua Litt 21a5f73456 [dart2js] Cleanup ImpactCacheDeleter. 
This cl mostly just removes indirection around clearing the Impact cache.
However, there is one minor logic change, today we clear the impact cache
before calling DeferredLoadTask._buildResult, but after this cl the
impact cache is cleared by its owner(Compiler) in the compiler pipeline
itself.

Change-Id: I5845b786887f861c61a0ac79a3c8f2de2a3a2a14
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232026
Reviewed-by: Mark Zhou <markzipan@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Joshua Litt <joshualitt@google.com>
 2022-02-09 02:28:41 +00:00
Siva Annamalai d858c6aa44 Revert "Reland "Remove the pub top-level"" 
This reverts commit 7bb6841815.

Reason for revert: Flutter rolls are failing, please see https://github.com/flutter/engine/pull/31332

Original change's description:
> Reland "Remove the pub top-level"
>
> This is a reland of 872ffa85c2
>
> Original change's description:
> > Remove the pub top-level
> >
> > The old pub toplevel interface is still reachable via
> >
> > ```
> >  $ dart __deprecated_pub
> > ```
> >
> > That is what `flutter pub` is using.
> >
> > Part of https://github.com/dart-lang/sdk/issues/46100
> >
> > Bug: https://github.com/dart-lang/pub/issues/3292
> > Change-Id: I97a14f2458d0f67c7bf98a90664d504cfaba0e98
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229541
> > Reviewed-by: Jonas Jensen <jonasfj@google.com>
> > Reviewed-by: Michael Thomsen <mit@google.com>
> > Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
>
> Bug: https://github.com/dart-lang/pub/issues/3292
> Change-Id: I45b5bf93f30c8abad4558cb15b61289c6c786f65
> Cq-Include-Trybots: luci.dart.try:flutter-engine-linux-try,flutter-engine-linux-web_tests-try,flutter-frontend-try
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231943
> Reviewed-by: Jonas Jensen <jonasfj@google.com>
> Reviewed-by: Michael Thomsen <mit@google.com>
> Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: https://github.com/dart-lang/pub/issues/3292
Change-Id: Ie64d894efac2b5d686f470e2465819c74dd917ff
Cq-Include-Trybots: luci.dart.try:flutter-engine-linux-try,flutter-engine-linux-web_tests-try,flutter-frontend-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232131
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2022-02-09 01:59:36 +00:00
Joshua Litt ef02841083 [dart2js] Cleanup NativeEnqueuer. 
This cl removes an unnecessary concrete interface, and makes the
existing base class abstract.

Change-Id: I41891a7b3c57008de05a7c4a20a70452983ab441
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232125
Reviewed-by: Mayank Patke <fishythefish@google.com>
Commit-Queue: Joshua Litt <joshualitt@google.com>
 2022-02-09 01:01:37 +00:00
David Williston 07d41c68a6 fix a typo 
Closes https://github.com/dart-lang/sdk/pull/48253
https://github.com/dart-lang/sdk/pull/48253

GitOrigin-RevId: 60412c30bce67f8e70735ea05414dfea3f16e50b
Change-Id: I1521a4dd831bba2dd1e488c6f076e788848480fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232129
Reviewed-by: Michael Thomsen <mit@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
 2022-02-08 22:31:46 +00:00
Riley Porter 278a040e1d Add WeakReference and Finalizer patches for ddc and dart2js 
Routes implementation to JavaScript WeakRef and
FinalizerRegistry APIs using JS foreign function calls. Uses
Wrapper names for the Dart library to avoid issues with DDC.

Bug: #47775, #47776
Change-Id: Iad82bd83ac10c666d08a2c042a8ed6109b8b58c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229180
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Riley Porter <rileyporter@google.com>
 2022-02-08 22:01:36 +00:00
Nate Bosch 33e174084a Replace Uri.scheme == with Uri.isScheme 
Use `hasScheme` in place of comparing against the empty string, and
`isScheme` to compare against all other schemes.

TEST=No behavior changes.

Change-Id: Ifc9fd13c6cf37933ebd4a754c4b500dedbcb291b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231185
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
 2022-02-08 21:38:57 +00:00
Konstantin Shcheglov 7282a40c49 Report ILLEGAL_LANGUAGE_VERSION_OVERRIDE even when the package language version causes it. 
Change-Id: I617d67ba06758e3f57d9ff0048a080d0a699fc96
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232126
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-08 21:23:46 +00:00
Martin Kustermann 5b1a22f4fc [vm] Use identical() instead of == in assert() 
This is a follow-up to https://dart-review.googlesource.com/c/sdk/+/231704

TEST=ci

Change-Id: I6c15180fa5c3d242b303cb9fd0ca65c112b40702
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232086
Reviewed-by: Lasse Nielsen <lrn@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2022-02-08 20:44:26 +00:00
Polina 3f1dfdc8be Move configuration to separate section to make it easier to discover. 
Change-Id: I70ef83de107388e732f3e2eda16511b663ac57ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230959
Reviewed-by: Slava Egorov <vegorov@google.com>
Commit-Queue: Polina Cherkasova <polinach@google.com>
 2022-02-08 20:36:46 +00:00
Stephen Adams f85a44cea6 [benchmarks] Add noise to BigIntPrintParse fake results 
Change-Id: I1cce5d8066255b489fd4c51395462183cac9728f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/227362
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2022-02-08 20:24:16 +00:00
Konstantin Shcheglov d8e2cdaeec Report WRONG_NUMBER_OF_TYPE_ARGUMENTS_ENUM and TYPE_ARGUMENT_NOT_MATCHING_BOUNDS for enums. 
Change-Id: Icac828fa09d7565974727521c27b5cd4daa7e0f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232089
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-08 19:50:36 +00:00
Michael Thomsen 10bcd86677 Add link to published advisories 
Change-Id: I2dcfa85c166f5c3c886e6f90b6c3c51ecb6497f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232085
Reviewed-by: Alexander Thomas <athom@google.com>
 2022-02-08 19:45:07 +00:00
Helin Shiah ba50128769 Add script location to generated code message 
The previous message added to Java generated code was not helpful for finding the generating code.

TEST=N/A

Change-Id: Ie60202ac68e8790a422a47c6edfd75997cf32145
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232024
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-02-08 19:44:40 +00:00
Sam Rawlins 23b954f067 Bump dartdoc to b3927dd89d6ff9c78dc88ab2901e63b6a3bf29b7 
This includes a fix for https://github.com/dart-lang/dartdoc/issues/2934

google3 has been running with this commit for over a week.

Change-Id: Ice86344f9fcf6503ad0c4d71fddd71bd292ca1bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232088
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-02-08 19:37:58 +00:00
Stephen Adams 8d335e5e08 [lib/collection] Test for #48282 
Change-Id: I62306feab09f8dcd0335daa296b6c744bc139e62
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231336
Reviewed-by: Lasse Nielsen <lrn@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2022-02-08 19:36:38 +00:00
Parker Lougheed e31691b47f Update outdated old or removed dart.dev links 
Removes reference to web portion of site-www as it is minimal and not standalone anymore.

Change-Id: I62e92d0dd90afffa5d90c3f3fd4e903251c5672b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229280
Reviewed-by: Michael Thomsen <mit@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
 2022-02-08 19:29:56 +00:00
Alexander Markov 0cf751215e [vm] Correct token position for AssertAssignable in implicit field setters 
The real token position is required in case debugger stopped on
an exception thrown from AssertAssignable and trying to evaluate
an expression which uses receiver. Without token position all local
variables (including receiver) are considered out of scope
(as frame's token position is out of range).

TEST=runtime/observatory/tests/service/regress_48279_test.dart
Fixes https://github.com/dart-lang/sdk/issues/48279

Change-Id: Idb6a8e12185367ceac2034269b8f046272384006
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231748
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2022-02-08 19:28:36 +00:00
Kenzie Schmoll deb9cd31e7 Add missing 'help' option to DevTools server arg parser. 
This option existed in the previous impl of devtools server: https://github.com/flutter/devtools/blob/v2.10.0/packages/devtools_server/lib/src/server.dart#L507-L516

Change-Id: Icdc2f1b29e9128531a51fbc471c7b52e761e8f31
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232122
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com>
 2022-02-08 19:15:56 +00:00
Konstantin Shcheglov f6ebb50359 Report ENUM_CONSTANT_WITH_NON_CONST_CONSTRUCTOR 
Change-Id: I3962553ccaa881db761e87fdd97ce47a65db4b2e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232124
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-08 19:15:28 +00:00
Konstantin Shcheglov 62488444c9 Report INVALID_REFERENCE_TO_GENERATIVE_ENUM_CONSTRUCTOR for factory redirections. 
Change-Id: I02f6f3f374cd00b24722b8eb5498aaab33b1a7fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232121
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-08 17:25:06 +00:00
Konstantin Shcheglov ed2ae85bfe Remove deprecated AnalysisDriver.tmp1() 
Change-Id: Ie05f71eabfdc81ce80264581d751c1ae9391bce7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232035
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-08 17:21:36 +00:00
Danny Tuppeny afe70b7432 [analysis_server] Reduce the scope of a non-null-assertion to prevent errors during large renames 
This assertion is not sound and needs removing, but that requires additional changes to ensure callers (including plugins) provide line/col information. This change reduces the chance of it triggering (by avoiding it being used for context messages) in the meantime.

Change-Id: I73c861b69a795212ae0d59e30da6aa6bdd1bb3af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232082
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-08 16:47:56 +00:00
Konstantin Shcheglov 7daffa9e47 Remove hasAssignmentLeftResolution, check assignment targets are not resolved. 
Change-Id: Iae73b698b696257298f06c581cb80367f4309816
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232034
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-08 16:16:16 +00:00
Konstantin Shcheglov 1d7d5a6dcf Verify the number and types of enum constant arguments. 
Change-Id: Id51ca6081bb9a1ab85217457bca67cae8adce710
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232033
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-08 16:16:06 +00:00
Jonas Termansen 6f2ed354ee [infra] Support experimental builds in debian package upload. 
Bug: b/218297815
Change-Id: I39590d28402d7edf9e1533d5cb0a58124e339c23
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232081
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
 2022-02-08 11:39:46 +00:00
Alexander Thomas b285d2103c [release] Add 2.16.1 release notes 
Change-Id: Ic18526494e48e61315937f1008294dc4afd35aa5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232080
Reviewed-by: Slava Egorov <vegorov@google.com>
 2022-02-08 10:18:48 +00:00
Joshua Litt 6a7470f530 [dart2js] Remove unused compile_time_constants.dart. 
Change-Id: I4a574ac615aabaf63d7bf3e241fc969766f03cf8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232030
Reviewed-by: Mayank Patke <fishythefish@google.com>
Commit-Queue: Joshua Litt <joshualitt@google.com>
 2022-02-08 04:10:56 +00:00
Konstantin Shcheglov 6bcc451e59 Report DUPLICATE_DEFINITION for 'values' in enums. 
Change-Id: I0df2f7286e8913b3a323fd19bb18a8d77f27bbe6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232025
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-08 01:49:35 +00:00
Konstantin Shcheglov cc93c8815b Tests for indexing enum children. 
Change-Id: I76b7369a5ba2e7c3cb799694f21dee95eebf125f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232028
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-08 00:24:45 +00:00
Nate Bosch 59d4a6a0a4 Update to the latest package:glob 
R=kevmoo@google.com

Change-Id: Icdf4ade918abf989f36d263b6e251ae85a49dbea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231329
Auto-Submit: Nate Bosch <nbosch@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
 2022-02-07 23:48:24 +00:00
Konstantin Shcheglov 63f34ab810 Report UNDEFINED_ENUM_CONSTRUCTOR_NAMED/UNNAMED 
Change-Id: I02b8a2d9d3988cc0c281a8d251b9670e378b3561
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232023
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-07 23:27:14 +00:00
Brian Quinlan 085e978ce4 Fix on Windows, renaming a file using the Directory class generates an incorrect exception 
TEST=unit
Bug: https://github.com/dart-lang/sdk/issues/47713
Change-Id: I603a452cece478ad5ddd85d47e9cfe02cee3f4d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231801
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Brian Quinlan <bquinlan@google.com>
 2022-02-07 23:15:56 +00:00
Brian Wilkerson 867e155ff6 Merge two error codes 
I was thinking about unifying these two codes for documentation purposes,
but then I wondered whether we might not want to unify them for reporting
purposes too. The reason I think it might be better to unify them is
because (a) they really represent a single problem (missing required
arguments) and (b) we were previously reporting the same problem multiple
times.

Change-Id: Iecf2865e67d61b03a1e1f56781e94e283d2a08e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232022
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-07 23:10:06 +00:00