languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-01 17:52:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Move configuration to separate section to make it easier to discover.

Browse source 
Change-Id: I70ef83de107388e732f3e2eda16511b663ac57ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230959
Reviewed-by: Slava Egorov <vegorov@google.com>
Commit-Queue: Polina Cherkasova <polinach@google.com>
This commit is contained in:
Polina 2022-02-08 20:36:46 +00:00 committed by Commit Bot
parent f85a44cea6
commit 3f1dfdc8be
1 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
CONTRIBUTING.md
View file

@ -20,9 +20,13 @@ Before we can use your code, you must sign the [Google Individual Contributor Li
Before you start working on a larger contribution, you should get in touch with us first through the [Dart Issue Tracker](https://dartbug.com) with your idea so that we can help out and possibly guide you. Coordinating up front makes it much easier to avoid frustration later on.
All submissions, including submissions by project members, require review. We use the same code-review tools and process as the chromium project. In order to submit a patch, you need to get the [depot\_tools](http://dev.chromium.org/developers/how-tos/depottools).
All submissions, including submissions by project members, require review. We use the same code-review tools and process as the chromium project.
We occasionally take pull requests, e.g., for comment changes, but the main flow is to use the Rietveld review system as explained below.
We occasionally take pull requests, e.g., for comment changes, but the main flow is to use the Gerrit review system as explained below.
## Setting up Environment
In order to submit a patch, you need to get the [depot\_tools](http://dev.chromium.org/developers/how-tos/depottools).
## Getting the code
@ -69,7 +73,9 @@ Upload the patch for review:
git cl upload -s
```
The above command returns a URL for the review. Attach this review to your issue in https://dartbug.com
The above command returns a URL for the review. Attach this review to your issue in https://dartbug.com.
To update the cl, just commit your changes and run `git cl upload -s` for your branch.
If you have commit access, when the review is done and the patch is good to go, submit the patch on https://dart-review.googlesource.com: