languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-04 17:25:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

[dart2js] Cleanup NativeEnqueuer.

Browse source 
This cl removes an unnecessary concrete interface, and makes the
existing base class abstract.

Change-Id: I41891a7b3c57008de05a7c4a20a70452983ab441
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232125
Reviewed-by: Mayank Patke <fishythefish@google.com>
Commit-Queue: Joshua Litt <joshualitt@google.com>
This commit is contained in:
Joshua Litt 2022-02-09 01:01:37 +00:00 committed by Commit Bot
parent 07d41c68a6
commit ef02841083
1 changed files with 13 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

44
pkg/compiler/lib/src/native/enqueue.dart
View file

@ -14,33 +14,11 @@ import '../universe/world_impact.dart'
import 'behavior.dart';
import 'resolver.dart' show NativeClassFinder;
/// This could be an abstract class but we use it as a stub for the
/// dart_backend.
class NativeEnqueuer {
/// Called when a [type] has been instantiated natively.
void onInstantiatedType(InterfaceType type) {}
/// Initial entry point to native enqueuer.
WorldImpact processNativeClasses(Iterable<Uri> libraries) =>
const WorldImpact();
/// Registers the [nativeBehavior]. Adds the liveness of its instantiated
/// types to the world.
void registerNativeBehavior(
WorldImpactBuilder impactBuilder, NativeBehavior nativeBehavior, cause) {}
/// Returns whether native classes are being used.
bool get hasInstantiatedNativeClasses => false;
/// Emits a summary information using the [log] function.
void logSummary(void log(String message)) {}
}
abstract class NativeEnqueuerBase implements NativeEnqueuer {
abstract class NativeEnqueuer {
final Set<ClassEntity> _registeredClasses = {};
final Set<ClassEntity> _unusedClasses = {};
@override
/// Returns whether native classes are being used.
bool get hasInstantiatedNativeClasses => !_registeredClasses.isEmpty;
/// Log message reported if all native types are used.
@ -52,18 +30,21 @@ abstract class NativeEnqueuerBase implements NativeEnqueuer {
final CommonElements _commonElements;
/// Subclasses of [NativeEnqueuerBase] are constructed by the backend.
NativeEnqueuerBase(this._options, this._elementEnvironment,
this._commonElements, this._dartTypes);
NativeEnqueuer(this._options, this._elementEnvironment, this._commonElements,
this._dartTypes);
bool get enableLiveTypeAnalysis => _options.enableNativeLiveTypeAnalysis;
@override
/// Called when a [type] has been instantiated natively.
void onInstantiatedType(InterfaceType type) {
if (_unusedClasses.remove(type.element)) {
_registeredClasses.add(type.element);
}
}
/// Initial entry point to native enqueuer.
WorldImpact processNativeClasses(Iterable<Uri> libraries);
/// Register [classes] as natively instantiated in [impactBuilder].
void _registerTypeUses(
WorldImpactBuilder impactBuilder, Set<ClassEntity> classes, cause) {
@ -79,7 +60,8 @@ abstract class NativeEnqueuerBase implements NativeEnqueuer {
}
}
@override
/// Registers the [nativeBehavior]. Adds the liveness of its instantiated
/// types to the world.
void registerNativeBehavior(
WorldImpactBuilder impactBuilder, NativeBehavior nativeBehavior, cause) {
_processNativeBehavior(impactBuilder, nativeBehavior, cause);
@ -169,7 +151,7 @@ abstract class NativeEnqueuerBase implements NativeEnqueuer {
});
}
@override
/// Emits a summary information using the [log] function.
void logSummary(void log(String message)) {
if (_allUsedMessage != null) {
log(_allUsedMessage);
@ -177,7 +159,7 @@ abstract class NativeEnqueuerBase implements NativeEnqueuer {
}
}
class NativeResolutionEnqueuer extends NativeEnqueuerBase {
class NativeResolutionEnqueuer extends NativeEnqueuer {
final NativeClassFinder _nativeClassFinder;
/// The set of all native classes. Each native class is in [nativeClasses]
@ -219,7 +201,7 @@ class NativeResolutionEnqueuer extends NativeEnqueuerBase {
}
}
class NativeCodegenEnqueuer extends NativeEnqueuerBase {
class NativeCodegenEnqueuer extends NativeEnqueuer {
final CodeEmitterTask _emitter;
final Iterable<ClassEntity> _nativeClasses;
final NativeData _nativeData;