Commit graph

42728 commits

Author SHA1 Message Date
Florian Loitsch
1780f8dbc4 Update links to point to sdk-repo. (#27582)
Some links were still pointing to the old repository.
2016-11-23 16:37:26 +01:00
Alexandre Ardhuin
3f1720069a Add a note on the README of js package (#27701) 2016-11-23 16:36:54 +01:00
Asger Feldthaus
d056236180 Enable strong-mode for pkg/kernel and fix some strong-mode warnings.
BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org/2523673005 .
2016-11-23 16:16:37 +01:00
Asger Feldthaus
5d310431bd Remove closure_conversion.dart from pkg/kernel.
This file is not strong-mode clean, but since a more recent version
of closure conversion still exists in a branch on the kernel github
repo, there is not much point in fixing this version of it.

BUG=
R=ahe@google.com

Review URL: https://codereview.chromium.org/2526793002 .
2016-11-23 15:34:35 +01:00
Asger Feldthaus
f13881ac08 Fix the pubspec and warnings in pkg/kernel.
BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org/2530543002 .
2016-11-23 14:36:22 +01:00
Asger Feldthaus
b0ffc26dab Fix vm-kernel status file after merging kernel.
The buildbots run tests against the checked-in version of analyzer,
not the one in the pubspec, which is why the tests behave differently.

BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org/2524973002 .
2016-11-23 14:19:34 +01:00
Asger Feldthaus
ac21874a21 Disable kernel unit tests.
They are causing issues on dartium and dart2js_jsshell.

BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org/2528623002 .
2016-11-23 14:12:54 +01:00
Asger Feldthaus
ce428a1f20 Complete merge of kernel repo into SDK.
This removes third_party/pkg/kernel and changes dependencies to
refer to pkg/kernel instead.

Some status files are updated to reflect new test outcomes.
2016-11-23 12:46:29 +01:00
Asger Feldthaus
a45478f271 Merge the kernel repository into the main SDK.
This brings in the kernel repository from github/dart-lang/kernel,
containing the Dart implementation of Kernel, not to be confused with
the SDK fork that contained the VM changes.

Commit messages from the old repository have been preserved and
prefixed with [kernel].

Kernel now lives in pkg/kernel instead of third_party/pkg/kernel.
References to the old location will be updated in the next commit.

Binary files have been stripped from the history, which breaks
some of kernel's unit tests. These tests have been disabled and
will be fixed later.
2016-11-23 12:24:49 +01:00
Erik Ernst
7809d25b92 Remove the ability in dart2js to turn off syntax-only generic methods.
This CL removes all the checks for 'enableGenericMethodSyntax' in the
implementation, which takes away the ability to turn this feature off
and simplifies the code.

As a result, `ParserOptions` is now empty; we may want to remove it,
but this CL does not do that.

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2521073003 .
2016-11-23 12:16:30 +01:00
Asger Feldthaus
2eb09d26e3 [kernel] Update and disable some kernel unit tests.
This is in preparation of merging into the SDK repository.
2016-11-23 12:14:59 +01:00
Martin Kustermann
2c9cbb1d2c VM: [Kernel] Go back to previous behavior in loader.cc
Review URL: https://codereview.chromium.org/2523183002 .
2016-11-23 10:55:59 +01:00
William Hesse
4bfe727db6 Update status for Firefox 50
BUG=https://github.com/dart-lang/sdk/issues/27873
BUG=https://github.com/dart-lang/sdk/issues/27872
BUG=https://github.com/dart-lang/sdk/issues/27871
BUG=https://github.com/dart-lang/sdk/issues/27867
R=sortie@google.com

Review URL: https://codereview.chromium.org/2526493004 .
2016-11-23 09:49:01 +01:00
Martin Kustermann
1aff626804 VM: [Kernel] Split kernel API into 3 steps: ([read binary], parse-binary, bootstrap, load program)
This avoids reading and parsing the kernel binary multiple times and avois
having it multiple times in memory (we don't free the 'kernel::Program*' object
ATM).

R=kmillikin@google.com

Review URL: https://codereview.chromium.org/2525623002 .
2016-11-23 09:26:15 +01:00
Martin Kustermann
656be7a7aa Update status file for kernel
Review URL: https://codereview.chromium.org/2525883002 .
2016-11-23 08:58:18 +01:00
Martin Kustermann
b1c04f0538 Avoid random stacktraces being printed from tools/test.py during test runs
Previously the testing script was just printing interleaved stack traces with
all the other output. Which means it's not associatable with a single test and
is highly confusing!

This CL associates the stack trace information of tests which time out to the
particular test which timed out.

R=whesse@google.com

Review URL: https://codereview.chromium.org/2524733004 .
2016-11-23 08:39:27 +01:00
Ryan Macnak
171da0489f Fuchsia sockets:
- Remove CheckConnect.
  - Enable NODELAY.
  - Add testSimpleReadWriteClose to hello_fuchsia_test.

Add stub implementation of OS::MaxRSS so Observatory can load without crashing the target VM.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2523133002 .
2016-11-22 16:52:21 -08:00
Paul Berry
05a6045674 Rename AstFactory -> AstTestFactory.
This paves the way for introducing a new AstFactory class that will be
part of the analyzer public API.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2524903002 .
2016-11-22 16:09:51 -08:00
Todd Turnidge
193ddba4db Revert "Implement rewind: drop one or more frames from the debugger."
This reverts commit af1875be91.

BUG=

Review URL: https://codereview.chromium.org/2521413002 .
2016-11-22 16:05:26 -08:00
Todd Turnidge
af1875be91 Implement rewind: drop one or more frames from the debugger.
Not yet implemented on dbc.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2523053002 .
2016-11-22 15:26:08 -08:00
Paul Berry
e9ebfd4b39 Disable test_import_short_absolute on Windows.
Fixes #27870

R=scheglov@google.com

Review URL: https://codereview.chromium.org/2522113002 .
2016-11-22 15:18:29 -08:00
Konstantin Shcheglov
7ec65fb9ca Fix for exception duirng indexing a reference to MultiplyDefinedElement.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2529433003 .
2016-11-22 15:03:41 -08:00
John McCutchan
ea94a5dcb0 Don't pass --print_snapshot_sizes in product mode
BUG=

Review URL: https://codereview.chromium.org/2521323003 .
2016-11-22 14:47:05 -08:00
Stephen Adams
9e80530980 dart2js/kernel: Implement type literal (constant) and JS_INTERCEPTOR_CONSTANT
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2529483002 .
2016-11-22 14:44:30 -08:00
Brian Wilkerson
4e762c8dbf Fix failures caused by earlier CL
R=paulberry@google.com

Review URL: https://codereview.chromium.org/2523853002 .
2016-11-22 13:49:19 -08:00
Brian Wilkerson
1767def635 Respect the rest of the analysis-based options
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2523833002 .
2016-11-22 13:12:32 -08:00
Konstantin Shcheglov
f1f036f018 Implement 'displayName' for accessor and varaible elements in linker.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2527523002 .
2016-11-22 12:59:21 -08:00
John McCutchan
e3a8b8085f Add RETURN_NULL_ERROR to new apis
BUG=

Review URL: https://codereview.chromium.org/2524853002 .
2016-11-22 12:53:00 -08:00
Ryan Macnak
b83fb06741 Fuchsia sockets:
- Enable FDUtils::AvailableBytes.
 - Disable Socket::SetNoDelay.
 - Implement Socket::GetRemotePeer same as Linux.
 - Implement Socket::ParseAddress same as Linux.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2522923002 .
2016-11-22 12:49:01 -08:00
Konstantin Shcheglov
366e727048 Implement search for other local elements.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2529473002 .
2016-11-22 12:48:15 -08:00
Paul Berry
679e8fd9ff Respect the "allowErrors" parameter in _ResynthesizeAstTest.checkLibrary.
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2527453002 .
2016-11-22 12:46:55 -08:00
Konstantin Shcheglov
9bc4c73e2d Stop returning declaration matches from search for references.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2518183003 .
2016-11-22 12:32:51 -08:00
Brian Wilkerson
89cab97dd8 Add tests for the real generic method syntax
R=vsm@google.com

Review URL: https://codereview.chromium.org/2524463005 .
2016-11-22 12:23:26 -08:00
Konstantin Shcheglov
26307d77b6 Implement SearchEngine for the new driver.
Only search for references, and only to local variables is implemented so far.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2521363003 .
2016-11-22 12:01:52 -08:00
John McCutchan
ed47486f60 Fix gen_snapshot product mode build
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2527473002 .
2016-11-22 11:35:27 -08:00
Brian Wilkerson
e63105555b Remove uses of configuration data
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2522543007 .
2016-11-22 11:26:08 -08:00
John McCutchan
2510646aaf Wire up the stub native resolver for all libraries in gen_snapshot
Fixes https://github.com/flutter/flutter/issues/6952

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2518233003 .
2016-11-22 11:15:25 -08:00
Ryan Macnak
f98363b118 Mark standalone/io/socket_info_ipv6_test as failing on Windows.
Issue #27876

Review URL: https://codereview.chromium.org/2523813002 .
2016-11-22 11:14:46 -08:00
Jacob Richman
1b339deab2 Support lazy JS types.
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2515353003 .
2016-11-22 10:55:35 -08:00
Konstantin Shcheglov
9f1ca4a119 Make AnalysisSErver APIs to access unit/node/element asynchronous.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2526473003 .
2016-11-22 10:46:06 -08:00
Vyacheslav Egorov
2cb8640ac1 Kernel: fix -c dartkp -r dart_precompiled testing configuration.
Pass full snapshot path to the dart_precompiled_runtime executable.

BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org/2517243004 .
2016-11-22 19:34:58 +01:00
Konstantin Shcheglov
4fea218f77 Deoptimize Search - request a new resolved unit for local search.
It seems to me that it would be easier to integrate if we keep the
same search technique - search for Element references. I think any
saving can be only for local elements search. If it turns out to
be expensive, we could add priority results caching in the driver.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2521913004 .
2016-11-22 10:34:26 -08:00
Paul Berry
3a6972095f Add support for "??" to summaries.
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2514353005 .
2016-11-22 10:10:19 -08:00
Ryan Macnak
5ee71cae9d Don't include usage counters, etc in snapshots with code. If we already have code, eagerly recompiling in unlikely to have new type feedback.
Print snapshot sizes when generating an AOT snapshot from gen_snapshot (e.g., Flutter).
Remove some unnecessary symbols.
Use named constants for exit codes.
Use Log::PrintErr instead of fprintf(stderr) so we see error messages in adb logcat.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2517683002 .
2016-11-22 09:59:06 -08:00
Ryan Macnak
f62713e97c Fix app snapshots on IA32 Windows.
The file size is not rounded up after the isolate snapshot if there are no rodata/instruction pieces. The other OS's use mmap instead of read, which is apparently okay with over-reading the file.

Fixes #27786

R=asiva@google.com

Review URL: https://codereview.chromium.org/2521883002 .
2016-11-22 09:20:51 -08:00
Ryan Macnak
6c45f24fa6 Report a peer address over IPv4 as IPv4.
R=asiva@google.com

Review URL: https://codereview.chromium.org/2518263002 .
2016-11-22 09:19:08 -08:00
Brian Wilkerson
a3e1a0d395 Enable generic method support by default
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2488043002 .
2016-11-22 09:16:19 -08:00
Konstantin Shcheglov
ab0a8e775f Use single unit/node/element.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2525693002 .
2016-11-22 09:13:31 -08:00
Regis Crelier
21b6f8904c Fix dartium build (test now passes).
Review URL: https://codereview.chromium.org/2523753002 .
2016-11-22 08:49:11 -08:00
Dan Rubel
f109556fb7 remove unused DDC --package-paths options and MultiPackageResolver
R=vsm@google.com

Review URL: https://codereview.chromium.org/2527433002 .
2016-11-22 11:20:23 -05:00