Commit graph

25071 commits

Author SHA1 Message Date
Peter Eisenmann 9388e43751 file: remove x-directory/smb-share special casing
The mime type x-directory/smb-share is not used by any current programs
anymore. A Github search resulted only in nautilus forks and references
to the deprecated gnome-vfs.
2024-04-02 01:25:44 +02:00
Peter Eisenmann e0a73ba4bb file: flatten speed_tradeoff's logic flow 2024-04-02 01:25:44 +02:00
Peter Eisenmann f3994cf729 file: early return in speed_tradeoff on never value 2024-04-02 01:25:44 +02:00
Peter Eisenmann 928055c842 file: add parent param to remote+preview method
Allow passing a file's parent to get_filesystem_use_preview and
get_filesystem_remote. This resolves the multi-level parent checking
discussed in [1], by only checking one parent at most.

[1] https://gitlab.gnome.org/GNOME/nautilus/-/issues/3336
2024-04-02 01:25:44 +02:00
Peter Eisenmann 1517233558 file: don't expose internal methods
Turn nautilus_file_get_filesystem_remote() and
nautilus_file_get_filesystem_use_preview() into internal methods.
2024-04-02 01:25:44 +02:00
Khalid Abu Shawarib 4811a2896d window-slot: Hide banner in global search
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/3303
2024-04-01 23:19:22 +00:00
Automeris naranja 006a349dd2 file-conflict-dialog: Fix "Apply this action..." check button warning
GtkCheckButton has the label property, so embedding a GtkLabel
to it is unnecessary. This fixes the warning that says
"Finalizing GtkCheckButton [...], but it still has children left:
GtkLabel".

Also, add a mnemonic.
2024-04-01 23:10:29 +00:00
Automeris naranja 68417849c5 file-conflict-dialog: Improve mnemonics of "Replace" & "Rename" buttons
Because of the "Reset" button, the "Replace and "Rename" button
use the letter "P" and "N" respectively for their mnemonics,
which is odd, since the letter "R" would be more practical
to use; and "Replace and "Rename" never appear together.

So, use the letter "R" for "Replace and "Rename" and "E"
for the "Reset" button.
2024-04-01 23:10:29 +00:00
Automeris naranja ef535d4648 file-conflict-dialog: Fix mnemonics
"Skip" and "Select a new name for the destination" are
both using the letter S, so they can't be triggered with
the keyboard.

Fix that.
2024-04-01 23:10:29 +00:00
Automeris naranja 5e9529f6eb file-conflict-dialog: Port to AdwToolbarView 2024-04-01 23:10:29 +00:00
Peter Eisenmann c1169c8d9c ci: don't run for translation updates
Running a pipeline for each translation update is wasting resources.
2024-04-01 23:06:04 +00:00
Daniel Rusek 8c33c7ed95 Update Czech translation 2024-04-01 10:18:31 +00:00
Peter Eisenmann c092dd8c8c window-slot: fully remove unused selection binding
This was missed in b75bd46f49
2024-04-01 03:57:22 +02:00
kramo 75f98a5b40 data: Update screenshots
Depends on https://gitlab.gnome.org/Infrastructure/static-web/-/merge_requests/23
2024-03-31 12:31:56 +00:00
Nathan Follens f53691f8bd Update Dutch translation
(cherry picked from commit acf740524a)
2024-03-31 11:37:56 +00:00
Martin 451577a1d7 Update Slovenian translation 2024-03-31 10:51:09 +00:00
Corey Berla 480690d119 module: Call module shutdown() in teardown()
Each module's shutdown() should have been called in unload(), but
as we know, unload() never ended up getting called.  Instead
call it during teardown()

Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/1971
2024-03-30 09:43:13 +01:00
Corey Berla 59a667cead module: Store the actual module rather than just the path name 2024-03-30 09:43:13 +01:00
Corey Berla 0e51dbc1c8 module: Remove logic for unloading modules
Our modules never would reach the unload point anyways and GModule
doesn't actually unload the module, so let's remove anything related
to unloading to simplify.

Related: https://gitlab.gnome.org/GNOME/glib/-/issues/667
Related: 72df62600d
2024-03-30 09:43:13 +01:00
Automeris naranja b18d93cde9 general: Rename "computer" strings to "device"
"Computer" isn't a suitable term for other device form factors.

Follow-up from:
7896e84cdb
2024-03-30 08:22:43 +00:00
Automeris naranja 7ab17252d7 file-properties-change-permissions: Port to AdwToolbarView
Also:
- Increase margins around content to make the UI more
balanced
- Ditch the .view style class to improve consistency,
because other Nautilus windows don't use this style class
- Put the GtkGrid directly in the content widget
2024-03-30 08:14:18 +00:00
Khalid Abu Shawarib 78092b95da general: Fix leaks 2024-03-30 08:05:34 +00:00
Peter Eisenmann 00b46b00ea directory-async: remove unused uri vars
The code that used them was removed in [1].

[1] 5cf288a93e

(cherry picked from commit a852fa77bbfb4e42c039d32b38c02769b7f82be4)
2024-03-30 08:05:34 +00:00
Khalid Abu Shawarib c05b82e0ae filename-validator: Prevent theoretical null dereference 2024-03-30 08:05:34 +00:00
Khalid Abu Shawarib 7aa10af359 tests: Use g_assert_true instead of g_assert 2024-03-30 08:05:34 +00:00
Khalid Abu Shawarib 4233ad2429 file-utilities: Use mime-info description
These types are part of xdg-mime specification and already have
translations that are identical to the ones that we have. Remove
them from here to reduce duplicate work for the translators.
2024-03-30 08:05:34 +00:00
Khalid Abu Shawarib c5216c47da general: Use the defined constant for path separator 2024-03-30 08:05:34 +00:00
Khalid Abu Shawarib b75bd46f49 window-slot: Remove unused property 2024-03-30 08:05:34 +00:00
Khalid Abu Shawarib 2326d7780b properties-window: Remove mention of Computer://
This was removed in [1] and wasn't changed back then.

[1] c79aff62ab
2024-03-30 08:05:34 +00:00
Khalid Abu Shawarib 3767bcee09 general: Remove unneeded comments
Advice about g_list_append is already documented.

Desktop link icons support was dropped in b1cb977812
2024-03-30 08:05:34 +00:00
Khalid Abu Shawarib be9fc5678a general: Use g_set_* macros 2024-03-30 08:05:34 +00:00
Khalid Abu Shawarib 45f58ae68d file-operation: Remove unapplicable comment
This comment was unapplicable in same commit that it was added
in. Perhaps it was a mistake.

See: 841af08641
2024-03-30 08:05:34 +00:00
Khalid Abu Shawarib 2643486b31 files-view: Handle initial dialog location for some odd places
This prevent passing an unsupported initial location for the file
dialog.

Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/3264
2024-03-30 07:34:05 +00:00
Khalid Abu Shawarib 598f751232 star-cell: Only set tooltip on change
Setting tooltips seems expensive as it invokes system calls. Check
if the text is different before changing it to improve performance.
2024-03-30 07:27:08 +00:00
Jonathan Lin 67f0be4239 files_view: Disable paste in Trash, Recent, and Starred
Disables pasting in the context menu and shortcuts with specific error
dialogs.  Previously, pasting into these directories using 'ctrl-v'
triggered strange error dialogs. The Trash folder also had paste enabled
in the menu.

Fixes #3235
2024-03-30 07:16:41 +00:00
Khalid Abu Shawarib 855f45b10a location-banner: Update panel name
Usage page was embedded into privacy and we didn't update the
code to reflect that. Change the name in the dbus request to
launch the containing panel, and also specify the subpage name.

Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/3348
2024-03-30 01:04:12 +00:00
Fina Wilke fd7ce3d1f7 file-operations: Preserve permissions copying from r/o non-isofs mounts
When copying files from readonly mounts we only reset the permissions of
the source if those are of filesystem type isofs. The original behaviour
was meant to be a workaround for isofs optical disks [1][2] for which the
kernel driver sets permissions of all inodes to r-x if the POSIX
permission extension (rock ridge) is not available [1].

As we can't detect the presence of such an extension from gio we can only
guess and reset the permissions for all isofs mounts. This is still
wrong [3], but reduces the scope of the bug to isofs.

[1] https://bugzilla.gnome.org/show_bug.cgi?id=167102
[2] https://bugzilla.gnome.org/show_bug.cgi?id=550816
[3] https://gitlab.gnome.org/GNOME/nautilus/-/issues/2873
2024-03-30 01:00:26 +00:00
Khalid Abu Shawarib ba665f5371 files-view: Move focus function from list base
This was supposed to be done in ee6ee07543

The select action called by this focus function would set the
selection and notify the changes which updates the selection info
in the floating bar.

Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/3354
2024-03-30 01:52:35 +01:00
Automeris naranja 01b28f337b operations-ui-manager: Add mnemonic to the "Merge" button
Add a mnemonic to the "Merge" button from the file conflict
dialog.
2024-03-29 21:08:34 -03:00
Athmane MOKRAOUI 51b9038b23 Update Kabyle translation 2024-03-29 12:17:42 +00:00
Yaron Shahrabani 03b2e4f83e Update Hebrew translation 2024-03-29 06:36:04 +00:00
Ekaterine Papava b456dc7477 Update Georgian translation 2024-03-29 04:08:40 +00:00
Athmane MOKRAOUI 7ea3804d67 Update Kabyle translation 2024-03-29 03:18:17 +00:00
Automeris naranja a3718eb47f operations-ui-manager: Use header capitalization in some strings
Use header capitalization in some strings from the
file conflict dialog, such as "Replace with", "Merge with",
"Original file", "File conflict" and
"File and Folder conflict". This change conforms with the
HIG guidelines[1].

Closes https://gitlab.gnome.org/GNOME/nautilus/-/issues/3373

[1] https://developer.gnome.org/hig/guidelines/writing-style.html#header-capitalization
2024-03-28 22:00:30 -03:00
Juliano de Souza Camargo ea6ba78f23 Update Brazilian Portuguese translation 2024-03-27 22:51:06 +00:00
Automeris naranja e364ba4705 properties-window: Use property rows in "create_extension_group_row"
AdwActionRows and AdwExpanderRows can become property
rows by adding the .property style class[1]. This
achieves the same behavior that create_extension_group_row
currently has, but with less code.

Related: https://gitlab.gnome.org/GNOME/nautilus/-/issues/3183

[1] https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/style-classes.html#property-rows
2024-03-23 23:32:41 +00:00
Lukáš Tyrychtr 1206af7d12 compress-dialog: If no password is required, try accepting the dialog on
activation of the archive name entry.

Doing that allows just typing the name and pressing Enter.

Fixes #3359.
2024-03-23 22:19:33 +00:00
Peter Eisenmann 2d3ebb3505 Post-branching version bump 2024-03-22 02:09:29 +01:00
Jordi Mas ef1034c254 Update Catalan translation 2024-03-19 21:47:10 +01:00
Ondrej Holy fafc791209 Post-release version bump 2024-03-18 14:09:47 +01:00