Commit graph

64726 commits

Author SHA1 Message Date
aaronp64 5a25637ca9 Fix Container::pending_sort tracking
When Container::queue_sort() is called, pending_sort is set to true to indicate when a call to _sort_children() is queued, to avoid queueing multiple calls. Container::_sort_children() sets pending_sort back to false when finished, but did not do this when the container was not inside the tree.  This would allow cases where queue_sort() could be called just before removing from the tree, causing _sort_children() to never reset pending_sort, preventing any future queue_sort() calls from queueing again.

One case where this happened was with the "Saving Scene" progress bar in the editor - when saving for the first time (or the first time the progress bar popup otherwise appeared in the editor), _sort_children() would be called successfully.  After the progress bar popup was hidden, then shown again on future saves, _sort_children() would not be called again, resulting in the progress bar not taking up as much space as it should.

This issue used to be avoided by setting pending_sort to false immediately on NOTIFICATION_ENTER_TREE - however, this would allow multiple calls to be queued at the same time when entering the tree (#92644).  The multiple calls was fixed recently by removing this assignment, but this also made possible the case where pending_sort is never reset.

This change sets pending_sort back to false in _sort_children() whether or not it's in the tree.  Since this is done in a deferred call, it should still avoid the previous issue of multiple calls being queued at once on entering the tree.

Fixes #92971
2024-06-10 20:17:47 -04:00
Hilderin 9f8a918ade Fix update_files from PR #92893 2024-06-10 20:03:18 -04:00
Hilderin 72856d633a Fix FileSystem dock won't show any file folders 2024-06-10 19:54:37 -04:00
Chris Cranford 8577340501 Expose several EngineDebugger methods and signals as plugin callbacks 2024-06-10 19:46:23 -04:00
smix8 14bed692bf Fix NavigationRegion2D clear button not updating debug visuals
Fixes that NavigationRegion2D editor plugin clear button did not update the debug visuals.
2024-06-10 19:36:21 +02:00
Daniel Opitz c24ea0ecca CI: Hotfix for build error with newer clang++
It will be included in the next release at some point.
- https://github.com/RenderKit/embree/issues 486
  "fix output operator"

[ 30%] Compiling thirdparty/embree/kernels/common/accelset.cpp ...
In file included from thirdparty/embree/kernels/common/device.cpp:12:
In file included from thirdparty/embree/kernels/common/scene_curves.h:10:
thirdparty/embree/kernels/common/../subdiv/bezier_curve.h:138:56:
error: no member named 'u' in 'QuadraticBezierCurve<V>'
  138 |         return cout << "QuadraticBezierCurve ( (" << a.u.lower << ", "
  << a.u.upper << "), " << a.v0 << ", " << a.v1 << ", " << a.v2 << ")";
 ...
2024-06-10 19:14:01 +02:00
smix8 6b85bc9de2 Fix NavigationRegion2D debug not clearing canvas item
Fixes NavigationRegion2D debug not clearing canvas item on navigation mesh change.
2024-06-10 19:07:57 +02:00
Adam Scott 5a01c2e954
Replace deprecated USE_WEBGL2 linker flag 2024-06-10 12:14:27 -04:00
bruvzg 768fd1eacb
[Window] Fix mouse hover state of the main window when mouse enter event was sent before setting callbacks. 2024-06-10 18:43:01 +03:00
bruvzg 721a663aa3
[Button] Adds theme option to align button text and icon to either largest or current stylebox. 2024-06-10 18:40:52 +03:00
Rémi Verschelde 5241d30bfa
Merge pull request #92836 from WhalesState/screenshot
Fix editor screenshots menu button's tooltip
2024-06-10 16:40:56 +02:00
Rémi Verschelde 91e166a0c0
Merge pull request #92815 from aaronp64/keep_skip_import_crash
Fix Keep/Skip File import selection crash
2024-06-10 16:40:53 +02:00
Mounir Tohami d9452552fa Fix editor screenshots menu button's tooltip. 2024-06-10 14:13:35 +00:00
Rémi Verschelde 7128667959
Merge pull request #92943 from anniryynanen/less-file-dialogs
Fix native file dialogs being shown on `set_visible(false)`
2024-06-10 16:12:11 +02:00
Rémi Verschelde 821338c0d1
Merge pull request #92925 from TokageItLab/concatenated-bone-names
Add `get_concatenated_bone_names()` to `Skeleton3D` for `SkeletonModifier3D`'s enum hints
2024-06-10 16:12:08 +02:00
Rémi Verschelde c568264bab
Merge pull request #92915 from capnm/240608-svg-tvg0.13.7
ThorVG: Update to 0.13.7
2024-06-10 16:12:05 +02:00
Rémi Verschelde 76b1a1f834
Merge pull request #92896 from TokageItLab/skeleton-mod-get-skeleton
Expose `get_skeleton()` from `SkeletonModifier3D`
2024-06-10 16:12:02 +02:00
Rémi Verschelde e4fd5b55eb
Merge pull request #92893 from Hilderin/fix-freeze-after-building-c#
Fix freeze after building C#
2024-06-10 16:11:59 +02:00
Rémi Verschelde 3d170c56d6
Merge pull request #92861 from TokageItLab/fix-animation-player-just-after-started
Fix seeking Animation immediate after playback for Discrete track
2024-06-10 16:11:55 +02:00
Rémi Verschelde b80e591448
Merge pull request #92843 from anniryynanen/tooltip-in-popup
Stop color picker tooltip from stealing input events
2024-06-10 16:11:52 +02:00
Rémi Verschelde 95b84f1239
Merge pull request #92787 from groud/tilemap_x_sort
Implement X-draw-order switch in TileMapLayer
2024-06-10 16:11:48 +02:00
Rémi Verschelde 3092b0c6ea
Merge pull request #92648 from stephen-berry/GODOT-92513
Consistently display script icons for nodes in connect dialog's scene tree editor
2024-06-10 16:11:45 +02:00
Rémi Verschelde 3d9ee2d0d7
Merge pull request #92117 from mart3323/godot-docs-basis-op-mul-vector
Fix example for Basis * Vector3 in documentation
2024-06-10 16:11:41 +02:00
Rémi Verschelde b7ea8415c2
Merge pull request #91997 from aaronp64/tooltip_transforms
Fix tooltip mouse position conversion for scaled controls
2024-06-10 16:11:39 +02:00
Rémi Verschelde 553f77674c
Merge pull request #91265 from AeioMuch/fix_drop_reparent
Fix reparenting after hover delay
2024-06-10 16:11:34 +02:00
Rémi Verschelde 09a037628e
Merge pull request #85488 from miv391/fix-expected-indented-block-error-message-lines
Moving "Expected indented block" error message's line number back to where the error is
2024-06-10 16:11:30 +02:00
Stephen Berry 823b48ffa5
Consistently display script icons for nodes in connect dialog's scene tree editor 2024-06-10 16:06:45 +02:00
Gilles Roudière c283db2130 Implement X-draw-order switch in TileMapLayer 2024-06-10 15:53:58 +02:00
Yuri Rubinsky 29fa291317 Fix incorrect camera transform of animation view in the import window 2024-06-10 16:09:36 +03:00
Mart Jõgi 771f52e477
Fix example for Basis * Vector3 in documentation
Fixes: godotengine/godot-docs#9394
2024-06-10 13:31:29 +02:00
bruvzg fff71db5b1
[RTL] Fix list item prefix width not taken into account. 2024-06-10 13:14:56 +03:00
Rémi Verschelde 32eba1ee17
Merge pull request #92967 from akien-mga/ci-gha-pin-python-3.12.3
CI: Pin Python 3.12.3 to workaround GHA issue
2024-06-10 12:13:10 +02:00
Rémi Verschelde 4fd7b2fc0f
CI: Pin Python 3.12.3 to workaround GHA issue
macOS runners can't extract the 3.12.4 tarball properly it seems.
https://github.com/actions/setup-python/issues/886
2024-06-10 11:29:54 +02:00
Silc Lizard (Tokage) Renew a57f9f863d Add get_concatenated_bone_names() to Skeleton3D for Modifier's hint 2024-06-10 10:19:36 +09:00
Hilderin cc990efddf Fix freeze after building C# 2024-06-09 13:40:51 -04:00
Silc Lizard (Tokage) Renew e92a453840 Expose get_skeleton() from SkeletonModifier3D 2024-06-09 23:58:05 +09:00
Anni Ryynänen b14b222e9d
Fix native file dialogs being shown on set_visible(false) 2024-06-09 17:54:18 +03:00
passivestar 3cd245c7b1 Add missing inspector dock update after node deletion 2024-06-09 11:51:41 +04:00
bruvzg 564ebd7ba4
Force editor progress dialog size update. 2024-06-08 23:15:07 +03:00
Martin Capitanio 18650de06a ThorVG: Update to 0.13.7 2024-06-08 20:19:53 +02:00
DeeJayLSP 63bb754fc8 qoa: Apply upstream patches 2024-06-08 11:57:40 -03:00
Silc Lizard (Tokage) Renew bea47d877b Fix seeking Animation immediate after playback for Discrete track 2024-06-08 22:09:37 +09:00
Rémi Verschelde 5833f59786
Merge pull request #92887 from wojtekpil/fix_compatibility_lm_baking
Fix depth clear value for uv2 baking in compatibility renderer
2024-06-08 14:11:35 +02:00
kleonc 7f6951b1f6 Fix TextureProgressBar radial mode invalid polygon edge case 2024-06-08 13:51:32 +02:00
Yuri Rubinsky 5962646fd3 Fix goto definition for new method 2024-06-08 10:52:01 +03:00
Rémi Verschelde 1ce6df7087
Merge pull request #92871 from KoBeWi/execute_order
Remove unused order variable from EditorResourcePreview
2024-06-07 23:30:46 +02:00
Rémi Verschelde 19affb60d1
Merge pull request #92850 from permelin/fix-navigationserver3d-get_closest_point_to_segment-use_collision
Fix `NavigationServer3D.get_closest_point_to_segment()` with `use_collision`
2024-06-07 23:30:42 +02:00
Rémi Verschelde a139cd611a
Merge pull request #92826 from bruvzg/nat_icon_checks
Improve native menu and status indicator icons conversion and checks.
2024-06-07 23:30:39 +02:00
Rémi Verschelde f9c5cdf360
Merge pull request #92819 from alula/patch-1
Fix building glslang on platforms without `<filesystem>`
2024-06-07 23:30:35 +02:00
Rémi Verschelde f58d508cc4
Merge pull request #92803 from YeldhamDev/kate_ignore
Ignore Kate's build file
2024-06-07 23:30:31 +02:00