Commit Graph

1702 Commits

Author SHA1 Message Date
Daniel Imms
d4f428940f
Merge branch 'main' into tyriar/149324 2022-05-25 06:35:27 -07:00
Tyler James Leonhardt
61861d7043
skip localization test until localized strings are present (#150326) 2022-05-25 00:28:33 +00:00
Daniel Imms
96479074a4
Create bash explicitly on linux/mac in shell integration smoke tests
Part of #149324
2022-05-23 07:22:15 -07:00
Daniel Imms
351b4a914e
Re-enable shell integration tests for macOS
Fixes #149757
2022-05-20 11:41:17 -07:00
Matt Bierner
17c75e1180
Allow reusing webview origins across reloads (#149950)
* Allow reusing webview origins across reloads

Currently webviews are always loaded into a unique origin. This keeps them isolated but also means that we can't benefit from caching across window reloads

This change adds a new `origin` option that you can pass to webviews which controls the origin they use. If this origin is not provided, we use a random one instead

We then save off this origin for webview panels and restore it on window reloads. Webviews restore a little faster on window reload

* Update webview fallback version
2022-05-19 16:07:14 -07:00
Daniel Imms
ca4db53d71
Skip shell integration smoke tests on mac as well
Part of #149757
2022-05-17 12:14:54 -07:00
Daniel Imms
9c29becfad
Disable shell integration smoke tests on Linux (#149376) 2022-05-13 16:47:10 +02:00
Ladislau Szomoru
2a9f19d36f
Engineering - create pull request pipeline (#149171) 2022-05-11 03:08:54 -07:00
Rob Lourens
9a7a7b6191
Re-skip smoke test (#149113) 2022-05-09 19:28:14 +00:00
Rob Lourens
7da792ae7c Reenable smoke test
Fixes #137195
2022-05-06 14:41:07 -06:00
Daniel Imms
6aaa63d4be
Merge pull request #148918 from microsoft/tyriar/146700_2
Fix, re-enable or disable skipped terminal smoke tests
2022-05-06 12:14:15 -07:00
Megan Rogge
5357dcfc04
fine tune shell integration messaging (#148856) 2022-05-06 09:26:12 -07:00
Daniel Imms
de7062f173
Re-enable retries 2022-05-06 08:13:19 -07:00
Daniel Imms
a5f0a29527
Fix, re-enable or disable skipped terminal smoke tests
Fixes #146700
2022-05-06 08:11:50 -07:00
Megan Rogge
bbf3142a89
use describe.skip for windows (#148580) 2022-05-02 14:23:55 -07:00
Ladislau Szomoru
b033e551c5
Fix #147036 2022-05-02 21:25:18 +02:00
Benjamin Pasero
f90dd46fc3
smoke - fail early if cloning fails 2022-05-02 08:38:03 +02:00
Benjamin Pasero
c6bd448948
debt - bring @types/mocha up to date with version 9.x 2022-05-02 08:30:27 +02:00
Megan Rogge
032d8ce4c6
shell integration smoke tests (#148056) 2022-04-25 14:53:55 -07:00
Benjamin Pasero
fb8dc11d58
Failed IPC communication with playwright smoke tests from preload script (for #146785) 2022-04-21 18:58:44 +02:00
Benjamin Pasero
08ac1bb67c
tests - improve exclusion handling for node.js tests 2022-04-21 17:10:16 +02:00
Benjamin Pasero
a9010d094a
smoke - support retryWithRestart in web too 2022-04-19 09:03:17 +02:00
Benjamin Pasero
06e26c7a57
Do not attempt to reopen files that lead to a crash in previous session (fix #114844) 2022-04-19 07:38:32 +02:00
Benjamin Pasero
ac6b490b2d
retr (#147442) 2022-04-14 11:34:22 +02:00
Benjamin Pasero
55759234d7
preload - revert retry logic which does not seem to help 2022-04-14 08:14:40 +02:00
Benjamin Pasero
c4cdb552a5
Remove legacy smoke test driver (#147393)
* wip

* fix imports

* more lipstick

* fix?

* fix
2022-04-13 19:19:58 +02:00
Benjamin Pasero
675b8c3da0
smoke - fix compile 2022-04-13 17:37:52 +02:00
Benjamin Pasero
98d2ea4444
smoke - restore workaround for #146785 2022-04-13 17:21:40 +02:00
Benjamin Pasero
a7cdd9a391
preload - and and use invokeWithRetry (#146785) 2022-04-13 13:06:22 +02:00
Benjamin Pasero
fa8d1063f6
🆙 1.21.0 (#147348)
* 🆙 `playwright`

* fix install

* adopt latest apis

* comment
2022-04-13 08:43:17 +02:00
Benjamin Pasero
d215bada5e
smoke - more logging for shared process 2022-04-12 11:13:19 +02:00
Benjamin Pasero
9967cf2782
smoke 💄 2022-04-12 08:17:52 +02:00
Benjamin Pasero
12500e46ac
properly skip unit test (#137853) 2022-04-11 17:02:34 +02:00
Benjamin Pasero
84d6b4a12a
smoke - enable more logging for #146800 2022-04-11 10:34:47 +02:00
Benjamin Pasero
497a035770
smoke - properly pick suite name 2022-04-10 10:13:07 +02:00
Benjamin Pasero
e358a02a35
smoke - also screenshot on failure 2022-04-09 13:55:56 +02:00
Benjamin Pasero
d9db5d10ec
smoke - try to fix terminal tests and partition logs path per suite 2022-04-09 13:38:59 +02:00
Benjamin Pasero
7e5180fb34
Remote extension host does not respect trace log (fix #146897) 2022-04-08 19:36:12 +02:00
Benjamin Pasero
9a8fa5f014
revert 2022-04-08 19:12:34 +02:00
Benjamin Pasero
af6bfd1352
smoke - bring back ext tests with retry for now to have coverage (#146800) 2022-04-08 12:33:52 +02:00
Martin Aeschlimann
cc47c60e96
testresolver: set log level with TESTRESOLVER_LOG_LEVEL. For #146897 2022-04-08 10:41:36 +02:00
Benjamin Pasero
b6fc6eae3b
skip terminal tests (#147063) 2022-04-08 10:32:00 +02:00
Benjamin Pasero
80c13ff14f
smoke - try to mitigate hanging close (#146803) 2022-04-07 17:48:59 +02:00
Benjamin Pasero
acc4c50ffa
smoke - skip flaky tests (#146800) 2022-04-06 19:36:17 +02:00
Benjamin Pasero
8e8b3026fc
tests - reduce spam and work 2022-04-06 19:34:41 +02:00
Benjamin Pasero
18377e6ee2
smoke - allow to enable verbose vscode logs and enable for now 2022-04-06 10:41:22 +02:00
Benjamin Pasero
fd7efbee45
smoke - cleanup some file names 2022-04-05 19:21:29 +02:00
Benjamin Pasero
16b97e6846
smoke - better use of tree-kill 2022-04-05 19:08:33 +02:00
Benjamin Pasero
7c31267b20
smoke - mitigate #146785 2022-04-05 18:03:36 +02:00
Benjamin Pasero
66c9155d93
smoke - skip install and enable vscode-smoketest-check extension in remote (#146800) 2022-04-05 17:31:10 +02:00
Benjamin Pasero
9a78ee3b1a
unit - skip all tests for test component in node 2022-04-05 17:27:24 +02:00
Benjamin Pasero
690a9c0f8d
smoke - adopt repo changes 2022-04-05 17:19:53 +02:00
Benjamin Pasero
2684fb1e00
smoke - logging 💄 2022-04-05 13:22:46 +02:00
Benjamin Pasero
e58cad64a9
smoke - add refs to #146811 2022-04-05 11:49:52 +02:00
Benjamin Pasero
a90f57b4a9
smoke - skip terminal tests in desktop 2022-04-05 11:47:29 +02:00
Benjamin Pasero
6508a29d23
smoke - more verbose logging on windows 2022-04-05 09:17:17 +02:00
Benjamin Pasero
a99a8711af
skip flaky terminal smoke test (#146796) 2022-04-05 08:40:07 +02:00
Benjamin Pasero
17a7edb8bb
smoke - remove some unused methods from driver 2022-04-05 08:04:40 +02:00
Inclusive Coding Bot
4983226088
Switch to gender neutral terms (#146371)
* Switch to gender neutral terms

* Update testrunner.js

* Update fileSearchManager.ts

* Update fileSearch.ts

* Update fileSearch.ts

Co-authored-by: inclusive-coding-bot <inclusive-coding-bot@github.com>
2022-04-04 16:22:09 -07:00
Jackson Kearl
ee8535e777
Fix #124335 2022-04-04 12:48:12 -07:00
Benjamin Pasero
0390d4f2a4
smoke - try to use locator API for window ready 2022-04-04 15:47:21 +02:00
Benjamin Pasero
44aea76875
💄 2022-04-04 15:47:21 +02:00
Benjamin Pasero
f707fd3b09
smoke - run legacy tests again, do not fail new playwright tests for a while to figure out flakiness 2022-04-04 15:03:17 +02:00
Benjamin Pasero
65bfe1ef11
smoke - enable multi root tests in web 2022-04-04 13:47:43 +02:00
Benjamin Pasero
2ada17080c
Use playwright for desktop smoke tests (#146692)
* Use `playwright` for desktop smoke tests

* fix distro issues

* tests - enable prefs tests for web
2022-04-04 10:13:08 +02:00
Connor Peet
6fcf02f29a
testing: re-enable possibly fixed tests 2022-04-01 13:20:50 -07:00
Tyler Leonhardt
e3d1bab639
update minimist in smoke tests 2022-03-29 11:53:20 -07:00
Charles Gagnon
8da408454c
Update coverage folder location
The coverage folder isn't generated at the root of the workspace, it's put in the `.build` folder currently.
2022-03-21 10:55:03 -07:00
Robo
b4b5c4d979
ci: fix published server arhive name on macOS (#145509) 2022-03-21 06:29:24 -07:00
Benjamin Pasero
3e5c7e2c57
smoke - disable trust
cc @sbatten @lszomoru
2022-03-12 08:23:43 +01:00
SteVen Batten
24d49c0f84 disable workspace trust in web integration tests 2022-03-11 08:52:55 -08:00
SteVen Batten
6b74534212
rename side panel (#144862)
* rename side panel

* tweaks based on feedback
2022-03-10 16:20:23 -08:00
Robo
32d40cf44e
chore: update to electron 17 (#143223)
* chore: bump electron@17.0.0

* Revert "chore: revert to electron@13 (#143851)"

This reverts commit df645f1450.

* chore: bump electron@17.1.0

* Revert "ci: fix build with latest node-gyp"

This reverts commit c3e948aa30.

* chore: revert ci changes for node v16

* chore: update yarn.lock

* chore: bump electron@17.1.1
2022-03-11 00:51:37 +09:00
Matt Bierner
c569182d08
Encode webview parent origin in authority
Fixes #144703
2022-03-08 11:28:59 -08:00
Robo
df645f1450
chore: revert to electron@13 (#143851)
* Revert "chore: update to electron 16 (#137241)"

This reverts commit 01df559c18.
This reverts commit 46301339b7

* ci: fix remote compiler for sdl-scan

* chore: fix remote/.yarnrc

* chore: fix build/npm/postinstall.js

* chore: rm crash reporter from shared process

* chore: rm crash reporter from ext host

* chore: fix build/lib/layersChecker.ts

* :chore: preserve some more changes

* fix tests

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2022-02-24 17:49:49 +01:00
Benjamin Pasero
5a17b1bb76
smoke - retry stable code download (fix #143386) (#143592) 2022-02-22 09:04:56 +01:00
Matt Bierner
31b199da9c
Bump webview commit 2022-02-15 18:36:12 -08:00
Benjamin Pasero
b344f43498
Revert "linux: disable crash reporting in CI (#142572)"
This reverts commit 7dbd7367dc.
2022-02-15 16:27:08 +01:00
Benjamin Pasero
7dbd7367dc
linux: disable crash reporting in CI (#142572) 2022-02-15 08:26:18 +01:00
Matt Bierner
82fe581566
Bump webview commit 2022-02-14 13:45:05 -08:00
Benjamin Pasero
7d78913dff
smoke - remove only usage 2022-02-12 07:47:54 +01:00
Benjamin Pasero
5911ead4c6
smoke - open a different file for #142745 2022-02-12 07:38:04 +01:00
Martin Aeschlimann
22e5d7274a
prepare tests for license terms check 2022-02-09 16:18:37 +01:00
Benjamin Pasero
f613ab462e
tests - skip some, enable some 2022-02-09 07:14:42 +01:00
Robo
01df559c18
chore: update to electron 16 (#137241)
* chore: bump electron@15.3.0

* chore: bump node@16.x

* chore: enable render process reuse

* Revert "watcher - use `type` property for crash reporter location"

This reverts commit bfa488dd8f.

* Revert "watcher - enable crash reports on linux (#136264)"

This reverts commit af261488f8.

* chore: enable crashpad on linux

* chore: bump electron@15.3.1

* chore: update api changes

* chore: bump @vscode/sqlite3@5.0.3

* spec: skip non-context aware module unittests

* chore: fix perf hook integration with node environment

* fix: adopt fs api changes

* chore: fix integration tests

* chore: bump electron@15.3.2

* chore: bump electron@16.0.0

* temp(macOS): kill test instances in OSS

* Revert "temp(macOS): kill test instances in OSS"

This reverts commit b0d796c8d64227a5ec012c060bbbee7d9da27568.

* chore: update chromium version for clang downloader

* some 💄 changes

* align with changes

* adopt more fs.rm

* 💄

* chore: bump @vscode/sqlite3@5.0.4

* fix layers check to account for duplicated types from node.js

* update todo for type casts

* smoke - fix compile issue

* chore: update module cache

* watcher - fix unhandled rejection (fix #137416)

* ci: update node version

* enable stack dumping

* update electron types to 16.x

* chore: bump @vscode/sqlite3@5.0.5

Refs https://github.com/microsoft/vscode/issues/137496

* fix layer issue

* add `AbortSignal` to core types

* chore: update linux compile flags

Refs 797723ec83

* ci: fix linux build

* ci: update github ci cache

* ci: fix remote build in github ci

* ci: better fix for remote build

* chore: bump azure cache

* chore: fix merge conflict

* :chore: update to electron@16.0.2

* chore: bump @vscode/sqlite3@5.0.7

* ci: update to gcc-4.9 for remote

Refs https://github.com/microsoft/vscode/issues/137659

* ci: switch to buster for linux arm

Refs https://github.com/microsoft/vscode/issues/137927

* ci: fix build on linux arm64

* ci: fix arm client compiler toolchain

Refs #137927

* chore: bump electron@16.0.3

* ci: fix compile flags for the c toolchain

* chore: bump electron@16.0.4

* Add experimental dark mode flag (#139109)

* Add experimental dark mode flag

* Apply PR feedback

* chore: bump electron@16.0.6

* chore: bump electron@16.0.7

Fixes https://github.com/microsoft/vscode/issues/138792
Fixes https://github.com/microsoft/vscode/issues/139300

* chore: experimental highlight API

* smoke - fix compile issue

* FIXME: custom ELECTRON_RUN_AS_NODE with node worker

* Revert "chore: bump electron@16.0.7"

This reverts commit 5fd01cf37c.

* Revert "Revert "chore: bump electron@16.0.7""

This reverts commit a7f1b73951.

* chore: fix github linux workflow

* chore: address review feedback

* chore: bump electron@16.0.8

* ci: revert to stretch distro for linux arm

Refs https://github.com/microsoft/vscode/issues/137927

* ci: force build

* chore: update yarn.lock

* address feedback

* Revert "FIXME: custom ELECTRON_RUN_AS_NODE with node worker"

This reverts commit 7b48fa3732.

* ci: fix remote folder build

* chore: fix github linux ci

* 🆙 `versionSpec`

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Raymond Zhao <raymondzhao@microsoft.com>
2022-02-08 20:09:00 +01:00
Benjamin Pasero
b6c093a888
💄 todos 2022-02-08 18:04:54 +01:00
Sandeep Somavarapu
3b1da68d60
#142027 enable preferences smoke test 2022-02-08 08:30:27 +01:00
Benjamin Pasero
0d741957d9
smoke - bring back keybindings test 2022-02-05 07:06:54 +01:00
Benjamin Pasero
b667613ff8
smoke - retry fetch to update service (fix #142188) 2022-02-04 19:10:21 +01:00
Megan Rogge
921264bfe3
add splitCwd smoke test for linux/mac (NaiveCwdDetection) (#141974) 2022-02-03 19:57:26 -06:00
Rob Lourens
b46986a65f Remove .only 2022-02-03 09:37:56 -08:00
Benjamin Pasero
ee3556530f
smoke - skip test (#142020) 2022-02-02 18:16:10 +01:00
Benjamin Pasero
77a93b43e9
smoke - skip #141054 2022-02-02 16:51:55 +01:00
Johannes Rieken
4a130c40ed
enable @typescript-eslint/member-delimiter-style, https://github.com/microsoft/vscode/issues/140391 2022-02-02 14:35:33 +01:00
Alex Dima
cab9713422
Fixes #141994: Address eslint problems 2022-02-02 13:18:12 +01:00
SteVen Batten
a48c94c91f
bump node-fetch version in smoke tests 2022-02-01 11:40:45 -08:00
Benjamin Pasero
12c5c57e46
smoke - simplify line number test (#141054) 2022-02-01 10:08:15 +01:00
Sandeep Somavarapu
fb8316c8f4
#141054 check line numbers in settigns file 2022-02-01 09:35:54 +01:00
Sandeep Somavarapu
d4e08c85a9
#141054 enable the tests and keep debugging 2022-01-28 13:50:09 +01:00
Alex Dima
1b1d594671
Run headless on CI 2022-01-25 20:49:30 +01:00
Alex Dima
2ccb32cfe9
Use @playwright/test instead of playwright 2022-01-25 18:21:30 +01:00
Alex Dima
bd369c638e
Add check that the editor's ESM JS files can be loaded in a browser 2022-01-25 15:19:30 +01:00
Alex Dima
81ad1f968d
Do not force that a connection token CLI argument is present 2022-01-24 14:02:41 +01:00
Benjamin Pasero
c9960f9cee
Cleanup package.json test scripts (#141210)
* tests - remove `yarn test`

* fix smoke test

* readme

* 💄

* ci - do not install playwright
2022-01-22 13:07:14 +01:00
Benjamin Pasero
b7cdfce7e5
Smoke test runner fails or hangs without error (fix #141148) 2022-01-22 08:43:21 +01:00
Martin Aeschlimann
ef4549b141
Merge branch 'main' into aeschli/noremoteindicatorweb 2022-01-21 17:19:52 +01:00
Martin Aeschlimann
3640c1a425
move remote and web tests to scripts folder 2022-01-21 14:33:34 +01:00
Martin Aeschlimann
0d8bb5f2ba
Merge branch 'main' into aeschli/noremoteindicatorweb 2022-01-21 14:16:29 +01:00
Alex Dima
715dbb0c16
Refuse launching unless a connection token is provided 2022-01-21 13:25:20 +01:00
Martin Aeschlimann
f9cac7c28a
adopt --server-data-dir 2022-01-21 12:11:47 +01:00
Alex Dima
1498d0f340
Add explicit layers for editor contributions (fixes #140995) 2022-01-21 10:29:55 +01:00
Martin Aeschlimann
8047f9c877
no remote indicator for code server web 2022-01-21 10:00:20 +01:00
Benjamin Pasero
01a976f80c
smoke - properly skip tests (#141054) 2022-01-21 08:55:59 +01:00
Benjamin Pasero
5993199079
smoke - skip flaky one (#141054) 2022-01-21 07:26:59 +01:00
Connor Peet
904c63debd
smoketests: use new extractSync option 2022-01-20 11:04:36 -08:00
Benjamin Pasero
295984b33b
tests - adopt new URL syntax when web is connected to a remote 2022-01-20 15:55:18 +01:00
Benjamin Pasero
e07713a8a9
smoke - log fatal errors 2022-01-20 14:18:06 +01:00
Benjamin Pasero
365fea1d61
fix #141060 2022-01-20 13:59:47 +01:00
Benjamin Pasero
13461f8c61
Web: change yarn web to run with our server instead of playground (#139725)
* web - first cut `yarn web` via our server

* properly pipe output

* web - remove traces of web playground

* web - remember last opened workspace for convinience

* use vscode-test-web for server less, clean up web commands

* fix comment

* fix `yarn web`

* rename to code-server

* open system browser

* code-server script: use minimist

* test resolver: use ./scripts/code-server

* integartion tests: fix code-server command name

Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
2022-01-20 13:48:08 +01:00
Benjamin Pasero
f317abfd68
layers - clean up top level workbench test folder 2022-01-20 10:47:35 +01:00
Martin Aeschlimann
f7baac67c1
Merge branch 'aeschli/adoptServerScript' 2022-01-19 21:31:12 +01:00
Martin Aeschlimann
36089a9229
fix unused import 2022-01-19 19:49:37 +01:00
Benjamin Pasero
96206bb5a8
smoke - 🆙 timeouts 2022-01-19 19:45:03 +01:00
Connor Peet
bdc81fc0a9
tests: log progress as stable code downloads 2022-01-19 09:16:39 -08:00
Martin Aeschlimann
ad928a4e0f
adopt server script in integration tests 2022-01-19 18:08:04 +01:00
Benjamin Pasero
c333d44ecd
update integration test docs how to compile 2022-01-19 07:29:38 +01:00
Sandeep Somavarapu
066671a902
Fix #140838 2022-01-18 17:43:20 +01:00
Benjamin Pasero
158cd6da42
smoke - log code download (#140769)
* smoke - log progress/errors of vscode download

//cc @connor4312

* reduce spam
2022-01-15 11:31:13 +01:00
Benjamin Pasero
9be2757019
🆙 playwright@1.18 (#140767)
* tests - use `@playwright/test@1.18.0-rc1`

* fix bad dependency

* clear more weird ts dependencies
2022-01-15 09:35:39 +01:00
Daniel Imms
f2c755a878 Skip smoke test
Part of #139076
2022-01-14 09:47:56 -08:00
Daniel Imms
0b7bc6d73c Re-enable auto replies tests with retries on Windows only
Fixes #139076
2022-01-14 08:56:11 -08:00
Benjamin Pasero
eecbd962ef
debt - rename iconv-lite-umd package (#140650) 2022-01-14 07:28:41 +01:00
João Moreno
8c9870d298
Smoke Test: forcefully kill electron if exit doesn't work (#140570)
* smoke test: forcefully kill electron if exit doesn't work

* use tree-kill

* roll back veto
2022-01-12 17:02:52 +01:00
Daniel Imms
860e935d1a Skip notebooks smoke test suite
Part of #140575
2022-01-12 07:35:56 -08:00
Benjamin Pasero
af5de88a44
tests - add --sequential option and use in CI runs 2022-01-11 10:48:20 +01:00
Matt Bierner
9f867c3ed8
Revert service worker usage of MessageChannel (#140351)
* Revert service worker usage of MessageChannel

Reverts 66b6adf035

While I'm not 100% about this, I think 66b6adf035 causes resourses to occasionally not load. I believe this can happen if the service worker is unitilized while the webview remains active. I can't reproduce this myself so it may be related to memory pressure or resource usage, however relying on the service worker not being reinitilized does seem like a potentially bad idea https://stackoverflow.com/questions/34775105/what-causes-the-global-context-of-a-service-worker-to-be-reset

Will investigate if there's another way to achive this since using MessagePort did clean up the code and slightly improve performance

* Bump webview commit versions
2022-01-10 14:22:49 -08:00
Benjamin Pasero
a224ef4fb3
smoke - fix selectTab to select tab? 2022-01-04 09:47:09 +01:00
Benjamin Pasero
18a7108073
smoke - select tab over quick pick (#139944)
* smoke - further try to reduce usages of quick pick

* poke
2021-12-30 22:38:59 +01:00
Benjamin Pasero
99fabbdb27
smoke - more logging 2021-12-29 17:46:52 +01:00
Benjamin Pasero
bd43c04262
smoke - log electron stdout into log file 2021-12-29 17:35:54 +01:00
Benjamin Pasero
9c0cce1dae
smoke - take screenshot when waiting long for window ready 2021-12-28 15:32:35 +01:00
Benjamin Pasero
b2e9e87c2e
smoke - skip flaky notebook test (#139672) 2021-12-23 17:12:29 +01:00
Benjamin Pasero
b2e79a699f
smoke - improve app lifecycle (#139693)
* smoke - make sure app is closed when `app.start` fails

* smoke - `capturePage` to fallback to active window

* smoke - more logging around remote resolving
2021-12-23 16:38:54 +01:00
Daniel Imms
daf4ba622f
Merge pull request #138516 from microsoft/tyriar/137847
Try removing timeout in checkWindowReady
2021-12-22 10:38:41 -08:00
Benjamin Pasero
bb39ae82cf
smoke - improve runCommand and disable more tests 2021-12-20 08:25:08 +01:00
Benjamin Pasero
2d77c9e23a
smoke - more robust usage of quick input / access (#139367)
* smoke - more robust `openQuickAccessAndWait`

* tweaks

* 💄

* trigger

* fix fluke

* poke

* fix terminal weirdness

* poke

* address feedback
2021-12-17 18:49:17 +01:00
Daniel Imms
88fcbd84e0 Fix auto replies smoke tests
This was flaky because the shell's wrapping character may have come after the
input (eg. 'foo> bar'), the fix is to allow characters between the matching
string and reply via regex.

Fixes #139083
2021-12-17 09:42:50 -08:00
Benjamin Pasero
7141436baa
smoke - skip failing terminal test (#139353) 2021-12-17 08:21:58 +01:00
Benjamin Pasero
1a4a2714bf
smoke - skip failing terminal test (#139349) 2021-12-17 07:34:20 +01:00
Daniel Imms
d33e3d2fbc Re-enable flaky auto replies tests
Need a new playwright trace from a failure to be able to diagnose

Part of #139083
2021-12-16 11:36:53 -08:00
Benjamin Pasero
ae8aeb653d
smoke - use absolute paths for opening files (#139322) 2021-12-16 20:14:12 +01:00
Benjamin Pasero
9e22f1ccac
smoke - disable flaky notebook tests (#139270) 2021-12-16 15:55:15 +01:00
Daniel Imms
dfc4077fb0 Use dom renderer for terminal smoke tests
Part of #139083
2021-12-16 06:38:11 -08:00
Sandeep Somavarapu
995d40b12d
#139183 enable the test and add a log statement 2021-12-16 14:34:47 +01:00
Benjamin Pasero
fa739870a2
smoke - remove doubleClick usage 2021-12-16 14:27:21 +01:00
Benjamin Pasero
fdc4b7101d
smoke - actually retry quick access usage 2021-12-16 14:25:12 +01:00
Benjamin Pasero
51eda13af4
smoke - move editor test into language test 2021-12-16 10:29:46 +01:00
Rob Lourens
86bdc567e9 Remove obsolete comment 2021-12-15 16:41:20 -08:00
Daniel Imms
da308a9a7f Format 2021-12-15 19:35:16 +00:00
Daniel Imms
fa61def811
Merge branch 'main' into tyriar/137847 2021-12-15 09:29:49 -08:00
Johannes Rieken
1b2c610ffe
skip bad test, https://github.com/microsoft/vscode/issues/139183 2021-12-15 10:51:01 +01:00
Rob Lourens
b823936907 Wait for window to connect before starting browser smoketests
Fix #138045
2021-12-14 20:23:44 -08:00
Matt Bierner
8cf4dcdade
Re-enable notebook smoke tests (#139127)
Fixes #126371
2021-12-14 16:50:22 -08:00
Connor Peet
2b19344369
testing: debug test failures
For #137853
2021-12-14 11:29:14 -08:00
Daniel Imms
2eb4cec44b Wait for terminal to be ready before changing color
Fixes #139081
2021-12-14 10:14:06 -08:00
Daniel Imms
9c99eaa0b2 Also log exception in itSkipOnFail 2021-12-14 08:15:54 -08:00
Daniel Imms
c29df4c2d5 Add itSkipOnFail util
Part of #139076
2021-12-14 08:05:43 -08:00
Benjamin Pasero
5526cd558f
smoke - remove only 2021-12-14 07:38:08 +01:00
Daniel Imms
9d1a7abe35 Some jsdoc 2021-12-13 16:57:14 -08:00
Daniel Imms
50f96a3c6b Clean up terminal creation in smoke tests 2021-12-13 16:54:42 -08:00
Daniel Imms
73a19337ac Merge remote-tracking branch 'origin/main' into tyriar/133524 2021-12-13 16:28:23 -08:00
Daniel Imms
9566e299dd Add auto replies test 2021-12-13 16:20:34 -08:00
Megan Rogge
a2f5ec29b2
Revert "Revert "be sure that terminal target gets set for the instance (#138875)""
This reverts commit 8605d7aeff.
2021-12-13 17:08:29 -06:00
Megan Rogge
0602587ff2
re-enable smoke tests, keep editor fix (#139012) 2021-12-13 12:50:58 -06:00
Rob Lourens
7e4942dcb7 Revert "Re-enable additional notebook smoke tests"
This reverts commit b3b9d4e2e7.
2021-12-13 09:18:17 -08:00
Daniel Imms
8605d7aeff Revert "be sure that terminal target gets set for the instance (#138875)"
This reverts commit 578eb0d4ae.
2021-12-13 08:15:32 -08:00
Matt Bierner
b3b9d4e2e7
Re-enable additional notebook smoke tests
For #126371

These pass for me locally
2021-12-10 17:08:02 -08:00
Matt Bierner
02c3551a59
Re-enable notebook smoke suite
For #126371

This single test passes for me. Will look at re-enabling individual tests next
2021-12-10 17:01:02 -08:00
Matt Bierner
66b6adf035
Switch webview service-worker to use message channel (#138811)
* Switch webview service-worker to use message channel

This change hooks the service worker used for loading webview resources directly up to the main VS Code process over a message channel. Previously this communication had to go through an extra hop through the webview

This simplifies the logic somewhat (although this change required adding extra logic to exchange the message port). It also improves performance a little

* Update webview content commit version
2021-12-10 16:35:13 -08:00
Megan Rogge
86ee106054
skip failing tests 2021-12-10 16:06:13 -08:00
Megan Rogge
578eb0d4ae
be sure that terminal target gets set for the instance (#138875) 2021-12-10 14:51:45 -08:00
Daniel Imms
69dcf8b0f6 Revert "Re-enable tests now that runCommandWithValue is more reliable"
This reverts commit 4554eac76d.
2021-12-10 13:05:53 -08:00
Daniel Imms
7d35da6eb9 Wait for host on web as well 2021-12-10 11:15:59 -08:00
Daniel Imms
da7ab25150 Merge remote-tracking branch 'origin/main' into tyriar/137847 2021-12-10 11:11:49 -08:00
Daniel Imms
4554eac76d Re-enable tests now that runCommandWithValue is more reliable
Part of #138658
2021-12-10 10:59:40 -08:00
Daniel Imms
866b9df390 Wait for quick input to open again after runCommandWithValue
Fixes #138658
2021-12-10 10:59:40 -08:00
Rob Lourens
9893857d4b Handle "clear search results" cancelling running search
Fix #138841
2021-12-10 10:51:26 -08:00
Benjamin Pasero
c5ea0fa337
fix some recent test failures 2021-12-10 14:34:14 +01:00
Benjamin Pasero
05de5834b0
smoke - add test to verify an editor can be saved 2021-12-10 13:45:08 +01:00
Benjamin Pasero
4667cac14b
smoke - more obvious tests setup 2021-12-10 13:32:08 +01:00
Rob Lourens
e5637ce9af Fix #138748 2021-12-09 10:00:25 -08:00
Johannes Rieken
ee3e404b71
disable failing smoketest, https://github.com/microsoft/vscode/issues/138748 2021-12-09 12:53:27 +01:00
Benjamin Pasero
c04c29d496
smoke - mention playwright trace website 2021-12-09 12:36:41 +01:00
Benjamin Pasero
9c7387bb5a
smoke - bring back stable smoke tests 2021-12-09 11:05:41 +01:00
Benjamin Pasero
27e38a8e27
smoke - always create screenshot on failure on desktop 2021-12-09 09:51:55 +01:00
Benjamin Pasero
ae0ee547ba
smoke - reimplement test handlers 2021-12-09 09:33:51 +01:00
Benjamin Pasero
158bd2507e
smoke - always have a logger 2021-12-09 08:48:42 +01:00
Benjamin Pasero
15415b6de6
smoke - align killing 2021-12-09 08:03:48 +01:00
Benjamin Pasero
ec3ba7a320
smoke - rewrite killing 2021-12-09 07:55:25 +01:00
Benjamin Pasero
acc0803f38
cleanup automation 2021-12-09 07:03:29 +01:00
Rob Lourens
1341ca3d7f Remove timeouts in search smoketest.
Improvements came from waiting for search to complete before clicking buttons, clearing previous results before starting the search, and adding a retry around the clicking.
2021-12-08 15:34:35 -08:00
Daniel Imms
465402dd4b Merge remote-tracking branch 'origin/main' into tyriar/137847 2021-12-08 06:28:35 -08:00
Benjamin Pasero
18cba4882d
smoke - more logging 2021-12-08 15:23:27 +01:00
Benjamin Pasero
64562e2a0e
smoke - reimplement logging 2021-12-08 14:13:41 +01:00
Benjamin Pasero
2c68d4de7e
smoke - always log with trace 2021-12-08 10:50:27 +01:00
Benjamin Pasero
fbad065eea
Playwright: record a trace per failing test, not suite (#138600)
* smoke - record traces per test and not entire suite

* smoke - only persist failing tests

* smoke - cleanup

* smoke - more logging

* smoke - push a test failure to proof the point

* smoke - switch back to chrome for smoke tests

* smoke - warn when exit takes 10s

* Revert "smoke - push a test failure to proof the point"

This reverts commit e572a0c40d.
2021-12-08 10:09:30 +01:00
Matt Bierner
c2f4daf348
Update webview bits version for tests 2021-12-07 16:16:54 -08:00
Tyler James Leonhardt
224701f74d
try remove timeouts in smoke tests for quickaccess (#138615) 2021-12-07 12:25:35 -08:00
Benjamin Pasero
13c0ed811e
🆙 playwright & set trace names (#138539) 2021-12-06 19:42:05 +01:00
Daniel Imms
110345a97b Try removing timeout in checkWindowReady
Part of #137847
2021-12-06 06:35:57 -08:00
Benjamin Pasero
2085b19a51
smoke - allow 30s max for deleting test path (#137725) 2021-12-06 14:09:02 +01:00
Benjamin Pasero
e8e0fb874d
smoke - disable test that is flaky still 2021-12-06 13:44:01 +01:00
Benjamin Pasero
fe227dacb7
lifecycle - introduce and adopt finalVeto for backups (#138055) 2021-12-06 11:16:57 +01:00
Benjamin Pasero
e1caacebce
backup - cancel pending operations on shutdown and handle cancellation better (#138055) 2021-12-06 10:55:33 +01:00
Benjamin Pasero
ff970e88e5
Revert "smoke - 🆙 retry timeout"
This reverts commit d60b844aa3.
2021-12-02 07:38:04 +01:00
Benjamin Pasero
9d427e4df4
smoke test tweaks
- remove timeout on shutdown
- log exactly where time is spend on shutdown (web)
- stop spawning code when terminated
2021-12-02 07:34:13 +01:00
Megan Rogge
4a21019476
fix #138238, skip failing test 2021-12-01 08:50:26 -08:00
Megan Rogge
c0f21fa378
fix #138239, skip test 2021-12-01 08:38:28 -08:00
Benjamin Pasero
d60b844aa3
smoke - 🆙 retry timeout 2021-12-01 11:34:25 +01:00
Megan Rogge
7b3078d931
fix #137795 2021-11-30 12:48:58 -08:00
Megan Rogge
7f7fad2f9e
fix #137798 2021-11-30 12:38:52 -08:00
Daniel Imms
faf6f0e1fd Setup terminal tests for 3 retries to minimize impact on build
This isn't a great long term solution but it should help reduce failures
for now.

Part of #137725
2021-11-30 12:19:10 -08:00
Megan Rogge
005947e3b8
fix #137722
fix #137808
2021-11-30 11:54:28 -08:00
Megan Rogge
e89889fe54
fix #137799 2021-11-30 11:21:01 -08:00
Megan Rogge
18725fc147
set default profile to pwsh for only windows for #137225 2021-11-30 10:57:59 -08:00
Megan Rogge
4be98a3bce
set default to pwsh instead of bash for #137725 2021-11-30 10:21:15 -08:00
Benjamin Pasero
7b6c1065c7
smoke - temporary bring back timeout 2021-11-30 11:04:39 +01:00
Daniel Imms
d5bfd6d31c Remove unneeded logs in test 2021-11-29 11:48:14 -08:00
Daniel Imms
e208c8604e Remove timeout from automation terminal util
I don't believe this was ever required, awaiting writeInTerminal should make sure the
data event is triggered in xterm, the following enter should just trigger another data
event. This doesn't guarantee it was accepted by the process yet, just that xterm.js
emitted the event.

Part of #137847
2021-11-29 11:46:57 -08:00
Benjamin Pasero
1af6cb0edc
smoke test tweaks 2021-11-29 17:53:11 +01:00
Benjamin Pasero
e241749320
smoke - print more backup info 2021-11-29 14:05:40 +01:00
Benjamin Pasero
18c6692316
tests - print main process pid when killing fails 2021-11-29 13:48:27 +01:00
Matt Bierner
f00c4da8b8
Update default webview commit 2021-11-29 12:27:23 +01:00
MalikIdreesHasanKhan
595d893fdc
Fixed typos. (#135729) 2021-11-29 11:32:14 +01:00
Benjamin Pasero
687521092d
smoke - print running tasks after smoke test run 2021-11-29 10:12:42 +01:00
Benjamin Pasero
12178a4cf7
unit - exclude more tests for node.js runs (#137853) 2021-11-29 10:02:03 +01:00
Benjamin Pasero
5bb653374f
smoke - diagnose failing backup test 2021-11-29 09:56:19 +01:00
Benjamin Pasero
cbbba8e69a
smoke - unique user data dir for stable tests too 2021-11-29 09:11:23 +01:00
Benjamin Pasero
c42793d035
smoke - do not fail build when unable to delete workspace folder (workaround #137725) 2021-11-29 08:49:37 +01:00
Benjamin Pasero
a5efd80ee0
Revert "smoke - print task list when deleting workspace path fails"
This reverts commit 368154bd0b.
2021-11-29 08:46:35 +01:00
Benjamin Pasero
368154bd0b
smoke - print task list when deleting workspace path fails 2021-11-29 08:04:30 +01:00
Benjamin Pasero
e71b28a444
Smoke test lifecycle changes (#137969)
* rewrite teardown

* 💄

* avoid spam errors

* 💄

* split spawning browser from electron

* await copyExtension

* cleanup

* refactor methods

* cleanup

* cleanup

* cleanup

* 🆙 deps
2021-11-28 10:30:52 +01:00
Benjamin Pasero
df4b5d6d04
smoke - strengthen shutdown path 2021-11-26 18:08:27 +01:00
Benjamin Pasero
13ff6baa3f
fix smoke tests 2021-11-26 14:45:35 +01:00
Benjamin Pasero
8d250e99e7
smoke - wait for tab becoming dirty before exit 2021-11-26 11:00:15 +01:00
Benjamin Pasero
a11814c57a
smoke - switch away from potentially flaky editors.selectTab method 2021-11-26 09:22:19 +01:00
Benjamin Pasero
6f2239307b
Smoke test tweaks (#137809)
* smoke - move data migration tests into one and align

* fix app starting

* `createWorkspaceFile` is not async

* 💄

* support screenshot on failure even for stable app

* smoke - try to remove timeout (#137847)

* improve exit call
2021-11-25 14:37:22 +01:00
Daniel Imms
eeae10e56c Skip flaky test
Part of #137795
2021-11-24 10:04:38 -08:00
Daniel Imms
653e5cdaee Skip flaky test
Part of #137808
2021-11-24 09:59:22 -08:00
Daniel Imms
f880669743
Merge pull request #137763 from microsoft/tyriar/cleanup_smoke
Move terminal smoke tests into a single suite and reduce boilterplate
2021-11-24 09:54:50 -08:00