development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-02 17:32:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

testing: debug test failures

Browse source 
For #137853
This commit is contained in:
Connor Peet 2021-12-14 09:47:26 -08:00
parent 209e9349fd
commit 2b19344369
No known key found for this signature in database
GPG key ID: CF8FD2EA0DBC61BD
2 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/vs/workbench/contrib/testing/test/common/testResultService.test.ts
View file

@ -62,7 +62,17 @@ suite('Workbench - Test Results Service', () => {
r.addTask({ id: 't', name: undefined, running: true });
tests = testStubs.nested();
await tests.expand(tests.root.id, Infinity);
const ok = await Promise.race([
Promise.resolve(tests.expand(tests.root.id, Infinity)).then(() => true),
timeout(1000).then(() => false),
]);
// todo@connor4312: debug for tests #137853:
if (!ok) {
throw new Error('timed out while expanding, diff: ' + JSON.stringify(tests.collectDiff()));
}
r.addTestChainToRun('ctrlId', [
Convert.TestItem.from(tests.root),
Convert.TestItem.from(tests.root.children.get('id-a') as TestItemImpl),

2
test/unit/node/index.js
View file

@ -28,8 +28,6 @@ const excludeGlob = '**/{browser,electron-sandbox,electron-browser,electron-main
const excludeModules = [
'vs/platform/environment/test/node/nativeModules.test.js', // native modules are compiled against Electron and this test would fail with node.js
'vs/base/parts/storage/test/node/storage.test.js', // same as above, due to direct dependency to sqlite native module
'vs/workbench/contrib/testing/test/common/testResultStorage.test.js', // TODO@connor4312 https://github.com/microsoft/vscode/issues/137853
'vs/workbench/contrib/testing/test/common/testResultService.test.js', // TODO@connor4312 https://github.com/microsoft/vscode/issues/137853
'vs/platform/files/test/common/files.test.js' // TODO@bpasero enable once we ship Electron 16
]