development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-07-05 01:08:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix #137795

Browse Source
This commit is contained in:
Megan Rogge 2021-11-30 12:48:58 -08:00
parent 7f7fad2f9e
commit 7b3078d931
No known key found for this signature in database
GPG Key ID: 69182D7934F25879
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/automation/src/terminal.ts
View File

@ -129,7 +129,8 @@ export class Terminal {
}
async getSingleTabName(): Promise<string> {
return await (await this.code.waitForElement(Selector.SingleTab, singleTab => !!singleTab && singleTab?.textContent.length > 1)).textContent;
const tab = await this.code.waitForElement(Selector.SingleTab, singleTab => !!singleTab && singleTab?.textContent.length > 1);
return tab.textContent;
}
private async assertTabExpected(selector?: string, listIndex?: number, nameRegex?: RegExp, icon?: string, color?: string): Promise<void> {

6
test/smoke/src/areas/terminal/terminal-tabs.test.ts
View File

@ -8,7 +8,7 @@ import { ParsedArgs } from 'minimist';
import { Application, Terminal, TerminalCommandId, TerminalCommandIdWithValue } from '../../../../automation/out';
export function setup(opts: ParsedArgs) {
describe.only('Terminal Tabs', () => {
describe('Terminal Tabs', () => {
// Acquire automation API
let terminal: Terminal;
before(function () {
@ -60,12 +60,12 @@ export function setup(opts: ParsedArgs) {
await terminal.assertSingleTab({ name });
});
// Flaky: https://github.com/microsoft/vscode/issues/137795
it.skip('should reset the tab name to the default value when no name is provided', async () => {
it('should reset the tab name to the default value when no name is provided', async () => {
await terminal.runCommand(TerminalCommandId.Show);
const defaultName = await terminal.getSingleTabName();
const name = 'my terminal name';
await terminal.runCommandWithValue(TerminalCommandIdWithValue.Rename, name);
await terminal.assertSingleTab({ name });
await terminal.runCommandWithValue(TerminalCommandIdWithValue.Rename, undefined);
await terminal.assertSingleTab({ name: defaultName });
});