development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-02 09:18:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests - improve exclusion handling for node.js tests

Browse source
This commit is contained in:
Benjamin Pasero 2022-04-21 17:10:10 +02:00
parent aa69f3d762
commit 08ac1bb67c
No known key found for this signature in database
GPG key ID: E6380CC4C8219E65
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
test/unit/node/index.js
View file

@ -25,11 +25,12 @@ const optimist = require('optimist')
const TEST_GLOB = '**/test/**/*.test.js';
const excludeGlob = '**/{browser,electron-sandbox,electron-browser,electron-main}/**/*.test.js';
const excludeModules = [
'vs/platform/environment/test/node/nativeModules.test.js', // native modules are compiled against Electron and this test would fail with node.js
'vs/base/parts/storage/test/node/storage.test.js', // same as above, due to direct dependency to sqlite native module
'vs/workbench/contrib/testing/test/common/testResultService.test.js' // flaky (https://github.com/microsoft/vscode/issues/137853)
const excludeGlobs = [
'**/{browser,electron-sandbox,electron-browser,electron-main}/**/*.test.js',
'**/vs/platform/environment/test/node/nativeModules.test.js', // native modules are compiled against Electron and this test would fail with node.js
'**/vs/base/parts/storage/test/node/storage.test.js', // same as above, due to direct dependency to sqlite native module
'**/vs/workbench/contrib/testing/test/**' // flaky (https://github.com/microsoft/vscode/issues/137853)
];
/**
@ -152,7 +153,7 @@ function main() {
/** @type {string[]} */
const modules = [];
for (let file of files) {
if (!minimatch(file, excludeGlob) && excludeModules.indexOf(file) === -1) {
if (!excludeGlobs.some(excludeGlob => minimatch(file, excludeGlob))) {
modules.push(file.replace(/\.js$/, ''));
}
}