4114 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Markus Olsson	69784deb0a	Merge pull request #712 from desktop/below-the-fold ... Close the foldout after selecting a repository	2016-12-05 08:27:51 +01:00
joshaber	cfc7ae083a	Close the foldout after selecting a repository	2016-12-02 10:33:44 -05:00
Josh Abernathy	663d8c8ebf	Merge pull request #688 from desktop/move-it-from-here-to-there ... refactoring diff logic for readability and separation of concerns	2016-12-02 10:25:39 -05:00
Brendan Forster	73a0b6fb4f	address review feedback	2016-12-02 14:02:01 +11:00
Brendan Forster	bb5acbb337	Merge pull request #710 from desktop/naming-things ... cleanup a lifecycle method signature	2016-12-02 10:27:43 +11:00
Brendan Forster	b7e19cfc47	props -> nextProps	2016-12-02 10:15:58 +11:00
Brendan Forster	9e5f9af289	Merge pull request #707 from desktop/proper-lifecycle-methods ... Enforce proper lifecycle methods	2016-12-02 09:54:31 +11:00
Josh Abernathy	e980af0647	Merge pull request #689 from desktop/windows-menu ... Windows app menu	2016-12-01 10:17:33 -05:00
Markus Olsson	8b8d851a7e	Remove trailing comma	2016-12-01 15:55:16 +01:00
Markus Olsson	437d02cef0	Don't explicitly pass undefined	2016-12-01 14:40:50 +01:00
Markus Olsson	28925f4aaa	Move retrieval and updating of menu to app store	2016-12-01 14:38:33 +01:00
Markus Olsson	70b7917c87	Add typed and documented ipc proxy for getting app menu	2016-12-01 14:38:12 +01:00
Markus Olsson	11d61e6f99	Fix violations	2016-12-01 14:19:35 +01:00
Markus Olsson	a1d5641787	Some day I will learn how to program	2016-12-01 14:19:25 +01:00
Markus Olsson	dfd4b94eb0	🔥 debug message	2016-12-01 14:19:16 +01:00
Markus Olsson	972cac4c81	🎨 cleanup	2016-12-01 14:19:10 +01:00
Markus Olsson	d410eacf14	Fix violation	2016-12-01 14:05:10 +01:00
Markus Olsson	b70ea1891f	Add rule prohibiting lifecycle-sounding method names	2016-12-01 14:05:04 +01:00
Markus Olsson	804417d50e	Splelling	2016-12-01 13:48:24 +01:00
Markus Olsson	3e1bc53dd6	Fix violation	2016-12-01 11:57:45 +01:00
Markus Olsson	58a4cd5e97	Only remove trailing void parameters	2016-12-01 11:57:40 +01:00
Markus Olsson	c7eab8d5b0	Allow omitting parameters, enforce omitting void parameters	2016-12-01 11:53:07 +01:00
Markus Olsson	5df13ded76	Add test for componentWillUpdate and refactor	2016-12-01 11:37:15 +01:00
Markus Olsson	bcd266fdab	Add test for componentWillReceiveProps	2016-12-01 11:14:38 +01:00
Markus Olsson	b8eaffa5f9	Remove logging	2016-12-01 11:14:04 +01:00
Markus Olsson	4677a57ea9	Fix typo in unrelated test	2016-12-01 11:02:50 +01:00
Markus Olsson	b6bb413dcd	Add stub test for improper use of lifecycle methods	2016-12-01 11:02:42 +01:00
Markus Olsson	e217cc9340	Clear timer when unmounting menu	2016-12-01 09:50:27 +01:00
Markus Olsson	35f28f3300	Merge remote-tracking branch 'origin/master' into windows-menu	2016-12-01 09:44:06 +01:00
Markus Olsson	cddd9624e3	Memoize feature flags that require restart	2016-12-01 09:40:18 +01:00
Markus Olsson	27d4bc2dea	Better naming of feature flag	2016-12-01 09:18:35 +01:00
Markus Olsson	f361c1f889	Don't use Object.assign to build up state object	2016-12-01 09:16:13 +01:00
Markus Olsson	7c2b0d84cb	Consistency	2016-12-01 09:13:55 +01:00
Markus Olsson	73e38951d0	🎨 indentation	2016-12-01 09:11:48 +01:00
Markus Olsson	49f341ca43	Optional id	2016-12-01 09:11:40 +01:00
Markus Olsson	e839946092	Exhaustive type checking	2016-12-01 09:09:03 +01:00
Markus Olsson	1d6fb6d8e5	📖 IMenu	2016-12-01 09:07:13 +01:00
Markus Olsson	180a225937	Typo	2016-12-01 08:12:38 +01:00
Markus Olsson	e20b2a9a4a	Clarify purpose on macOS	2016-12-01 08:12:08 +01:00
Brendan Forster	fe2641a2a9	clarified words	2016-12-01 18:02:52 +11:00
Brendan Forster	2f5b85ab81	and some docs	2016-12-01 17:26:49 +11:00
Brendan Forster	022646ce76	have a thicker border on the RHS of the diff gutter	2016-12-01 17:13:10 +11:00
Brendan Forster	f8055cccf8	only update the hover state if selection is not active, as the selection can handle it	2016-12-01 16:57:08 +11:00
Brendan Forster	84a0602a56	invert responsibility here and just return an updated diff selection	2016-12-01 16:56:29 +11:00
Brendan Forster	355ee1f266	move setSelected and setHover into DiffLineGutter and eliminate unnecessary callbacks	2016-12-01 16:42:34 +11:00
Brendan Forster	372bd9d9b0	some more cleanup	2016-12-01 16:08:23 +11:00
Brendan Forster	35d8090e79	simplify the entry point for onMouseDown	2016-12-01 16:06:46 +11:00
Brendan Forster	b1eec1ebb4	make this section more clear	2016-12-01 16:03:32 +11:00
Brendan Forster	08e9d375d3	cleanup isIncludeable	2016-12-01 16:01:29 +11:00
Brendan Forster	378be38fa7	a bit of cleanup	2016-12-01 15:52:51 +11:00